Skip to contentSkip to conversation

makedumpfile: s390x: Allow HW Change-bit override for page table entries

PATCH In review Michael Holzheu 2 participants 2 messages Nov 16, 2012 – Nov 20, 2012

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 makedumpfile: s390x: Allow HW Change-bit override for page table entries

The HW Change-bit override (0x100) is used now for s390x. This patch allows page table entries that have set this bit.

---
 arch/s390x.c   |    4 ++--
 makedumpfile.h |    1 -
 2 files changed, 2 insertions(+), 3 deletions(-)
arch/s390x.c +2 -2
@@ -195,10 +195,10 @@ static ulong _kl_pg_table_deref_s390x(un
 	readmem(VADDR, table + offset, &entry, sizeof(entry));
 	/*
 	 * Check if the page table entry could be read and doesn't have
-	 * any of the reserved bits set.
+	 * the reserved bit set.
 	 * Check if the page table entry has the invalid bit set.
 	 */
-	if (entry &  (_PAGE_CO | _PAGE_ZERO | _PAGE_INVALID)) {
+	if (entry &  (_PAGE_ZERO | _PAGE_INVALID)) {
 		ERRMSG("Invalid page table entry.\n");
 		return 0;
 	}
makedumpfile.h +0 -1
@@ -575,7 +575,6 @@ do { \
 #define _SEGMENT_INDEX_SHIFT	20
 
 /* Hardware bits in the page table entry */
-#define _PAGE_CO		0x100	/* HW Change-bit override */
 #define _PAGE_ZERO		0x800	/* Bit pos 52 must conatin zero */
 #define _PAGE_INVALID		0x400	/* HW invalid bit */
 #define _PAGE_INDEX_SHIFT	12

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw

Hello Michael,

Quoted 4 lines · On Fri, 16 Nov 2012 14:34:58 +0100 Michael Holzheu…

The HW Change-bit override (0x100) is used now for s390x. This patch allows page table entries that have set this bit.

Thanks for your work.
I will merge this patch into v1.5.2.

Thanks
Atsushi Kumagai

Quoted 32 lines
---
 arch/s390x.c   |    4 ++--
 makedumpfile.h |    1 -
 2 files changed, 2 insertions(+), 3 deletions(-)
arch/s390x.c +2 -2
@@ -195,10 +195,10 @@ static ulong _kl_pg_table_deref_s390x(un
 	readmem(VADDR, table + offset, &entry, sizeof(entry));
 	/*
 	 * Check if the page table entry could be read and doesn't have
-	 * any of the reserved bits set.
+	 * the reserved bit set.
 	 * Check if the page table entry has the invalid bit set.
 	 */
-	if (entry &  (_PAGE_CO | _PAGE_ZERO | _PAGE_INVALID)) {
+	if (entry &  (_PAGE_ZERO | _PAGE_INVALID)) {
 		ERRMSG("Invalid page table entry.\n");
 		return 0;
 	}
makedumpfile.h +0 -1
@@ -575,7 +575,6 @@ do { \
 #define _SEGMENT_INDEX_SHIFT	20
 
 /* Hardware bits in the page table entry */
-#define _PAGE_CO		0x100	/* HW Change-bit override */
 #define _PAGE_ZERO		0x800	/* Bit pos 52 must conatin zero */
 #define _PAGE_INVALID		0x400	/* HW invalid bit */
 #define _PAGE_INDEX_SHIFT	12
Quoted 4 lines

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec