Skip to contentSkip to conversation

kvm: Fix irqfd resampler list walk

PATCH Applied Alex Williamson 2 participants 4 messages Dec 6, 2012 – Jan 28, 2013 KVM

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 kvm: Fix irqfd resampler list walk

Typo for the next pointer means we're walking random data here.

---

Not sure if this will make 3.7, so preemptively adding the stable flag

 virt/kvm/eventfd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
virt/kvm/eventfd.c +1 -1
index 9718e98..62e7bd6 100644
@@ -332,7 +332,7 @@ kvm_irqfd_assign(struct kvm *kvm, struct kvm_irqfd *args)
 		mutex_lock(&kvm->irqfds.resampler_lock);
 
 		list_for_each_entry(resampler,
-				    &kvm->irqfds.resampler_list, list) {
+				    &kvm->irqfds.resampler_list, link) {
 			if (resampler->notifier.gsi == irqfd->gsi) {
 				irqfd->resampler = resampler;
 				break;
#1 lore raw
Quoted 10 lines · Alex Williamson

Typo for the next pointer means we're walking random data here.

---

Not sure if this will make 3.7, so preemptively adding the stable flag

 virt/kvm/eventfd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

#2 lore raw
Quoted 7 lines · Marcelo Tosatti
Quoted 6 lines · Alex Williamson

Typo for the next pointer means we're walking random data here.

---

Quoted 7 lines
Quoted 4 lines

Not sure if this will make 3.7, so preemptively adding the stable flag

 virt/kvm/eventfd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Hi Marcelo,

This didn't seem to make it into 3.7.0 or any stable 3.7. Can we promote it for stable? Thanks,

Alex

#3 lore raw
Quoted 16 lines · Alex Williamson
Quoted 7 lines · Marcelo Tosatti
Quoted 6 lines · Alex Williamson

Typo for the next pointer means we're walking random data here.

---

Quoted 7 lines
Quoted 4 lines

Not sure if this will make 3.7, so preemptively adding the stable flag

 virt/kvm/eventfd.c |    2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Applied, thanks.

Quoted 6 lines

Hi Marcelo,

This didn't seem to make it into 3.7.0 or any stable 3.7. Can we promote it for stable? Thanks,

Alex

Yes, please send the patch with the backport you're interested in being included to [email protected].

http://www.kernel.org/doc/Documentation/stable_kernel_rules.txt