Skip to contentSkip to conversation

kexec: ppc exec stack fix

PATCH Dave Young 2 participants 2 messages Dec 10, 2012 – Dec 13, 2012

Subsystems (2)
lore
Share & tools
lore

Dave Young

author
#0 lore raw

execstack shows ppc kexec has an executable stack, this leaves it vulnerable to buffer overflows.

Fix it by adding ASFLAGS --noexecstack

Tested on PowerMac G4 Macmini:
Without the patch:

dave@darkstar:~/kexec-tools$ execstack build/sbin/kexec 
X build/sbin/kexec

With the patch:

dave@darkstar:~/kexec-tools$ execstack build/sbin/kexec 
- build/sbin/kexec
---
 kexec/arch/ppc/Makefile |    2 ++
 1 file changed, 2 insertions(+)
kexec/arch/ppc/Makefile +2 -0
@@ -23,6 +23,8 @@ CPPFLAGS+=-I$(srcdir)/kexec/arch/$(ARCH)
 
 ppc_KEXEC_SRCS += $(libfdt_SRCS)
 
+ASFLAGS	+= -Wa,--noexecstack
+
 dist += kexec/arch/ppc/Makefile $(ppc_KEXEC_SRCS)			\
 	kexec/arch/ppc/crashdump-powerpc.h kexec/arch/ppc/fixup_dtb.h	\
 	kexec/arch/ppc/kexec-ppc.h kexec/arch/ppc/ops.h			\

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec

#1 lore raw
Quoted 8 lines · Dave Young

execstack shows ppc kexec has an executable stack, this leaves it vulnerable to buffer overflows.

Fix it by adding ASFLAGS --noexecstack

Tested on PowerMac G4 Macmini:
Without the patch:

Quoted 8 lines
dave@darkstar:~/kexec-tools$ execstack build/sbin/kexec 
X build/sbin/kexec

With the patch:

dave@darkstar:~/kexec-tools$ execstack build/sbin/kexec 
- build/sbin/kexec

Thanks Dave, applied.

_______________________________________________
kexec mailing list
[email protected]
http://lists.infradead.org/mailman/listinfo/kexec