Skip to contentSkip to conversation

iommu: Include linux/err.h

PATCH In review Wang YanQing 2 participants 3 messages Dec 13, 2012 – Jan 15, 2013 IOMMU

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 iommu: Include linux/err.h

The linux/iommu.h header uses ERR_PTR defined
in linux/err.h but doesn't include it.

---
 include/linux/iommu.h | 1 +
 1 file changed, 1 insertion(+)
include/linux/iommu.h +1 -0
index f3b99e1..f4a49a6 100644
@@ -20,6 +20,7 @@
 #define __LINUX_IOMMU_H
 
 #include <linux/errno.h>
+#include <linux/err.h>
 #include <linux/types.h>
 
 #define IOMMU_READ	(1)
Signature · 1 line
1.7.11.1.116.g8228a23
Reviewed-by on v1 1/1
#1 lore raw
Quoted 7 lines · Wang YanQing

The linux/iommu.h header uses ERR_PTR defined
in linux/err.h but doesn't include it.

---
 include/linux/iommu.h | 1 +
 1 file changed, 1 insertion(+)
Quoted 12 lines
include/linux/iommu.h +1 -0
index f3b99e1..f4a49a6 100644
@@ -20,6 +20,7 @@
 #define __LINUX_IOMMU_H
 
 #include <linux/errno.h>
+#include <linux/err.h>
 #include <linux/types.h>
 
 #define IOMMU_READ	(1)
#2 lore raw
Quoted 18 lines · Alex Williamson
Quoted 7 lines · Wang YanQing

The linux/iommu.h header uses ERR_PTR defined
in linux/err.h but doesn't include it.

---
 include/linux/iommu.h | 1 +
 1 file changed, 1 insertion(+)
Quoted 7 lines
include/linux/iommu.h +0 -0
index f3b99e1..f4a49a6 100644
@@ -20,6 +20,7 @@
 #define __LINUX_IOMMU_H
 
Quoted 7 lines

include/linux/iommu.h line 26

Quoted 5 lines
include/linux/iommu.h +1 -0
 #include <linux/errno.h>
+#include <linux/err.h>
 #include <linux/types.h>
 
 #define IOMMU_READ	(1)

Hi Joerg Roedel, maybe you are saturated by
Emails, and miss it.

Thanks