Skip to contentSkip to conversation

OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list

PATCH In review NeilBrown 2 participants 3 messages Dec 15, 2012 – Dec 17, 2012 Framebuffer layer

lore
Share & tools
lore

NeilBrown

author
#0 lore raw

PATCH 1/1 OMAP: DSS: add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list

commit 195e672a76056478cc79f5c48343164c9237852e
OMAPDSS: DPI: Remove cpu_is_xxxx checks

made the mistake of assuming that cpu_is_omap34xx() is exclusive of other cpu_is_* predicates whereas it includes cpu_is_omap3630().

So on an omap3630, code that was previously enabled by
if (cpu_is_omap34xx())
is now disabled as
dss_has_feature(FEAT_DPI_USES_VDDS_DSI)
fails.

So add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list.

Cc Chandrabhanu Mahapatra <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Signed-off-by NeilBrown <[email protected]>
drivers/video/omap2/dss/dss_features.c +1 -0
index acbc1e1..aaf3c3f 100644
@@ -546,6 +546,7 @@ static const enum dss_feat_id omap3630_dss_feat_list[] = {
 	FEAT_ALPHA_FIXED_ZORDER,
 	FEAT_FIFO_MERGE,
 	FEAT_OMAP3_DSI_FIFO_BUG,
+	FEAT_DPI_USES_VDDS_DSI,
 };
 
 static const enum dss_feat_id omap4430_es1_0_dss_feat_list[] = {
#1 lore raw
Quoted 25 lines · NeilBrown

commit 195e672a76056478cc79f5c48343164c9237852e
OMAPDSS: DPI: Remove cpu_is_xxxx checks

made the mistake of assuming that cpu_is_omap34xx() is exclusive of other cpu_is_* predicates whereas it includes cpu_is_omap3630().

So on an omap3630, code that was previously enabled by
if (cpu_is_omap34xx())
is now disabled as
dss_has_feature(FEAT_DPI_USES_VDDS_DSI)
fails.

So add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list.

Cc Chandrabhanu Mahapatra <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Signed-off-by NeilBrown <[email protected]>
drivers/video/omap2/dss/dss_features.c +0 -0
index acbc1e1..aaf3c3f 100644

drivers/video/omap2/dss/dss_features.c static const enum dss_feat_id omap3630_dss_feat_list[] = { · line 552

Quoted 7 lines
drivers/video/omap2/dss/dss_features.c +1 -0
@@ -546,6 +546,7 @@ static const enum dss_feat_id omap3630_dss_feat_list[] = {
 	FEAT_ALPHA_FIXED_ZORDER,
 	FEAT_FIFO_MERGE,
 	FEAT_OMAP3_DSI_FIFO_BUG,
+	FEAT_DPI_USES_VDDS_DSI,
 };
 
 static const enum dss_feat_id omap4430_es1_0_dss_feat_list[] = {

Thanks, looks correct. Did you encounter a bug related to this, or just happened to notice?

Tomi

author
#2 lore raw
Quoted 31 lines · On Mon, 17 Dec 2012 13:58:59 +0200 Tomi Valkeinen <[email protected]> wrote:
Quoted 30 lines · NeilBrown

commit 195e672a76056478cc79f5c48343164c9237852e
OMAPDSS: DPI: Remove cpu_is_xxxx checks

made the mistake of assuming that cpu_is_omap34xx() is exclusive of other cpu_is_* predicates whereas it includes cpu_is_omap3630().

So on an omap3630, code that was previously enabled by
if (cpu_is_omap34xx())
is now disabled as
dss_has_feature(FEAT_DPI_USES_VDDS_DSI)
fails.

So add FEAT_DPI_USES_VDDS_DSI to omap3630_dss_feat_list.

Cc Chandrabhanu Mahapatra <[email protected]>
Cc Tomi Valkeinen <[email protected]>
Signed-off-by NeilBrown <[email protected]>
drivers/video/omap2/dss/dss_features.c +1 -0
index acbc1e1..aaf3c3f 100644
@@ -546,6 +546,7 @@ static const enum dss_feat_id omap3630_dss_feat_list[] = {
 	FEAT_ALPHA_FIXED_ZORDER,
 	FEAT_FIFO_MERGE,
 	FEAT_OMAP3_DSI_FIFO_BUG,
+	FEAT_DPI_USES_VDDS_DSI,
 };
Quoted 6 lines

drivers/video/omap2/dss/dss_features.c static const enum dss_feat_id omap3630_dss_feat_list[] = { · line 552

Quoted 2 lines
drivers/video/omap2/dss/dss_features.c +0 -0
 static const enum dss_feat_id omap4430_es1_0_dss_feat_list[] = {

Thanks, looks correct. Did you encounter a bug related to this, or just happened to notice?

When I tried 3.7 on my gta04 phone the display had a slightly greenish (or maybe yellowish) tinge, particularly when viewed at an angle.
I at first thought it might be related to the changes in the panel configuration (I have an out-of-tree panel driver) but making changes there had no effect.
So I bit the bullet and did a git-bisect, and that is how I found that problem.

NeilBrown