Skip to contentSkip to conversation

arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat'

DISCUSSION Fengguang Wu 2 participants 3 messages Dec 19, 2012

lore
Share & tools
lore
#0 lore raw

Hi Linus, Wolfram,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
head:   752451f01c4567b506bf4343082682dbb8fb30dd
commit: 752451f01c4567b506bf4343082682dbb8fb30dd Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux
date:   56 minutes ago
config: make ARCH=arm omap2plus_defconfig

All error/warnings:

arch/arm/mach-omap2/i2c.c: In function 'omap_pm_set_max_mpu_wakeup_lat_compat':
arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

The root cause is, i2c.c (which is always compiled in arch/arm/mach-omap2/Makefile) uses omap_pm_set_max_mpu_wakeup_lat() which is defined in omap-pm-noop.c (which is compiled only on CONFIG_OMAP_PM_NOOP).

vim +/omap_pm_set_max_mpu_wakeup_lat +130 arch/arm/mach-omap2/i2c.c

752451f0 Linus Torvalds 2012-12-18  124   * XXX This function is a temporary compatibility wrapper - only
752451f0 Linus Torvalds 2012-12-18  125   * needed until the I2C driver can be converted to call
752451f0 Linus Torvalds 2012-12-18  126   * omap_pm_set_max_dev_wakeup_lat() and handle a return code.
752451f0 Linus Torvalds 2012-12-18  127   */
752451f0 Linus Torvalds 2012-12-18  128  static void omap_pm_set_max_mpu_wakeup_lat_compat(struct device *dev, long t)
752451f0 Linus Torvalds 2012-12-18  129  {
752451f0 Linus Torvalds 2012-12-18 @130  	omap_pm_set_max_mpu_wakeup_lat(dev, t);
752451f0 Linus Torvalds 2012-12-18  131  }
752451f0 Linus Torvalds 2012-12-18  132  
3a8761c0 Tony Lindgren  2012-10-08  133  static const char name[] = "omap_i2c";

---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation

#1 lore raw

[add more CC]

Quoted 37 lines · Fengguang Wu

Hi Linus, Wolfram,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
head:   752451f01c4567b506bf4343082682dbb8fb30dd
commit: 752451f01c4567b506bf4343082682dbb8fb30dd Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux
date:   56 minutes ago
config: make ARCH=arm omap2plus_defconfig

All error/warnings:

arch/arm/mach-omap2/i2c.c: In function 'omap_pm_set_max_mpu_wakeup_lat_compat':
arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

The root cause is, i2c.c (which is always compiled in arch/arm/mach-omap2/Makefile) uses omap_pm_set_max_mpu_wakeup_lat() which is defined in omap-pm-noop.c (which is compiled only on CONFIG_OMAP_PM_NOOP).

vim +/omap_pm_set_max_mpu_wakeup_lat +130 arch/arm/mach-omap2/i2c.c

752451f0 Linus Torvalds 2012-12-18  124   * XXX This function is a temporary compatibility wrapper - only
752451f0 Linus Torvalds 2012-12-18  125   * needed until the I2C driver can be converted to call
752451f0 Linus Torvalds 2012-12-18  126   * omap_pm_set_max_dev_wakeup_lat() and handle a return code.
752451f0 Linus Torvalds 2012-12-18  127   */
752451f0 Linus Torvalds 2012-12-18  128  static void omap_pm_set_max_mpu_wakeup_lat_compat(struct device *dev, long t)
752451f0 Linus Torvalds 2012-12-18  129  {
752451f0 Linus Torvalds 2012-12-18 @130  	omap_pm_set_max_mpu_wakeup_lat(dev, t);
752451f0 Linus Torvalds 2012-12-18  131  }
752451f0 Linus Torvalds 2012-12-18  132  
3a8761c0 Tony Lindgren  2012-10-08  133  static const char name[] = "omap_i2c";

---
0-DAY kernel build testing backend Open Source Technology Center
Fengguang Wu, Yuanhan Liu Intel Corporation

#2 lore raw
Quoted 22 lines · Fengguang Wu

[add more CC]

Quoted 19 lines · Fengguang Wu

Hi Linus, Wolfram,

FYI, kernel build failed on

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
head:   752451f01c4567b506bf4343082682dbb8fb30dd
commit: 752451f01c4567b506bf4343082682dbb8fb30dd Merge branch 'i2c-embedded/for-next' of git://git.pengutronix.de/git/wsa/linux
date:   56 minutes ago
config: make ARCH=arm omap2plus_defconfig

All error/warnings:

arch/arm/mach-omap2/i2c.c: In function 'omap_pm_set_max_mpu_wakeup_lat_compat':
arch/arm/mach-omap2/i2c.c:130:2: error: implicit declaration of function 'omap_pm_set_max_mpu_wakeup_lat' [-Werror=implicit-function-declaration]
cc1: some warnings being treated as errors

The root cause is, i2c.c (which is always compiled in arch/arm/mach-omap2/Makefile) uses omap_pm_set_max_mpu_wakeup_lat() which is defined in omap-pm-noop.c (which is compiled only on CONFIG_OMAP_PM_NOOP).

CONFIG_OMAP_PM_NOOP is defined. The build breakage is due to a missing header inclusion. I just sent a patch for this [1]

There are still a couple of patches missing before omap2plus_defconfig compiles
https://patchwork.kernel.org/patch/1810481/
https://patchwork.kernel.org/patch/1810441/

I guess they are on the way from some other tree.

Regards,
Vaibhav

[1] http://marc.info/?l=linux-arm-kernel&m=135589966017628&w=2