Skip to contentSkip to conversation

Fix several unlock issues in ipr driver

PATCH In review [email protected] 2 participants 3 messages Jan 2, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

cover Fix several unlock issues in ipr driver

The patch fixed several unlock issues in ipr driver.

Thanks,
Wendy

#1 lore raw

PATCH 1/1 ipr: Fix several unlock issues in ipr driver

This patch fixes several unlock issues in ipr driver.

---
 drivers/scsi/ipr.c |    5 +++--
 1 file changed, 3 insertions(+), 2 deletions(-)
drivers/scsi/ipr.c +3 -2
Index: b/drivers/scsi/ipr.c
===================================================================
@@ -4985,8 +4985,8 @@ static int __ipr_eh_dev_reset(struct scs
 					ipr_cmd->qc->flags |= ATA_QCFLAG_FAILED;
 				}
 			}
-		spin_unlock(&hrrq->_lock);
 		}
+		spin_unlock(&hrrq->_lock);
 	}
 	res->resetting_device = 1;
 	scmd_printk(KERN_ERR, scsi_cmd, "Resetting device\n");
@@ -5006,8 +5006,8 @@ static int __ipr_eh_dev_reset(struct scs
 					rc = -EIO;
 					break;
 				}
-			spin_unlock(&hrrq->_lock);
 			}
+			spin_unlock(&hrrq->_lock);
 		}
 	} else
 		rc = ipr_device_reset(ioa_cfg, res);
@@ -6663,6 +6663,7 @@ static unsigned int ipr_qc_issue(struct 
 
 	default:
 		WARN_ON(1);
+		spin_unlock(&ipr_cmd->hrrq->_lock);
 		return AC_ERR_INVALID;
 	}
 
Acked-by on v1 1/1
#2 lore raw

Re: [PATCH 1/1] ipr: Fix several unlock issues in ipr driver

Quoted 1 line · On 01/02/2013 04:26 PM, [email protected] wrote:

This patch fixes several unlock issues in ipr driver.

James - this fixes a couple regressions that were introduced in the previous patch set.

Signature · 3 lines
Brian King
Power Linux I/O
IBM Linux Technology Center