Skip to contentSkip to conversation

omap2430: kill redundant assignments in omap2430_probe()

PATCH New Sergei Shtylyov 1 participant 1 message Jan 8, 2013

Subsystems (3)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 omap2430: kill redundant assignments in omap2430_probe()

Commit 00a0b1d58af873d842580dcac55f3b156c3a4077 (usb: musb: omap: Add device tree support for omap musb glue) added assignments of the 'ret' variable to -ENOMEM on *some* error paths of the calls to devm_kzalloc(), while that variable was already pre-initialized for to that value, so these assignments were completely redundant. Kill them, fixing overindented string, while at it.

---
This patch is atop of 'musb' branch of Felipe's tree.

 drivers/usb/musb/omap2430.c |    4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/usb/musb/omap2430.c +1 -3
Index: usb/drivers/usb/musb/omap2430.c
===================================================================
@@ -532,15 +532,13 @@ static int __devinit omap2430_probe(stru
 		if (!pdata) {
 			dev_err(&pdev->dev,
 				"failed to allocate musb platfrom data\n");
-			ret = -ENOMEM;
 			goto err2;
 		}
 
 		data = devm_kzalloc(&pdev->dev, sizeof(*data), GFP_KERNEL);
 		if (!data) {
 			dev_err(&pdev->dev,
-					"failed to allocate musb board data\n");
-			ret = -ENOMEM;
+				"failed to allocate musb board data\n");
 			goto err2;
 		}
 

--
To unsubscribe from this list: send the line "unsubscribe linux-usb" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html