Skip to contentSkip to conversation

iio: fix Kconfig for max1363

PATCH In review Peter Meerwald 2 participants 2 messages Jan 10, 2013 – Jan 12, 2013 1 message not in the archive IIO

lore
Share & tools
lore

Peter Meerwald

author
#1 lore raw

PATCH 1/1 iio: fix Kconfig for max1363

In reply to a message not in the archive

ERROR: "iio_triggered_buffer_setup" [drivers/iio/adc/max1363.ko] undefined!
ERROR: "iio_triggered_buffer_cleanup" [drivers/iio/adc/max1363.ko] undefined!

add select IIO_TRIGGERED_BUFFER

IIO_TRIGGERED_BUFFER in turn selects IIO_TRIGGER and IIO_KFIFO_BUF, so drop those MAX1363_RING_BUFFER is not used anymore

Signed-off-by Peter Meerwald <[email protected]>
Cc Fengguang Wu <[email protected]>
---
 drivers/iio/adc/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/Kconfig +1 -3
index fe822a1..e372257 100644
@@ -100,10 +100,8 @@ config LP8788_ADC
 config MAX1363
 	tristate "Maxim max1363 ADC driver"
 	depends on I2C
-	select IIO_TRIGGER
-	select MAX1363_RING_BUFFER
 	select IIO_BUFFER
-	select IIO_KFIFO_BUF
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for many Maxim i2c analog to digital
 	  converters (ADC). (max1361, max1362, max1363, max1364, max1036,
Signature · 1 line
1.8.0.3
maintainer
#2 lore raw
Quoted 10 lines · Peter Meerwald

ERROR: "iio_triggered_buffer_setup" [drivers/iio/adc/max1363.ko] undefined!
ERROR: "iio_triggered_buffer_cleanup" [drivers/iio/adc/max1363.ko] undefined!

add select IIO_TRIGGERED_BUFFER

IIO_TRIGGERED_BUFFER in turn selects IIO_TRIGGER and IIO_KFIFO_BUF, so drop those MAX1363_RING_BUFFER is not used anymore

Signed-off-by Peter Meerwald <[email protected]>
Cc Fengguang Wu <[email protected]>

Thanks,

Have added a reported by tag for Fengguang Wu and added to togreg branch of iio.git

Quoted 21 lines
---
 drivers/iio/adc/Kconfig | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)
drivers/iio/adc/Kconfig +1 -3
index fe822a1..e372257 100644
@@ -100,10 +100,8 @@ config LP8788_ADC
 config MAX1363
 	tristate "Maxim max1363 ADC driver"
 	depends on I2C
-	select IIO_TRIGGER
-	select MAX1363_RING_BUFFER
 	select IIO_BUFFER
-	select IIO_KFIFO_BUF
+	select IIO_TRIGGERED_BUFFER
 	help
 	  Say yes here to build support for many Maxim i2c analog to digital
 	  converters (ADC). (max1361, max1362, max1363, max1364, max1036,