Skip to contentSkip to conversation

usb: gadget: precedence bug in show_requests()

PATCH In review Dan Carpenter 2 participants 2 messages Jan 20, 2013 – Jan 24, 2013

Subsystems (3)
USB Kernel janitors Chipidea USB high speed dual role controller
lore
Share & tools
lore

Dan Carpenter

author
#0 lore raw

PATCH v2 1/1 usb: gadget: precedence bug in show_requests()

The intent here was to have parenthesis around the (ci->hw_ep_max / 2) so that it counts like "0 1 2 0 1 2". In the current code, the mod operation happens first so it counts like "0 0 1 1 2 2".

Signed-off-by Dan Carpenter <[email protected]>

---
v2: fixed the changelog. mod and divide have the same precedence

drivers/usb/chipidea/debug.c +1 -1
index 3bc244d..3cd223c 100644
@@ -709,7 +709,7 @@ static ssize_t show_requests(struct device *dev, struct device_attribute *attr,
 
 			n += scnprintf(buf + n, PAGE_SIZE - n,
 					"EP=%02i: TD=%08X %s\n",
-					i % ci->hw_ep_max/2, (u32)req->dma,
+					i % (ci->hw_ep_max / 2), (u32)req->dma,
 					((i < ci->hw_ep_max/2) ? "RX" : "TX"));
 
 			for (j = 0; j < qSize; j++)