tm6000: check an allocation for failure

PATCH New Dan Carpenter 1 participant 1 message Jan 30, 2013

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2013-01-30 07:03 UTC #0 lore raw

PATCH 1/1 tm6000: check an allocation for failure

This allocation had no error checking. It didn't need to be under the mutex so I moved it out form there. That makes the error handling easier and is a potential speed up.

Signed-off-by Dan Carpenter <[email protected]>

drivers/media/usb/tm6000/tm6000-core.c +6 -3

index 22cc011..7c32353 100644
@@ -40,10 +40,13 @@ int tm6000_read_write_usb(struct tm6000_core *dev, u8 req_type, u8 req,
 	u8	     *data = NULL;
 	int delay = 5000;
 
-	mutex_lock(&dev->usb_lock);
-
-	if (len)
+	if (len) {
 		data = kzalloc(len, GFP_KERNEL);
+		if (!data)
+			return -ENOMEM;
+	}
+
+	mutex_lock(&dev->usb_lock);
 
 	if (req_type & USB_DIR_IN)
 		pipe = usb_rcvctrlpipe(dev->udev, 0);