ext4: speed-up releasing blocks on commit]

PATCH Andrey Sidorov 2 participants 4 messages Mar 13, 2013 – Mar 28, 2013 3 messages not in the archive

lore

Share & tools

lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

Andrey Sidorov

author

2013-03-13 11:21 UTC #3 lore raw

Hi Alex,

Thanks for review! I'll post rebased patch with comments and some ascii art this weekend.

Quoted 11 lines

the patch looks fine, the only suggestion is to move the following logic into mb_buddy_mark_free():
+ if (first & 1) {
+ first += !left_is_free;
+ e4b->bd_info->bb_counters[0] += left_is_free ? -1 : 1;
+ }
+ if (!(last & 1)) {
+ last -= !right_is_free;
+ e4b->bd_info->bb_counters[0] += right_is_free ? -1 : 1;
+ }

I didn't do that since buddy[0] is a special case since it is in fact bd_bitmap itself. Moving that into mb_buddy_mark_free will make code look worse because of this special handling. I think unrolling first iteration that handles bd_bitmap looks much better.

Regards,
Andrey.

Theodore Ts'o

2013-03-13 11:37 UTC #4 lore raw

Quoted 4 lines · Andrey Sidorov

Hi Alex,
Thanks for review! I'll post rebased patch with comments and some ascii art this weekend.

Was the review cc'ed to the linux-ext4 list? I didn't see it. Could someone forward it to me? Thanks!!

- Ted

Theodore Ts'o

2013-03-27 14:57 UTC #5 lore raw

In reply to Andrey Sidorov

Quoted 3 lines · Andrey Sidorov

Thanks for review! I'll post rebased patch with comments and some ascii art this weekend.

Hi Andrey, have you had a chance to post a rebased patch for your proposed change? If not, it would be great if you could look at doing this against either 3.9-rc4 or the ext4 dev branch, since we're not actively looking at patches for the next merge window.

Thanks!!

- Ted

Andrey Sidorov

author

2013-03-28 19:30 UTC #6 lore raw

Hi Ted,

I've just posted version rebased to yesterday's ext4 dev. Regards,
Andrey.

Quoted 13 lines · Theodore Ts'o

Quoted 3 lines · Andrey Sidorov
Thanks for review! I'll post rebased patch with comments and some ascii art this weekend.
Hi Andrey, have you had a chance to post a rebased patch for your proposed change? If not, it would be great if you could look at doing this against either 3.9-rc4 or the ext4 dev branch, since we're not actively looking at patches for the next merge window.
Thanks!!
- Ted