Skip to contentSkip to conversation

btrfs-progs: question about error message

DISCUSSION Jerry Snitselaar 2 participants 2 messages Feb 6, 2013 – Feb 8, 2013 Btrfs file system

lore
Share & tools
lore
#0 lore raw

In some testing that was being done the tester ran into the following:

--

/mnt/abo is a filesystem in Raid1-configuration having two disks: /dev/sdg2 and /dev/sdg3. When trying to remove one of the devices, you get this error on the console:

# btrfs device delete /dev/sdg2 /mnt/abo 
ERROR: error removing the device '/dev/sdg2' - Invalid argument 

/var/log/messages shows the real error:

Jan 29 13:54:58 ca-ostest202 kernel: btrfs: unable to go below two devices on 

raid1

The error message on the console output is wrong : '/dev/sdg2' is not an invalid argument, there's another reason why the delete-action can't be executed.

--

Looking at it I can see the EINVAL being correct because it is being told to remove a member from a raid1 with only 2 members, but I can see how that message could be confusing as well. Is there some place that tells users to look at /var/log/messages to see the other message? Wondering if the error message should point users to /var/log/messages to get more details.

#1 lore raw
Quoted 19 lines · Jerry Snitselaar

In some testing that was being done the tester ran into the following:

--

/mnt/abo is a filesystem in Raid1-configuration having two disks: /dev/sdg2 and /dev/sdg3. When trying to remove one of the devices, you get this error on the console:

# btrfs device delete /dev/sdg2 /mnt/abo 
ERROR: error removing the device '/dev/sdg2' - Invalid argument 

/var/log/messages shows the real error:

Jan 29 13:54:58 ca-ostest202 kernel: btrfs: unable to go below two devices on 

raid1

The error message on the console output is wrong : '/dev/sdg2' is not an invalid argument, there's another reason why the delete-action can't be executed.

Quoted 8 lines

--

Looking at it I can see the EINVAL being correct because it is being told to remove a member from a raid1 with only 2 members, but I can see how that message could be confusing as well. Is there some place that tells users to look at /var/log/messages to see the other message? Wondering if the error message should point users to /var/log/messages to get more details.

The error message means that the action (done via a ioctl() call) returned EINVAL, and there's no established interface to accompany the numer with a message. Adding a notice about looking into /var/log/messages would be better (similar to what a failed mount does).

Also, I think the error code could be changed to EPERM, because this says that the operation is valid, but not possible to do under current circumstances.

david