Skip to contentSkip to conversation

sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers

PATCH In review H Hartley Sweeten 2 participants 2 messages Feb 6, 2013 – Feb 7, 2013 Sound

lore
Share & tools
lore
#0 lore raw

PATCH 11/11 sound/pcmcia: use module_pcmcia_driver() in pcmcia drivers

Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers.

---
 sound/pcmcia/pdaudiocf/pdaudiocf.c | 15 +--------------
 sound/pcmcia/vx/vxpocket.c         | 14 +-------------
 2 files changed, 2 insertions(+), 27 deletions(-)
sound/pcmcia/pdaudiocf/pdaudiocf.c +1 -14
index f9b5229..8f489de 100644
@@ -295,18 +295,5 @@ static struct pcmcia_driver pdacf_cs_driver = {
 	.suspend	= pdacf_suspend,
 	.resume		= pdacf_resume,
 #endif
-
 };
-
-static int __init init_pdacf(void)
-{
-	return pcmcia_register_driver(&pdacf_cs_driver);
-}
-
-static void __exit exit_pdacf(void)
-{
-	pcmcia_unregister_driver(&pdacf_cs_driver);
-}
-
-module_init(init_pdacf);
-module_exit(exit_pdacf);
+module_pcmcia_driver(pdacf_cs_driver);
sound/pcmcia/vx/vxpocket.c +1 -13
index 8f93504..d4db7ec 100644
@@ -367,16 +367,4 @@ static struct pcmcia_driver vxp_cs_driver = {
 	.resume		= vxp_resume,
 #endif
 };
-
-static int __init init_vxpocket(void)
-{
-	return pcmcia_register_driver(&vxp_cs_driver);
-}
-
-static void __exit exit_vxpocket(void)
-{
-	pcmcia_unregister_driver(&vxp_cs_driver);
-}
-
-module_init(init_vxpocket);
-module_exit(exit_vxpocket);
+module_pcmcia_driver(vxp_cs_driver);
Signature · 1 line
1.8.1.1.293.gfe73786
Acked-by on v1 11/11
#1 lore raw

At Wed, 6 Feb 2013 15:32:50 -0700,

Quoted 5 lines · H Hartley Sweeten

Use the new module_pcmcia_driver() macro to remove the boilerplate module init/exit code in the pcmcia drivers.

(But please add subsystem maintainers to Cc at the next time...)

Takashi

Quoted 60 lines
---
 sound/pcmcia/pdaudiocf/pdaudiocf.c | 15 +--------------
 sound/pcmcia/vx/vxpocket.c         | 14 +-------------
 2 files changed, 2 insertions(+), 27 deletions(-)
sound/pcmcia/pdaudiocf/pdaudiocf.c +1 -14
index f9b5229..8f489de 100644
@@ -295,18 +295,5 @@ static struct pcmcia_driver pdacf_cs_driver = {
 	.suspend	= pdacf_suspend,
 	.resume		= pdacf_resume,
 #endif
-
 };
-
-static int __init init_pdacf(void)
-{
-	return pcmcia_register_driver(&pdacf_cs_driver);
-}
-
-static void __exit exit_pdacf(void)
-{
-	pcmcia_unregister_driver(&pdacf_cs_driver);
-}
-
-module_init(init_pdacf);
-module_exit(exit_pdacf);
+module_pcmcia_driver(pdacf_cs_driver);
sound/pcmcia/vx/vxpocket.c +1 -13
index 8f93504..d4db7ec 100644
@@ -367,16 +367,4 @@ static struct pcmcia_driver vxp_cs_driver = {
 	.resume		= vxp_resume,
 #endif
 };
-
-static int __init init_vxpocket(void)
-{
-	return pcmcia_register_driver(&vxp_cs_driver);
-}
-
-static void __exit exit_vxpocket(void)
-{
-	pcmcia_unregister_driver(&vxp_cs_driver);
-}
-
-module_init(init_vxpocket);
-module_exit(exit_vxpocket);
+module_pcmcia_driver(vxp_cs_driver);
Signature · 7 lines
1.8.1.1.293.gfe73786

--
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at  http://www.tux.org/lkml/