dc395x: uninitialized variable in device_alloc()
Subsystems (3)
PATCH 1/1 dc395x: uninitialized variable in device_alloc()
This bug was introduced back in bitkeeper days in 2003. We use "dcb->dev_mode" before it has been initialized.
Signed-off-by Dan Carpenter <[email protected]>
drivers/scsi/dc395x.c +1 -1
@@ -3747,13 +3747,13 @@ static struct DeviceCtlBlk *device_alloc(struct AdapterCtlBlk *acb, dcb->max_command =1 ; dcb->target_id = target; dcb->target_lun = lun; + dcb->dev_mode = eeprom->target[target].cfg0;#ifndef DC395x_NO_DISCONNECT dcb->identify_msg IDENTIFY(dcb->dev_mode & NTC_DO_DISCONNECT, lun);#else dcb->identify_msg =IDENTIFY (0 , lun);#endif - dcb->dev_mode = eeprom->target[target].cfg0; dcb->inquiry7 =0 ; dcb->sync_mode =0 ; dcb->min_nego_period = clock_period[period_index];
Quoted 4 lines · On Monday 11 February 2013 22:03:18 Dan Carpenter wrote:
This bug was introduced back in bitkeeper days in 2003. We use "
dcb->dev_mode" before it has been initialized.Signed-off-by Dan Carpenter <[email protected]>
Acked-by Oliver Neukum <[email protected]>