Skip to contentSkip to conversation

parisc: convert msgrcv and msgsnd syscalls to use compat layer

PATCH In review Helge Deller 2 participants 3 messages Feb 11, 2013 – Feb 19, 2013 PA-RISC architecture

lore
Share & tools
lore

Helge Deller

author maintainer
#0 lore raw

PATCH 1/1 parisc: convert msgrcv and msgsnd syscalls to use compat layer

The currently used hand-crufted implementation is partly buggy and returned different error return codes.

arch/parisc/Kconfig +4 -0
index 3df1c35..81bc84f 100644
@@ -272,6 +272,10 @@ config COMPAT
 	def_bool y
 	depends on 64BIT
 
+config SYSVIPC_COMPAT
+	def_bool y
+	depends on SYSVIPC
+
 config HPUX
 	bool "Support for HP-UX binaries"
 	depends on !64BIT
arch/parisc/include/asm/compat.h +61 -0

73 lines not on this page · raw message

arch/parisc/kernel/sys_parisc32.c +0 -57

66 lines not on this page · raw message

#1 lore raw
Quoted 1 line · Helge Deller

The currently used hand-crufted implementation is partly buggy and returned

                            ^

Maybe an apt typo? :)

Quoted 1 line

different error return codes.

author maintainer
#2 lore raw

* Matt Turner <[email protected]>:

Quoted 5 lines · Helge Deller
Quoted 1 line

The currently used hand-crufted implementation is partly buggy and returned

                            ^

Maybe an apt typo? :)

:-)

Anyway, I missed the dependency on CONFIG_COMPAT and as such the 32bit build got broken. Here is the updated patch...

Helge

commit 4132dad5ac5df6ae669c70d2a3e5a834a8b8076f

Author: Helge Deller <[email protected]>
Date:   Tue Feb 19 20:47:37 2013 +0100

parisc: convert msgrcv and msgsnd syscalls to use compat layer

Switch over to use the existing compat_* implementation for msgrcv() and msgsnd(). Existing code was even partly buggy since it returned on some paths different error codes than the standard.

arch/parisc/Kconfig +4 -0
index 3df1c35..af48d26 100644
@@ -272,6 +272,10 @@ config COMPAT
 	def_bool y
 	depends on 64BIT
 
+config SYSVIPC_COMPAT
+	def_bool y
+	depends on COMPAT && SYSVIPC
+
 config HPUX
 	bool "Support for HP-UX binaries"
 	depends on !64BIT
arch/parisc/include/asm/compat.h +61 -0

73 lines not on this page · raw message

arch/parisc/kernel/sys_parisc32.c +0 -57

66 lines not on this page · raw message