Skip to contentSkip to conversation

Guidelines to move mach-omap2/gpmc to drivers/memory-controller

DISCUSSION Ezequiel Garcia 3 participants 5 messages Feb 15, 2013 – Feb 20, 2013

lore
Share & tools
lore
#0 lore raw

Hello,

I'd like to know which are the current constraints preventing us from moving OMAP's GPMC memory controller driver from mach-omap2/ to drivers/memory-controller.

I imagine one of the biggest issues is GPMC's dependency on hwmod code. Can anyone shed some light on how to handle this?

Is there any way to move hwmod to some place under drivers/...?

Thanks,

Signature · 7 lines
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#1 lore raw

Hi,

Quoted 2 lines · Ezequiel Garcia

I imagine one of the biggest issues is GPMC's dependency on hwmod code. Can anyone shed some light on how to handle this?

What dependency is this? I'm not aware of any GPMC dependency to hwmod; there shouldn't be any.

- Paul

#2 lore raw
Quoted 9 lines · Paul Walmsley

Hi,

Quoted 2 lines · Ezequiel Garcia

I imagine one of the biggest issues is GPMC's dependency on hwmod code. Can anyone shed some light on how to handle this?

What dependency is this? I'm not aware of any GPMC dependency to hwmod; there shouldn't be any.

If Ezequiel is referring to the code in omap_gpmc_init() that is looking up the hwmod struct for gpmc, then this not a dependency. This function should remain in mach-omap2/gpmc.c and not be moved into drivers/. Eventually once we have migrated to DT, this function will be removed altogether.

Cheers
Jon

#3 lore raw

Hi Jon,

Quoted 9 lines · Jon Hunter
Quoted 7 lines · Paul Walmsley

Hi,

Quoted 2 lines · Ezequiel Garcia

I imagine one of the biggest issues is GPMC's dependency on hwmod code. Can anyone shed some light on how to handle this?

Quoted 6 lines
Quoted 2 lines

What dependency is this? I'm not aware of any GPMC dependency to hwmod; there shouldn't be any.

If Ezequiel is referring to the code in omap_gpmc_init() that is looking up the hwmod struct for gpmc, then this not a dependency. This function should remain in mach-omap2/gpmc.c and not be moved into drivers/.

Yes, I was referring to that code.

Quoted 3 lines

Eventually once we have migrated to DT, this function will be removed altogether.

Mmm, I see. So I might try to move GPMC and friends to drivers/memory keeping the hwmod code inside mach-omap2.

I already did a few tests and I **think** that with a little luck we can have a not-so-intrusive patch that moves GPMC.

@Jon: Do you think it's worth the effort?

Signature · 7 lines
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
--
To unsubscribe from this list: send the line "unsubscribe linux-omap" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html
#4 lore raw
Quoted 25 lines · Ezequiel Garcia

Hi Jon,

Quoted 9 lines · Jon Hunter
Quoted 7 lines · Paul Walmsley

Hi,

Quoted 2 lines · Ezequiel Garcia

I imagine one of the biggest issues is GPMC's dependency on hwmod code. Can anyone shed some light on how to handle this?

Quoted 6 lines
Quoted 2 lines

What dependency is this? I'm not aware of any GPMC dependency to hwmod; there shouldn't be any.

If Ezequiel is referring to the code in omap_gpmc_init() that is looking up the hwmod struct for gpmc, then this not a dependency. This function should remain in mach-omap2/gpmc.c and not be moved into drivers/.

Yes, I was referring to that code.

Quoted 3 lines

Eventually once we have migrated to DT, this function will be removed altogether.

Quoted 7 lines

Mmm, I see. So I might try to move GPMC and friends to drivers/memory keeping the hwmod code inside mach-omap2.

I already did a few tests and I **think** that with a little luck we can have a not-so-intrusive patch that moves GPMC.

@Jon: Do you think it's worth the effort?

Yes absolutely! We want all the drivers out of mach-omap2. So that would be great.

Cheers
Jon