gssd: use correct test for success of getrlimit()
Subsystems (2)
PATCH 1/1 gssd: use correct test for success of getrlimit()
commit 7c5cb5e732a4b8704f8c79ec819c5d271e040339
gssd: base the size of the fd array on the RLIMIT_NOFILE limit.
didn't actually work as claimed. It only uses the returned value if getrlimit() returns -1 -- which of course it only does when there was an error.
So change the test to "== 0".
Reported-by Leonardo Chiquitto< [email protected]>
Signed-off-by NeilBrown <[email protected]>
--
hangs head in shame .... NeilBrown
utils/gssd/gssd_proc.c +1 -1
@@ -477,7 +477,7 @@ init_client_list(void)TAILQ_INIT (&clnt_list);/* Eventually plan to grow/shrink poll array: */ pollsize =FD_ALLOC_BLOCK ; -if (getrlimit (RLIMIT_NOFILE , &rlim) <0 && +if (getrlimit (RLIMIT_NOFILE , &rlim) ==0 && rlim.rlim_cur !=RLIM_INFINITY ) pollsize = rlim.rlim_cur; pollarray =calloc (pollsize,sizeof (struct pollfd ));
Quoted 8 lines · NeilBrown
commit
7c5cb5e732a4b8704f8c79ec819c5d271e040339
gssd: base the size of the fd array on theRLIMIT_NOFILElimit.didn't actually work as claimed. It only uses the returned value if
getrlimit()returns -1 -- which of course it only does when there was an error.
Quoted 7 lines
So change the test to "== 0".
Reported-by Leonardo Chiquitto< [email protected]>Signed-off-by NeilBrown <[email protected]>--
hangs head in shame .... NeilBrown
Committed...
steved.
Quoted 15 lines
utils/gssd/gssd_proc.c +1
-1@@ -477,7 +477,7 @@ init_client_list(void)TAILQ_INIT (&clnt_list);/* Eventually plan to grow/shrink poll array: */ pollsize =FD_ALLOC_BLOCK ; -if (getrlimit (RLIMIT_NOFILE , &rlim) <0 && +if (getrlimit (RLIMIT_NOFILE , &rlim) ==0 && rlim.rlim_cur !=RLIM_INFINITY ) pollsize = rlim.rlim_cur; pollarray =calloc (pollsize,sizeof (struct pollfd ));