Skip to contentSkip to conversation

Improve QNX support in GIT

PATCH Matt Kraai 3 participants 4 messages Jun 15, 2016

lore
Share & tools
lore

Matt Kraai

author
#0 lore raw

Hi,

Please include me in the Cc field, since I'm not subscribed to the list.

Quoted 4 lines · Mike Gorchak

Do you have a testcase for this (without using git codebase)? I wrote numerous resource managers since QNX 6.0 using threads and fork()s for daemonization in different order and never experienced a problems. There can be issues with pipes in case of external command run.

I just created the following one:

#include <pthread.h>
#include <stdio.h>
#include <string.h>
#include <errno.h>
#include <sys/types.h>
#include <process.h>

static void *
start_routine (void *arg)
{
return NULL;
}

int
main (int argc, char **argv)
{
int err;

if ((err = pthread_create (NULL, NULL, start_routine, NULL)))

    {
      fprintf (stderr, "foo: pthread_create failed: %s\n", strerror (errno));
      return 1;
    }
  if (fork () == -1)
    {
      fprintf (stderr, "foo: fork failed: %s\n", strerror (errno));
      return 1;
    }

return 0;
}

When I compile and run it on either QNX 6.3.2 or QNX 6.5.0, it produces the following output:

foo: fork failed: Function not implemented

If I remove the call to pthread_create, it doesn't output anything and exits successfully.

#1 lore raw
Quoted 2 lines

If I remove the call to pthread_create, it doesn't output anything and exits successfully.

I see. Most resource managers use procmgr_daemon(), which has no such limitation. Anyway, as far as I can see current git sources do not use fork together with pthread, except for daemonize() function.

author
#2 lore raw
Quoted 3 lines · Mike Gorchak

I see. Most resource managers use procmgr_daemon(), which has no such limitation. Anyway, as far as I can see current git sources do not use fork together with pthread, except for daemonize() function.

If threads are enabled, git does use fork after calling pthread_create:

* When I run "git grep foo".
* When I run "git fetch" to update my git working copy, which is using an HTTPS remote.

Both of these commands fail as a result.

#3 lore raw
In reply to Mike Gorchak

Am 26.02.2013 21:32, schrieb Mike Gorchak:

Quoted 6 lines
Quoted 2 lines

If I remove the call to pthread_create, it doesn't output anything and exits successfully.

I see. Most resource managers use procmgr_daemon(), which has no such limitation. Anyway, as far as I can see current git sources do not use fork together with pthread, except for daemonize() function.

Not true: When a clean or smudge filter is configured, a thread is created, and the thread runs the external program via fork().

-- Hannes