Skip to contentSkip to conversation

wlan-ng: add a bounds check

PATCH In review Dan Carpenter 1 participant 1 message Feb 27, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 2/2 wlan-ng: add a bounds check

I'm not sure where these results come from, but it can't hurt to add a sanity check the array offset. The .results[] array on the next line has HFA384x_CHINFORESULT_MAX (16) elements.

drivers/staging/wlan-ng/prism2sta.c +3 -0
index dc221f2..428a9be 100644
@@ -1170,6 +1170,9 @@ static void prism2sta_inf_chinforesults(wlandevice_t *wlandev,
 		result = &inf->info.chinforesult.result[n];
 		chan = le16_to_cpu(result->chid) - 1;
 
+		if (chan < 0 || chan >= HFA384x_CHINFORESULT_MAX)
+			continue;
+
 		chinforesult = &hw->channel_info.results.result[chan];
 		chinforesult->chid = chan;
 		chinforesult->anl = le16_to_cpu(result->anl);