Skip to contentSkip to conversation

Fix: Undefined behavior of double free on strlist in get_names_args

PATCH New Christian Babeux 2 participants 2 messages Feb 28, 2013 – Mar 1, 2013 2 messages not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20130228225429.GA915@Krystal

#1 lore raw

PATCH 1/1 Fix: Undefined behavior of double free on strlist in get_names_args

---
 converter/babeltrace.c | 1 -
 1 file changed, 1 deletion(-)
converter/babeltrace.c +0 -1
index 20ded00..ed19fa8 100644
@@ -204,7 +204,6 @@ static int get_names_args(poptContext *pc)
 			opt_payload_field_names = 0;
 		} else {
 			fprintf(stderr, "[error] unknown field name type %s\n", str);
-			free(strlist);
 			ret = -EINVAL;
 			goto end;
 		}
Signature · 1 line
1.8.1.3

A message that is not in the archive (sent off-list or not yet received): [email protected]

#3 lore raw
Quoted 2 lines · * Christian Babeux ([email protected]) wrote:

Merged, thanks!

Mathieu

Quoted 19 lines
---
 converter/babeltrace.c | 1 -
 1 file changed, 1 deletion(-)
converter/babeltrace.c +0 -1
index 20ded00..ed19fa8 100644
@@ -204,7 +204,6 @@ static int get_names_args(poptContext *pc)
 			opt_payload_field_names = 0;
 		} else {
 			fprintf(stderr, "[error] unknown field name type %s\n", str);
-			free(strlist);
 			ret = -EINVAL;
 			goto end;
 		}
Signature · 1 line
1.8.1.3
Signature · 3 lines
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com