Skip to contentSkip to conversation

cifs: bugfix for unreclaimed writeback pages in cifs_writev_requeue()

DISCUSSION Anton Altaparmakov 2 participants 2 messages Mar 4, 2013 1 message not in the archive

Subsystems (2)
lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): [email protected]

#1 lore raw

Hi,

The below commit that is present in 3.9-rc1 is buggy. It releases the page at which point it may no longer exist and then it unlocks it afterwards. Even if you are somehow getting away with it I think it is an explosion/memory corruption waiting to happen...

Best regards,

Anton

Quoted 56 lines · Linux Kernel Mailing List
Gitweb:     http://git.kernel.org/linus/;a=commit;h=c51bb0ea40ca038da26b1fa7d450f4078124af03
Commit:     c51bb0ea40ca038da26b1fa7d450f4078124af03
Parent:     0b7bc84000d71f3647ca33ab1bf5bd928535c846
Author:     Ouyang Maochun <[email protected]>
AuthorDate: Mon Feb 18 09:54:52 2013 -0600
Committer:  Steve French <sfrench-r/[email protected]>
CommitDate: Thu Feb 28 09:01:47 2013 -0600

cifs: bugfix for unreclaimed writeback pages in cifs_writev_requeue()

Pages get the PG_writeback flag set before cifs sends its request to SMB server in cifs_writepages(), if the SMB service goes down, cifs may try to recommit the writing requests in cifs_writev_requeue(). However, it does not clean its PG_writeback flag and relaimed the pages even if it fails again in cifs_writev_requeue(), which may lead to the hanging of the processes accessing the cifs directory. This patch just cleans the PG_writeback flags and reclaims the pages under that circumstances.

Steps to reproduce the bug(trying serveral times may trigger the issue):
1.Write from cifs client continuously.(e.g dd if=/dev/zero of=<cifs file>) 2.Stop SMB service from server.(e.g service smb stop)
3.Wait for two minutes, and then start SMB service from
server.(e.g service smb start)
4.The processes which are accessing cifs directory may hang up.

---
fs/cifs/cifssmb.c | 5 ++++-

1 files changed, 4 insertions(+), 1 deletions(-)
fs/cifs/cifssmb.c +4 -1
index 00e12f2..7353bc5 100644
@@ -1909,8 +1909,11 @@ cifs_writev_requeue(struct cifs_writedata *wdata)
 	} while (rc == -EAGAIN);
 
 	for (i = 0; i < wdata->nr_pages; i++) {
-		if (rc != 0)
+		if (rc != 0) {
 			SetPageError(wdata->pages[i]);
+			end_page_writeback(wdata->pages[i]);
+			page_cache_release(wdata->pages[i]);
+		}
 		unlock_page(wdata->pages[i]);
 	}
 
Signature · 3 lines
Anton Altaparmakov <aia21 at cam.ac.uk> (replace at with @)
Unix Support, Computing Service, University of Cambridge, CB2 3QH, UK
Linux NTFS maintainer, http://www.linux-ntfs.org/
#2 lore raw
Quoted 56 lines · On Mon, 4 Mar 2013 15:04:49 +0000 Anton Altaparmakov…

Hi,

The below commit that is present in 3.9-rc1 is buggy. It releases the page at which point it may no longer exist and then it unlocks it afterwards. Even if you are somehow getting away with it I think it is an explosion/memory corruption waiting to happen...

Best regards,

Anton

Quoted 46 lines · Linux Kernel Mailing List
Gitweb:     http://git.kernel.org/linus/;a=commit;h=c51bb0ea40ca038da26b1fa7d450f4078124af03
Commit:     c51bb0ea40ca038da26b1fa7d450f4078124af03
Parent:     0b7bc84000d71f3647ca33ab1bf5bd928535c846
Author:     Ouyang Maochun <[email protected]>
AuthorDate: Mon Feb 18 09:54:52 2013 -0600
Committer:  Steve French <sfrench-r/[email protected]>
CommitDate: Thu Feb 28 09:01:47 2013 -0600

cifs: bugfix for unreclaimed writeback pages in cifs_writev_requeue()

Pages get the PG_writeback flag set before cifs sends its request to SMB server in cifs_writepages(), if the SMB service goes down, cifs may try to recommit the writing requests in cifs_writev_requeue(). However, it does not clean its PG_writeback flag and relaimed the pages even if it fails again in cifs_writev_requeue(), which may lead to the hanging of the processes accessing the cifs directory. This patch just cleans the PG_writeback flags and reclaims the pages under that circumstances.

Steps to reproduce the bug(trying serveral times may trigger the issue):
1.Write from cifs client continuously.(e.g dd if=/dev/zero of=<cifs file>) 2.Stop SMB service from server.(e.g service smb stop)
3.Wait for two minutes, and then start SMB service from
server.(e.g service smb start)
4.The processes which are accessing cifs directory may hang up.

---
fs/cifs/cifssmb.c | 5 ++++-

1 files changed, 4 insertions(+), 1 deletions(-)
fs/cifs/cifssmb.c +0 -0
index 00e12f2..7353bc5 100644
@@ -1909,8 +1909,11 @@ cifs_writev_requeue(struct cifs_writedata *wdata)
 	} while (rc == -EAGAIN);
 
Quoted 11 lines

fs/cifs/cifssmb.c cifs_writev_requeue(struct cifs_writedata *wdata) · line 1919

Quoted 10 lines
fs/cifs/cifssmb.c +4 -1
 	for (i = 0; i < wdata->nr_pages; i++) {
-		if (rc != 0)
+		if (rc != 0) {
 			SetPageError(wdata->pages[i]);
+			end_page_writeback(wdata->pages[i]);
+			page_cache_release(wdata->pages[i]);
+		}
 		unlock_page(wdata->pages[i]);
 	}
 

Well spotted...

We definitely should be unlocking the page before releasing it. I think it's sufficient to simply move the unlock call before the check of "rc". I'll send out a patch to do just that once I've smoke-tested it.

Thanks,

Signature · 1 line
Jeff Layton <[email protected]>