Skip to contentSkip to conversation

e1000e disabling already-disabled device

DISCUSSION Dave Jones 3 participants 3 messages Mar 3, 2013 – Mar 5, 2013

Subsystems (3)
Networking Network drivers Intel Ethernet
lore
Share & tools
lore

Dave Jones

author
#0 lore raw

Saw this when I suspended my laptop.

 ------------[ cut here ]------------
 WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x90/0xa0()
 Hardware name: 2356JK8
 Device e1000e
disabling already-disabled device
Modules linked in:
 dm_crypt arc4 iwldvm mac80211 ipv6 iTCO_wdt xfs iTCO_vendor_support libcrc32c coretemp kvm_intel kvm crc32c_intel ghash_clmulni_intel microcode snd_hda_codec_hdmi snd_hda_codec_realtek btusb bluetooth iwlwifi pcspkr snd_hda_intel cfg80211 snd_hda_codec snd_pcm lpc_ich mfd_core e1000e snd_page_alloc ptp pps_core thinkpad_acpi hwmon led_class rfkill wmi nfsd auth_rpcgss nfs_acl lockd sunrpc i915 i2c_algo_bit drm_kms_helper drm i2c_core video
Pid: 19776, comm: kworker/u:11 Not tainted 3.8.0+ #6
Call Trace:
 [<ffffffff81049855>] warn_slowpath_common+0x75/0xa0
 [<ffffffff81049936>] warn_slowpath_fmt+0x46/0x50
 [<ffffffff81359760>] pci_disable_device+0x90/0xa0
 [<ffffffffa0251092>] __e1000_shutdown+0x262/0x8a0 [e1000e]
 [<ffffffffa0251743>] e1000_suspend+0x23/0x50 [e1000e]
 [<ffffffff816284b9>] ? sub_preempt_count+0x79/0xd0
 [<ffffffff8135bd97>] pci_pm_suspend+0x77/0x140
 [<ffffffff8135bd20>] ? pci_pm_poweroff+0xf0/0xf0
 [<ffffffff8140c678>] dpm_run_callback+0x58/0x90
 [<ffffffff8140c79d>] __device_suspend+0xed/0x280
 [<ffffffff8140d1ef>] async_suspend+0x1f/0xa0
 [<ffffffff8107e3a6>] async_run_entry_fn+0x46/0x140
 [<ffffffff8106de9b>] process_one_work+0x20b/0x6b0
 [<ffffffff8106de2f>] ? process_one_work+0x19f/0x6b0
 [<ffffffff8106e720>] worker_thread+0x110/0x380
 [<ffffffff8106e610>] ? rescuer_thread+0x290/0x290
 [<ffffffff8107566d>] kthread+0xed/0x100
 [<ffffffff81075580>] ? kthread_create_on_node+0x160/0x160
 [<ffffffff8162caac>] ret_from_fork+0x7c/0xb0
 [<ffffffff81075580>] ? kthread_create_on_node+0x160/0x160
---[ end trace afe8ab959e3ef1ea ]---
#1 lore raw

Dave Jones <[email protected]> :
[...]

Quoted 12 lines
 ------------[ cut here ]------------
 WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x90/0xa0()
 Hardware name: 2356JK8
 Device e1000e
disabling already-disabled device
Modules linked in:
 dm_crypt arc4 iwldvm mac80211 ipv6 iTCO_wdt xfs iTCO_vendor_support libcrc32c coretemp kvm_intel kvm crc32c_intel ghash_clmulni_intel microcode snd_hda_codec_hdmi snd_hda_codec_realtek btusb bluetooth iwlwifi pcspkr snd_hda_intel cfg80211 snd_hda_codec snd_pcm lpc_ich mfd_core e1000e snd_page_alloc ptp pps_core thinkpad_acpi hwmon led_class rfkill wmi nfsd auth_rpcgss nfs_acl lockd sunrpc i915 i2c_algo_bit drm_kms_helper drm i2c_core video
Pid: 19776, comm: kworker/u:11 Not tainted 3.8.0+ #6
Call Trace:
 [<ffffffff81049855>] warn_slowpath_common+0x75/0xa0
 [<ffffffff81049936>] warn_slowpath_fmt+0x46/0x50
 [<ffffffff81359760>] pci_disable_device+0x90/0xa0
Quoted 8 lines
 [<ffffffffa0251092>] __e1000_shutdown+0x262/0x8a0 [e1000e]
 [<ffffffffa0251743>] e1000_suspend+0x23/0x50 [e1000e]
 [<ffffffff816284b9>] ? sub_preempt_count+0x79/0xd0
 [<ffffffff8135bd97>] pci_pm_suspend+0x77/0x140
 [<ffffffff8135bd20>] ? pci_pm_poweroff+0xf0/0xf0
 [<ffffffff8140c678>] dpm_run_callback+0x58/0x90
 [<ffffffff8140c79d>] __device_suspend+0xed/0x280
 [<ffffffff8140d1ef>] async_suspend+0x1f/0xa0

Could it be that runtime power management is also enabled, you have no link and thus end running both runtime_suspend and suspend at different times ?

I wonder why the driver disables the PCI device here btw.

drivers/net/ethernet/intel/e1000e/netdev.c +0 -2
index a177b8b..5c643c6 100644
@@ -5986,8 +5986,6 @@ static int __e1000_shutdown(struct pci_dev *pdev, bool *enable_wake,
 	 */
 	e1000e_release_hw_control(adapter);
 
-	pci_disable_device(pdev);
-
 	return 0;
 }

---
Ueimor

#2 lore raw
Quoted 58 lines

-----Original Message-----
From: Francois Romieu [mailto:[email protected]]
Sent: Sunday, March 03, 2013 3:36 PM
To: Dave Jones
Cc: [email protected]; Allan, Bruce W
Subject: Re: e1000e disabling already-disabled device

Dave Jones <[email protected]> :
[...]

Quoted 7 lines
 ------------[ cut here ]------------
 WARNING: at drivers/pci/pci.c:1397 pci_disable_device+0x90/0xa0()
 Hardware name: 2356JK8
 Device e1000e
disabling already-disabled device
Modules linked in:
 dm_crypt arc4 iwldvm mac80211 ipv6 iTCO_wdt xfs iTCO_vendor_support

libcrc32c coretemp kvm_intel kvm crc32c_intel ghash_clmulni_intel microcode snd_hda_codec_hdmi snd_hda_codec_realtek btusb bluetooth iwlwifi pcspkr snd_hda_intel cfg80211 snd_hda_codec snd_pcm lpc_ich mfd_core e1000e snd_page_alloc ptp pps_core thinkpad_acpi hwmon led_class rfkill wmi nfsd auth_rpcgss nfs_acl lockd sunrpc i915 i2c_algo_bit drm_kms_helper drm i2c_core video

Quoted 13 lines

Pid: 19776, comm: kworker/u:11 Not tainted 3.8.0+ #6

Call Trace:
 [<ffffffff81049855>] warn_slowpath_common+0x75/0xa0
 [<ffffffff81049936>] warn_slowpath_fmt+0x46/0x50
 [<ffffffff81359760>] pci_disable_device+0x90/0xa0
 [<ffffffffa0251092>] __e1000_shutdown+0x262/0x8a0 [e1000e]
 [<ffffffffa0251743>] e1000_suspend+0x23/0x50 [e1000e]
 [<ffffffff816284b9>] ? sub_preempt_count+0x79/0xd0
 [<ffffffff8135bd97>] pci_pm_suspend+0x77/0x140
 [<ffffffff8135bd20>] ? pci_pm_poweroff+0xf0/0xf0
 [<ffffffff8140c678>] dpm_run_callback+0x58/0x90
 [<ffffffff8140c79d>] __device_suspend+0xed/0x280
 [<ffffffff8140d1ef>] async_suspend+0x1f/0xa0

Could it be that runtime power management is also enabled, you have no link and thus end running both runtime_suspend and suspend at different times ?

I wonder why the driver disables the PCI device here btw.

drivers/net/ethernet/intel/e1000e/netdev.c +0 -3
index a177b8b..5c643c6 100644
@@ -5986,8 +5986,6 @@ static int __e1000_shutdown(struct pci_dev
 *pdev, bool *enable_wake,
 	 */
 	e1000e_release_hw_control(adapter);
 
-	pci_disable_device(pdev);
-
 	return 0;
 }
 
---
Quoted 1 line

Ueimor

This is a known issue and a patch from Konstantin Khlebnikov <[email protected]> is currently under test.

Thanks,
Bruce.