Skip to contentSkip to conversation

Missing gst-plugins-good package Was: [oe-commits] Richard Purdie : recipes: Fix ALLOW_EMPTY with no package specified

PATCH New Martin Jansa 1 participant 3 messages Mar 6, 2013 1 message not in the archive

lore
Share & tools
lore
#1 lore raw
In reply to a message not in the archive
Quoted 19 lines · On Tue, Mar 05, 2013 at 01:14:17PM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: fe81bd4f600877e63433184cfc2e22c33bb77db6
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=fe81bd4f600877e63433184cfc2e22c33bb77db6
Author: Richard Purdie <[email protected]>
Date:   Sun Mar  3 15:54:29 2013 +0000

recipes: Fix ALLOW_EMPTY with no package specified

There are various usages of ALLOW_EMPTY with no packages specified. This is not recommended syntax, nor is it likely to be supported in the future. This patch improves the references in OE-Core, either removing them if they're pointless (e.g. when PACKAGES="") or specifying which package it applies to.

meta/recipes-multimedia/gstreamer/gst-plugins-package.inc python populate_packages_prepend () { · line 28

Quoted 7 lines
meta/recipes-multimedia/gstreamer/gst-plugins-package.inc +0 -2
@@ -24,8 +24,6 @@ python populate_packages_prepend () {
     d.setVar('DESCRIPTION_' + metapkg, pn + ' meta package')
 }
 
-ALLOW_EMPTY = "1"
-
 PACKAGES += "${PN}-apps ${PN}-meta ${PN}-glib"
 FILES_${PN}-apps = "${bindir}"

This change is correct ('ALLOW_EMPTY_' + metapkg is set few lines above).

Just wanted to warn others that I've found few examples in other layers which were RDEPENDing also on ${PN} not metapkg and after this cleanup some packages were failing to install in rootfs.

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#2 lore raw
Quoted 30 lines · Martin Jansa
Quoted 19 lines · On Tue, Mar 05, 2013 at 01:14:17PM +0000, [email protected] wrote:
Module: openembedded-core.git
Branch: master
Commit: fe81bd4f600877e63433184cfc2e22c33bb77db6
URL:    http://git.openembedded.org/?p=openembedded-core.git&a=commit;h=fe81bd4f600877e63433184cfc2e22c33bb77db6
Author: Richard Purdie <[email protected]>
Date:   Sun Mar  3 15:54:29 2013 +0000

recipes: Fix ALLOW_EMPTY with no package specified

There are various usages of ALLOW_EMPTY with no packages specified. This is not recommended syntax, nor is it likely to be supported in the future. This patch improves the references in OE-Core, either removing them if they're pointless (e.g. when PACKAGES="") or specifying which package it applies to.

meta/recipes-multimedia/gstreamer/gst-plugins-package.inc python populate_packages_prepend () { · line 28

Quoted 7 lines
meta/recipes-multimedia/gstreamer/gst-plugins-package.inc +0 -2
@@ -24,8 +24,6 @@ python populate_packages_prepend () {
     d.setVar('DESCRIPTION_' + metapkg, pn + ' meta package')
 }
 
-ALLOW_EMPTY = "1"
-
 PACKAGES += "${PN}-apps ${PN}-meta ${PN}-glib"
 FILES_${PN}-apps = "${bindir}"

This change is correct ('ALLOW_EMPTY_' + metapkg is set few lines above).

Quoted 3 lines

Just wanted to warn others that I've found few examples in other layers which were RDEPENDing also on ${PN} not metapkg and after this cleanup some packages were failing to install in rootfs.

I take this back
even gst-plugins-good-meta is RDEPENDing on gst-plugins-good so ALLOW_EMPTY_${PN} = "1" should be also set.

The problem is not in gst-plugins-bad, because this one includes few /usr/lib/libgst*.so files (while only /usr/lib/gstreamer-0.10 are splitted).

Signature · 1 line
Martin 'JaMa' Jansa     jabber: [email protected]
#3 lore raw

PATCH 1/1 gst-plugins-package: return few ALLOW_EMPTY settings

---
 meta/recipes-multimedia/gstreamer/gst-plugins-package.inc | 7 +++++++
 1 file changed, 7 insertions(+)
meta/recipes-multimedia/gstreamer/gst-plugins-package.inc +7 -0
index 3e9ef92..7ae3ef6 100644
@@ -24,6 +24,13 @@ python populate_packages_prepend () {
     d.setVar('DESCRIPTION_' + metapkg, pn + ' meta package')
 }
 
+# metapkg has runtime dependency on PN
+# each plugin depends on PN, plugin-dev on PN-dev and plugin-staticdev on PN-staticdev
+# so we need them even when empty (like in gst-plugins-good case)
+ALLOW_EMPTY_${PN} = "1"
+ALLOW_EMPTY_${PN}-dev = "1"
+ALLOW_EMPTY_${PN}-staticdev = "1"
+
 PACKAGES += "${PN}-apps ${PN}-meta ${PN}-glib"
 FILES_${PN}-apps = "${bindir}"
 
Signature · 1 line
1.8.1.5