drm/i915: use do_div() as needed in debugfs code
Subsystems (2)
PATCH 1/1 drm/i915: use do_div() as needed in debugfs code
This replaces the open-coded divisions in the debugfs code by calls to do_div().
Signed-off-by Kees Cook <[email protected]>
Cc Daniel Vetter <[email protected]>
--- drivers/gpu/drm/i915/i915_debugfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_debugfs.c +6 -6
@@ -1814,9 +1814,9 @@ i915_max_freq_set(void *data, u64 val)/* * Turbo will still be enabled, but won't go above the set value. */ - dev_priv->rps.max_delay = val /GT_FREQUENCY_MULTIPLIER ; - -gen6_set_rps (dev, val /GT_FREQUENCY_MULTIPLIER ); +do_div (val,GT_FREQUENCY_MULTIPLIER ); + dev_priv->rps.max_delay = val; +gen6_set_rps (dev, val);mutex_unlock (&dev_priv->rps.hw_lock);return 0 ;
@@ -1865,9 +1865,9 @@ i915_min_freq_set(void *data, u64 val)/* * Turbo will still be enabled, but won't go below the set value. */ - dev_priv->rps.min_delay = val /GT_FREQUENCY_MULTIPLIER ; - -gen6_set_rps (dev, val /GT_FREQUENCY_MULTIPLIER ); +do_div (val,GT_FREQUENCY_MULTIPLIER ); + dev_priv->rps.min_delay = val; +gen6_set_rps (dev, val);mutex_unlock (&dev_priv->rps.hw_lock);return 0 ;
Signature · 6 lines
1.7.9.5 -- Kees Cook Chrome OS Security
Quoted 5 lines · Kees Cook
This replaces the open-coded divisions in the debugfs code by calls to
do_div().Signed-off-by Kees Cook <[email protected]>Cc Daniel Vetter <[email protected]>
Squashed into the debugfs patch which introduced this regression, thanks for the quick fixup.
-Daniel
Quoted 41 lines
--- drivers/gpu/drm/i915/i915_debugfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)drivers/gpu/drm/i915/i915_debugfs.c +6
-6@@ -1814,9 +1814,9 @@ i915_max_freq_set(void *data, u64 val)/* * Turbo will still be enabled, but won't go above the set value. */ - dev_priv->rps.max_delay = val /GT_FREQUENCY_MULTIPLIER ; - -gen6_set_rps (dev, val /GT_FREQUENCY_MULTIPLIER ); +do_div (val,GT_FREQUENCY_MULTIPLIER ); + dev_priv->rps.max_delay = val; +gen6_set_rps (dev, val);mutex_unlock (&dev_priv->rps.hw_lock);return 0 ;@@ -1865,9 +1865,9 @@ i915_min_freq_set(void *data, u64 val)/* * Turbo will still be enabled, but won't go below the set value. */ - dev_priv->rps.min_delay = val /GT_FREQUENCY_MULTIPLIER ; - -gen6_set_rps (dev, val /GT_FREQUENCY_MULTIPLIER ); +do_div (val,GT_FREQUENCY_MULTIPLIER ); + dev_priv->rps.min_delay = val; +gen6_set_rps (dev, val);mutex_unlock (&dev_priv->rps.hw_lock);return 0 ;Signature · 6 lines
1.7.9.5 -- Kees Cook Chrome OS Security
Signature · 3 lines
Daniel Vetter Software Engineer, Intel Corporation +41 (0) 79 365 57 48 - http://blog.ffwll.ch