Skip to contentSkip to conversation

hwmon: (lm75) Per-chip configuration register initialization

PATCH In review Jean Delvare 2 participants 2 messages Mar 12, 2013 Hardware monitoring

lore
Share & tools
lore
#0 lore raw

PATCH 2/5 hwmon: (lm75) Per-chip configuration register initialization

There is no standard for the configuration register bits of LM75-like chips. We shouldn't blindly clear bits setting the resolution as they are either unused or used for something else on some of the supported chips.

So, switch to per-chip configuration initialization. This will allow for better tuning later, for example using more resolution bits when available.

---
 drivers/hwmon/lm75.c |   24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)
drivers/hwmon/lm75.c +22 -2
@@ -167,8 +167,28 @@ lm75_probe(struct i2c_client *client, co
 	 * Then tweak to be more precise when appropriate.
 	 */
 	set_mask = 0;
-	clr_mask = (1 << 0)			/* continuous conversions */
-		| (1 << 6) | (1 << 5);		/* 9-bit mode */
+	clr_mask = LM75_SHUTDOWN;		/* continuous conversions */
+
+	switch (id->driver_data) {
+	case adt75:
+		clr_mask |= 1 << 5;		/* not one-shot mode */
+		break;
+	case ds1775:
+	case ds75:
+	case stds75:
+		clr_mask |= 3 << 5;		/* 9-bit mode */
+		break;
+	case mcp980x:
+	case tmp100:
+	case tmp101:
+	case tmp105:
+	case tmp175:
+	case tmp275:
+	case tmp75:
+		clr_mask |= 3 << 5;		/* 9-bit mode */
+		clr_mask |= 1 << 7;		/* not one-shot mode */
+		break;
+	}
 
 	/* configure as specified */
 	status = lm75_read_value(client, LM75_REG_CONF);
Signature · 6 lines
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors
maintainer Acked-by on v1 2/5
#1 lore raw
Quoted 10 lines · Jean Delvare

There is no standard for the configuration register bits of LM75-like chips. We shouldn't blindly clear bits setting the resolution as they are either unused or used for something else on some of the supported chips.

So, switch to per-chip configuration initialization. This will allow for better tuning later, for example using more resolution bits when available.

Quoted 47 lines
---
 drivers/hwmon/lm75.c |   24 ++++++++++++++++++++++--
 1 file changed, 22 insertions(+), 2 deletions(-)
drivers/hwmon/lm75.c +22 -2
@@ -167,8 +167,28 @@ lm75_probe(struct i2c_client *client, co
 	 * Then tweak to be more precise when appropriate.
 	 */
 	set_mask = 0;
-	clr_mask = (1 << 0)			/* continuous conversions */
-		| (1 << 6) | (1 << 5);		/* 9-bit mode */
+	clr_mask = LM75_SHUTDOWN;		/* continuous conversions */
+
+	switch (id->driver_data) {
+	case adt75:
+		clr_mask |= 1 << 5;		/* not one-shot mode */
+		break;
+	case ds1775:
+	case ds75:
+	case stds75:
+		clr_mask |= 3 << 5;		/* 9-bit mode */
+		break;
+	case mcp980x:
+	case tmp100:
+	case tmp101:
+	case tmp105:
+	case tmp175:
+	case tmp275:
+	case tmp75:
+		clr_mask |= 3 << 5;		/* 9-bit mode */
+		clr_mask |= 1 << 7;		/* not one-shot mode */
+		break;
+	}
 
 	/* configure as specified */
 	status = lm75_read_value(client, LM75_REG_CONF);
Signature · 7 lines
-- 
Jean Delvare

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors

_______________________________________________
lm-sensors mailing list
[email protected]
http://lists.lm-sensors.org/mailman/listinfo/lm-sensors