Skip to contentSkip to conversation

Correcting ext4write syntax

U-Boot Tom Rini 2 participants 2 messages Mar 13, 2013

lore
Share & tools
lore

Tom Rini

author
#0 lore raw

Hey all,

We have a problem with the syntax of 'ext4write'. For fatload, fatwrite, ext2load and ext4load the format is:
command interface device:part system-memory-addr filename But ext4write is:
command interface device:part filename system-memory-addr

Crap. This has been the published interface since May 2012, so 3 releases going on a fourth.

I guess we've got two options:
1) Break and correct the order.
2) Correct the order, add a silent fixup if filename and address are backwards and note we'll remove that in a few releases.

Thoughts?

Signature · 8 lines
Tom
-------------- next part --------------
A non-text attachment was scrubbed...
Name: not available
Type: application/pgp-signature
Size: 836 bytes
Desc: Digital signature
URL: <http://lists.denx.de/pipermail/u-boot/attachments/20130313/44e3c58c/attachment.pgp>
#1 lore raw

Dear Tom,

Quoted 7 lines · In message <20130313145638.GK23324@bill-the-cat> you wrote:

We have a problem with the syntax of 'ext4write'. For fatload, fatwrite, ext2load and ext4load the format is:
command interface device:part system-memory-addr filename But ext4write is:
command interface device:part filename system-memory-addr

Quoted 7 lines

Crap. This has been the published interface since May 2012, so 3 releases going on a fourth.

I guess we've got two options:
1) Break and correct the order.
2) Correct the order, add a silent fixup if filename and address are backwards and note we'll remove that in a few releases.

My vote is for 1) [accompanid by a big, fat note in the release message].

Best regards,

Wolfgang Denk

Signature · 4 lines
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Of all the things I've lost, I miss my mind the most.