ARM: shmobile: r8a73a4 APE6EVM board support V2
Subsystems (6)
Magnus Damm
maintainercover ARM: shmobile: r8a73a4 APE6EVM board support V2
ARM: shmobile: r8a73a4 APE6EVM board support V2
[PATCH 01/03] ARM: shmobile: APE6EVM base support V2 [PATCH 02/03] ARM: shmobile: APE6EVM PFC support [PATCH 03/03] ARM: shmobile: APE6EVM LAN9220 support
This series is V2 of initial support for the APE6EVM board.
The APE6EVM board makes use of the r8a73a4 SoC and has a couple of different I/O devices on board, but with this series only support for the SCIFA0 UART and the Ethernet chip is included.
In the future support for more I/O devices will be added as incremental feature patches.
Changes since V1:
- Went from single patch to series
- Use ape6evm_add_standard_devices() to setup SoC devices and clocks
- Use PFC to configure SCIFA0
- Add Ethernet support including PFC support
For more details please see the individual patches.
---
Written against "next" renesas.git 811689afc214564c4a5f238ecf4d8bdc0e52b615
Depends on the following two series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2 [PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/Makefile | 1 arch/arm/boot/dts/r8a73a4-ape6evm.dts | 47 ++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 10 +++ arch/arm/mach-shmobile/Makefile | 1 arch/arm/mach-shmobile/board-ape6evm.c | 89 ++++++++++++++++++++++++++++++++ 5 files changed, 147 insertions(+), 1 deletion(-)
Magnus Damm
maintainerPATCH 1/3 ARM: shmobile: APE6EVM base support V2
From: Magnus Damm <[email protected]>
V2 of APE6EVM base board support making use of
1 GiB of memory, the SCIFA0 serial port and
ARM architected timer.
---
Changes since V1:
- Sorted headers
- Use ape6evm_add_standard_devices() to setup SoC devices and clocks
Written against "next" renesas.git 811689afc214564c4a5f238ecf4d8bdc0e52b615
Depends on the following series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2
Does not depend on:
[PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/Makefile | 1
arch/arm/boot/dts/r8a73a4-ape6evm.dts | 26 ++++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 8 ++++- arch/arm/mach-shmobile/Makefile | 1 arch/arm/mach-shmobile/board-ape6evm.c | 46 ++++++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+), 1 deletion(-)
arch/arm/boot/dts/Makefile +1 -0
@@ -139,6 +139,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE) += emev2-kzm r8a7779-marzen-reference.dtb \ sh73a0-kzm9g.dtb \ sh73a0-kzm9g-reference.dtb \ + r8a73a4-ape6evm.dtb \ sh7372-mackerel.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_cyclone5.dtb \ socfpga_vt.dtb
arch/arm/boot/dts/r8a73a4-ape6evm.dts new file +26 -0
@@ -0,0 +1,26 @@ +/* + * Device Tree Source for the APE6EVM board + * + * Copyright (C) 2013 Renesas Solutions Corp. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +/include/ "r8a73a4.dtsi" + +/ { + model = "APE6EVM"; + compatible = "renesas,ape6evm", "renesas,r8a73a4"; + + chosen { + bootargs = "console=ttySC0,115200 ignore_loglevel"; + }; + + memory at 40000000 { + device_type = "memory"; + reg = <0x40000000 0x40000000>; + }; +};
arch/arm/mach-shmobile/Kconfig +7 -1
@@ -79,6 +79,11 @@ config MACH_AG5EVM select REGULATOR_FIXED_VOLTAGE if REGULATOR select SH_LCD_MIPI_DSI +config MACH_APE6EVM + bool "APE6EVM board" + depends on ARCH_R8A73A4 + select USE_OF + config MACH_MACKEREL bool "mackerel board" depends on ARCH_SH7372
@@ -166,7 +171,7 @@ config MEMORY_START hex "Physical memory start address" default "0x40000000" if MACH_AP4EVB || MACH_AG5EVM || \ MACH_MACKEREL || MACH_BONITO || \ - MACH_ARMADILLO800EVA + MACH_ARMADILLO800EVA || MACH_APE6EVM default "0x41000000" if MACH_KOTA2 default "0x00000000" ---help---
@@ -176,6 +181,7 @@ config MEMORY_START config MEMORY_SIZE hex "Physical memory size" + default "0x40000000" if MACH_APE6EVM default "0x20000000" if MACH_AG5EVM || MACH_BONITO || \ MACH_ARMADILLO800EVA default "0x1e000000" if MACH_KOTA2
arch/arm/mach-shmobile/Makefile +1 -0
@@ -35,6 +35,7 @@ obj-$(CONFIG_ARCH_SH73A0) += pm-sh73a0.o # Board objects obj-$(CONFIG_MACH_AP4EVB) += board-ap4evb.o obj-$(CONFIG_MACH_AG5EVM) += board-ag5evm.o +obj-$(CONFIG_MACH_APE6EVM) += board-ape6evm.o obj-$(CONFIG_MACH_MACKEREL) += board-mackerel.o obj-$(CONFIG_MACH_KOTA2) += board-kota2.o obj-$(CONFIG_MACH_BONITO) += board-bonito.o
arch/arm/mach-shmobile/board-ape6evm.c new file +46 -0
46 lines not on this page · raw message
Magnus Damm
maintainerPATCH 2/3 ARM: shmobile: APE6EVM PFC support
In reply to Magnus DammFrom: Magnus Damm <[email protected]>
Start using the r8a73a4 PFC on the APE6EVM board
and configure the SCIFA0 console signals using
the PFC.
---
Written against "next" renesas.git 811689afc214564c4a5f238ecf4d8bdc0e52b615
Depends on the following two series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2 [PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/mach-shmobile/Kconfig | 1 + arch/arm/mach-shmobile/board-ape6evm.c | 7 +++++++ 2 files changed, 8 insertions(+)
arch/arm/mach-shmobile/Kconfig +1 -0
@@ -82,6 +82,7 @@ config MACH_AG5EVM config MACH_APE6EVM bool "APE6EVM board" depends on ARCH_R8A73A4 + select ARCH_REQUIRE_GPIOLIB select USE_OF config MACH_MACKEREL
arch/arm/mach-shmobile/board-ape6evm.c +7 -0
@@ -18,6 +18,7 @@* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA */ +#include <linux/gpio.h> #include <linux/interrupt.h> #include <linux/irqchip.h> #include <linux/kernel.h>
@@ -30,6 +31,12 @@static void __init ape6evm_add_standard_devices (void ) {r8a73a4_clock_init (); +r8a73a4_pinmux_init (); + +/* SCIFA0 console */ +gpio_request (GPIO_FN_SCIFA0_TXD ,NULL ); +gpio_request (GPIO_FN_SCIFA0_RXD ,NULL ); +r8a73a4_add_standard_devices (); }
Magnus Damm
maintainerPATCH 3/3 ARM: shmobile: APE6EVM LAN9220 support
In reply to Magnus DammFrom: Magnus Damm <[email protected]>
Add LAN9220 support to the APE6EVM board using C and DT. At this point the PFC lacks DT bindings so to configure the pinmux we need to use C.
---
Written against "next" renesas.git 811689afc214564c4a5f238ecf4d8bdc0e52b615
Depends on the following two series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2 [PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/r8a73a4-ape6evm.dts | 21 ++++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 1 arch/arm/mach-shmobile/board-ape6evm.c | 36 ++++++++++++++++++++++++++++++++ 3 files changed, 58 insertions(+)
arch/arm/boot/dts/r8a73a4-ape6evm.dts +21 -0
@@ -23,4 +23,25 @@ device_type = "memory"; reg = <0x40000000 0x40000000>; }; + + ape6evm_fixed_3v3: fixedregulator at 0 { + compatible = "regulator-fixed"; + regulator-name = "3V3"; + regulator-min-microvolt = <3300000>; + regulator-max-microvolt = <3300000>; + regulator-always-on; + }; + + ethernet at 8000000 { + compatible = "smsc,lan9118", "smsc,lan9115"; + reg = <0x08000000 0x1000>; + interrupt-parent = <&irqc1>; + interrupts = <8 0x4>; + phy-mode = "mii"; + reg-io-width = <4>; + smsc,irq-active-high; + smsc,irq-push-pull; + vdd33a-supply = <&ape6evm_fixed_3v3>; + vddvario-supply = <&ape6evm_fixed_3v3>; + }; };
arch/arm/mach-shmobile/Kconfig +1 -0
@@ -83,6 +83,7 @@ config MACH_APE6EVM bool "APE6EVM board" depends on ARCH_R8A73A4 select ARCH_REQUIRE_GPIOLIB + select REGULATOR_FIXED_VOLTAGE if REGULATOR select USE_OF config MACH_MACKEREL
arch/arm/mach-shmobile/board-ape6evm.c +36 -0
@@ -23,11 +23,36 @@#include <linux/irqchip.h> #include <linux/kernel.h> #include <linux/platform_device.h> +#include <linux/regulator/fixed.h> +#include <linux/regulator/machine.h> +#include <linux/smsc911x.h> #include <mach/common.h> +#include <mach/irqs.h> #include <mach/r8a73a4.h> #include <asm/mach-types.h> #include <asm/mach/arch.h> +/* Dummy supplies, where voltage doesn't matter */ +static struct regulator_consumer_supply dummy_supplies[] = { +REGULATOR_SUPPLY ("vddvario" ,"smsc911x" ), +REGULATOR_SUPPLY ("vdd33a" ,"smsc911x" ), +}; + +/* SMSC LAN9220 */ +static const struct resource lan9220_res[] = { +DEFINE_RES_MEM (0x08000000 ,0x1000 ), + { + .start =irq_pin (40 ),/* IRQ40 */ + .flags =IORESOURCE_IRQ |IRQF_TRIGGER_HIGH , + }, +}; + +static const struct smsc911x_platform_config lan9220_data = { + .flags =SMSC911X_USE_32BIT , + .irq_type =SMSC911X_IRQ_TYPE_PUSH_PULL , + .irq_polarity =SMSC911X_IRQ_POLARITY_ACTIVE_HIGH , +}; +static void __init ape6evm_add_standard_devices (void ) {r8a73a4_clock_init ();
@@ -38,6 +63,17 @@ static void __init ape6evm_add_standard_gpio_request (GPIO_FN_SCIFA0_RXD ,NULL );r8a73a4_add_standard_devices (); + +/* LAN9220 ethernet */ +gpio_request (GPIO_FN_IRQ40 ,NULL );/* smsc9220 IRQ */ +gpio_request (GPIO_PORT270 ,NULL );/* smsc9220 RESET */ +gpio_direction_output (GPIO_PORT270 ,1 ); + +regulator_register_fixed (0 , dummy_supplies,ARRAY_SIZE (dummy_supplies)); + +platform_device_register_resndata (&platform_bus,"smsc911x" ,-1 , + lan9220_res,ARRAY_SIZE (lan9220_res), + &lan9220_data,sizeof (lan9220_data)); }static const char *ape6evm_boards_compat_dt[]__initdata = {
PATCH 1/3 ARM: shmobile: APE6EVM base support V2
In reply to Magnus DammQuoted 50 lines · Magnus Damm
From: Magnus Damm <[email protected]>
V2 of APE6EVM base board support making use of
1 GiB of memory, the SCIFA0 serial port and
ARM architected timer.Signed-off-by Magnus Damm <[email protected]>---
Changes since V1:
- Sorted headers
- Useape6evm_add_standard_devices()to setup SoC devices and clocksWritten against "next" renesas.git
811689afc214564c4a5f238ecf4d8bdc0e52b615Depends on the following series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2Does not depend on:
[PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/Makefile| 1arch/arm/boot/dts/r8a73a4-ape6evm.dts | 26 ++++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 8 ++++- arch/arm/mach-shmobile/Makefile | 1 arch/arm/mach-shmobile/board-ape6evm.c | 46 ++++++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+), 1 deletion(-)arch/arm/boot/dts/Makefile +1
-0@@ -139,6 +139,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE) += emev2-kzm r8a7779-marzen-reference.dtb \ sh73a0-kzm9g.dtb \ sh73a0-kzm9g-reference.dtb \ + r8a73a4-ape6evm.dtb \ sh7372-mackerel.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_cyclone5.dtb \ socfpga_vt.dtbarch/arm/boot/dts/r8a73a4-ape6evm.dts new file +9
-0@@ -0,0 +1,26 @@ +/* + * Device Tree Source for the APE6EVM board + * + * Copyright (C) 2013 Renesas Solutions Corp. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */
arch/arm/boot/dts/r8a73a4-ape6evm.dts line 19
Quoted 10 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts new file +10
-0+ +/dts-v1/; +/include/ "r8a73a4.dtsi" + +/ { + model = "APE6EVM"; + compatible = "renesas,ape6evm", "renesas,r8a73a4"; + + chosen { + bootargs = "console=ttySC0,115200 ignore_loglevel";
I think that earlyprintk=sh-sci.0,11520 go in here.
Quoted 98 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts new file +7
-0+ }; + + memory at 40000000 { + device_type = "memory"; + reg = <0x40000000 0x40000000>; + }; +};arch/arm/mach-shmobile/Kconfig +7
-1@@ -79,6 +79,11 @@ config MACH_AG5EVM select REGULATOR_FIXED_VOLTAGE if REGULATOR select SH_LCD_MIPI_DSI +config MACH_APE6EVM + bool "APE6EVM board" + depends on ARCH_R8A73A4 + select USE_OF + config MACH_MACKEREL bool "mackerel board" depends on ARCH_SH7372@@ -166,7 +171,7 @@ config MEMORY_START hex "Physical memory start address" default "0x40000000" if MACH_AP4EVB || MACH_AG5EVM || \ MACH_MACKEREL || MACH_BONITO || \ - MACH_ARMADILLO800EVA + MACH_ARMADILLO800EVA || MACH_APE6EVM default "0x41000000" if MACH_KOTA2 default "0x00000000" ---help---@@ -176,6 +181,7 @@ config MEMORY_START config MEMORY_SIZE hex "Physical memory size" + default "0x40000000" if MACH_APE6EVM default "0x20000000" if MACH_AG5EVM || MACH_BONITO || \ MACH_ARMADILLO800EVA default "0x1e000000" if MACH_KOTA2arch/arm/mach-shmobile/Makefile +1
-0@@ -35,6 +35,7 @@ obj-$(CONFIG_ARCH_SH73A0) += pm-sh73a0.o # Board objects obj-$(CONFIG_MACH_AP4EVB) += board-ap4evb.o obj-$(CONFIG_MACH_AG5EVM) += board-ag5evm.o +obj-$(CONFIG_MACH_APE6EVM) += board-ape6evm.o obj-$(CONFIG_MACH_MACKEREL) += board-mackerel.o obj-$(CONFIG_MACH_KOTA2) += board-kota2.o obj-$(CONFIG_MACH_BONITO) += board-bonito.oarch/arm/mach-shmobile/board-ape6evm.c new file +46
-0@@ -0,0 +1,46 @@ +/* +* APE6EVM board support +* +* Copyright (C) 2013 Renesas Solutions Corp. +* Copyright (C) 2013 Magnus Damm +* +* This program is free software; you can redistribute it and/or modify +* it under the terms of the GNU General Public License as published by +* the Free Software Foundation; version 2 of the License. +* +* This program is distributed in the hope that it will be useful, +* but WITHOUT ANY WARRANTY; without even the implied warranty of +* MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE. See the +* GNU General Public License for more details. +* +* You should have received a copy of the GNU General Public License +* along with this program; if not, write to the Free Software +* Foundation, Inc., 51 Franklin St, Fifth Floor, Boston, MA 02110-1301 USA +*/ + +#include <linux/interrupt.h> +#include <linux/irqchip.h> +#include <linux/kernel.h> +#include <linux/platform_device.h> +#include <mach/common.h> +#include <mach/r8a73a4.h> +#include <asm/mach-types.h> +#include <asm/mach/arch.h> + +static void __init ape6evm_add_standard_devices (void ) +{ +r8a73a4_clock_init (); +r8a73a4_add_standard_devices (); +} + +static const char *ape6evm_boards_compat_dt[]__initdata = { +"renesas,ape6evm" , +NULL , +}; + +DT_MACHINE_START (APE6EVM_DT ,"ape6evm" ) + .init_irq = irqchip_init, + .init_time = shmobile_timer_init, + .init_machine = ape6evm_add_standard_devices, + .dt_compat = ape6evm_boards_compat_dt, +MACHINE_END
PATCH 1/3 ARM: shmobile: APE6EVM base support V2
Quoted 55 lines · Simon Horman
Quoted 54 lines · Magnus Damm
From: Magnus Damm <[email protected]>
V2 of APE6EVM base board support making use of
1 GiB of memory, the SCIFA0 serial port and
ARM architected timer.Signed-off-by Magnus Damm <[email protected]>---
Changes since V1:
- Sorted headers
- Useape6evm_add_standard_devices()to setup SoC devices and clocksWritten against "next" renesas.git
811689afc214564c4a5f238ecf4d8bdc0e52b615Depends on the following series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2Does not depend on:
[PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/Makefile| 1arch/arm/boot/dts/r8a73a4-ape6evm.dts | 26 ++++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 8 ++++- arch/arm/mach-shmobile/Makefile | 1 arch/arm/mach-shmobile/board-ape6evm.c | 46 ++++++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+), 1 deletion(-)arch/arm/boot/dts/Makefile +1
-0@@ -139,6 +139,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE) += emev2-kzm r8a7779-marzen-reference.dtb \ sh73a0-kzm9g.dtb \ sh73a0-kzm9g-reference.dtb \ + r8a73a4-ape6evm.dtb \ sh7372-mackerel.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_cyclone5.dtb \ socfpga_vt.dtbarch/arm/boot/dts/r8a73a4-ape6evm.dts new file +13
-0@@ -0,0 +1,26 @@ +/* + * Device Tree Source for the APE6EVM board + * + * Copyright (C) 2013 Renesas Solutions Corp. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +/include/ "r8a73a4.dtsi" +
Quoted 8 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts line 19
Quoted 6 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts new file +6
-0+/ { + model = "APE6EVM"; + compatible = "renesas,ape6evm", "renesas,r8a73a4"; + + chosen { + bootargs = "console=ttySC0,115200 ignore_loglevel";I think that earlyprintk=sh-sci.0,11520 go in here.
Also, to be consistent with the dts of other shmobile boards could you add root=/dev/nfs ip=dhcp. This history behind this is that many boards defaulted to using nfsroot in their defconfigs, a reasonable default IMHO, and recently the command line for all boards that boot using DT was moved from their defconfig to their .dtsi in preparation for defconfig consolidation.
[snip]
Magnus Damm
maintainerPATCH 1/3 ARM: shmobile: APE6EVM base support V2
In reply to Simon HormanQuoted 55 lines · Simon Horman
Quoted 54 lines · Magnus Damm
From: Magnus Damm <[email protected]>
V2 of APE6EVM base board support making use of
1 GiB of memory, the SCIFA0 serial port and
ARM architected timer.Signed-off-by Magnus Damm <[email protected]>---
Changes since V1:
- Sorted headers
- Useape6evm_add_standard_devices()to setup SoC devices and clocksWritten against "next" renesas.git
811689afc214564c4a5f238ecf4d8bdc0e52b615Depends on the following series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2Does not depend on:
[PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/Makefile| 1arch/arm/boot/dts/r8a73a4-ape6evm.dts | 26 ++++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 8 ++++- arch/arm/mach-shmobile/Makefile | 1 arch/arm/mach-shmobile/board-ape6evm.c | 46 ++++++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+), 1 deletion(-)arch/arm/boot/dts/Makefile 2013-03-18 21:44:34.000000000 +0900 renamed from arch/arm/boot/dts/Makefile +1
-0@@ -139,6 +139,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE) += emev2-kzm r8a7779-marzen-reference.dtb \ sh73a0-kzm9g.dtb \ sh73a0-kzm9g-reference.dtb \ + r8a73a4-ape6evm.dtb \ sh7372-mackerel.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_cyclone5.dtb \ socfpga_vt.dtbarch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +13
-0@@ -0,0 +1,26 @@ +/* + * Device Tree Source for the APE6EVM board + * + * Copyright (C) 2013 Renesas Solutions Corp. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +/include/ "r8a73a4.dtsi" +
Quoted 8 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 line 19
Quoted 6 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +6
-0+/ { + model = "APE6EVM"; + compatible = "renesas,ape6evm", "renesas,r8a73a4"; + + chosen { + bootargs = "console=ttySC0,115200 ignore_loglevel";I think that earlyprintk=sh-sci.0,11520 go in here.
Thanks for checking, but we're not making use of earlyprintk on r8a73a4. So adding this parameter will not make any difference, just potential confusion IMO.
On r8a73a4 the SCIF ports are added as regular device drivers at ->init_machine() timing. With this approach transition to DT in the future will be just a small step.
Thanks,
/ magnus
Magnus Damm
maintainerPATCH 1/3 ARM: shmobile: APE6EVM base support V2
In reply to Simon HormanQuoted 55 lines · Simon Horman
Quoted 45 lines · Simon Horman
Quoted 44 lines · Magnus Damm
From: Magnus Damm <[email protected]>
V2 of APE6EVM base board support making use of
1 GiB of memory, the SCIFA0 serial port and
ARM architected timer.Signed-off-by Magnus Damm <[email protected]>---
Changes since V1:
- Sorted headers
- Useape6evm_add_standard_devices()to setup SoC devices and clocksWritten against "next" renesas.git
811689afc214564c4a5f238ecf4d8bdc0e52b615Depends on the following series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2Does not depend on:
[PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/Makefile| 1arch/arm/boot/dts/r8a73a4-ape6evm.dts | 26 ++++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 8 ++++- arch/arm/mach-shmobile/Makefile | 1 arch/arm/mach-shmobile/board-ape6evm.c | 46 ++++++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+), 1 deletion(-)arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +13
-0@@ -0,0 +1,26 @@ +/* + * Device Tree Source for the APE6EVM board + * + * Copyright (C) 2013 Renesas Solutions Corp. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +/include/ "r8a73a4.dtsi" +Quoted 8 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 line 19
Quoted 6 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +6
-0+/ { + model = "APE6EVM"; + compatible = "renesas,ape6evm", "renesas,r8a73a4"; + + chosen { + bootargs = "console=ttySC0,115200 ignore_loglevel";I think that earlyprintk=sh-sci.0,11520 go in here.
Quoted 6 lines
Also, to be consistent with the dts of other shmobile boards could you add root=/dev/nfs ip=dhcp. This history behind this is that many boards defaulted to using nfsroot in their defconfigs, a reasonable default IMHO, and recently the command line for all boards that boot using DT was moved from their defconfig to their .dtsi in preparation for defconfig consolidation.
Sounds like a good idea. Network is however not existing until pretty late in the series. How about adding it in that patch that includes SMSC ethernet support?
Thanks,
/ magnus
PATCH 1/3 ARM: shmobile: APE6EVM base support V2
In reply to Magnus DammHi Magnus,
Quoted 65 lines · Magnus Damm
Quoted 55 lines · Simon Horman
Quoted 54 lines · Magnus Damm
From: Magnus Damm <[email protected]>
V2 of APE6EVM base board support making use of
1 GiB of memory, the SCIFA0 serial port and
ARM architected timer.Signed-off-by Magnus Damm <[email protected]>---
Changes since V1:
- Sorted headers
- Useape6evm_add_standard_devices()to setup SoC devices and clocksWritten against "next" renesas.git
811689afc214564c4a5f238ecf4d8bdc0e52b615Depends on the following series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2Does not depend on:
[PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/Makefile| 1arch/arm/boot/dts/r8a73a4-ape6evm.dts | 26 ++++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 8 ++++- arch/arm/mach-shmobile/Makefile | 1 arch/arm/mach-shmobile/board-ape6evm.c | 46 ++++++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+), 1 deletion(-)arch/arm/boot/dts/Makefile 2013-03-18 21:44:34.000000000 +0900 renamed from arch/arm/boot/dts/Makefile +1
-0@@ -139,6 +139,7 @@ dtb-$(CONFIG_ARCH_SHMOBILE) += emev2-kzm r8a7779-marzen-reference.dtb \ sh73a0-kzm9g.dtb \ sh73a0-kzm9g-reference.dtb \ + r8a73a4-ape6evm.dtb \ sh7372-mackerel.dtb dtb-$(CONFIG_ARCH_SOCFPGA) += socfpga_cyclone5.dtb \ socfpga_vt.dtbarch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +13
-0@@ -0,0 +1,26 @@ +/* + * Device Tree Source for the APE6EVM board + * + * Copyright (C) 2013 Renesas Solutions Corp. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +/include/ "r8a73a4.dtsi" +Quoted 8 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 line 19
Quoted 6 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +6
-0+/ { + model = "APE6EVM"; + compatible = "renesas,ape6evm", "renesas,r8a73a4"; + + chosen { + bootargs = "console=ttySC0,115200 ignore_loglevel";I think that earlyprintk=sh-sci.0,11520 go in here.
Quoted 7 lines
Thanks for checking, but we're not making use of earlyprintk on r8a73a4. So adding this parameter will not make any difference, just potential confusion IMO.
On r8a73a4 the SCIF ports are added as regular device drivers at ->init_machine() timing. With this approach transition to DT in the future will be just a small step.
Thanks for the clarification.
PATCH 1/3 ARM: shmobile: APE6EVM base support V2
In reply to Magnus DammQuoted 63 lines · Magnus Damm
Quoted 55 lines · Simon Horman
Quoted 45 lines · Simon Horman
Quoted 44 lines · Magnus Damm
From: Magnus Damm <[email protected]>
V2 of APE6EVM base board support making use of
1 GiB of memory, the SCIFA0 serial port and
ARM architected timer.Signed-off-by Magnus Damm <[email protected]>---
Changes since V1:
- Sorted headers
- Useape6evm_add_standard_devices()to setup SoC devices and clocksWritten against "next" renesas.git
811689afc214564c4a5f238ecf4d8bdc0e52b615Depends on the following series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2Does not depend on:
[PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/Makefile| 1arch/arm/boot/dts/r8a73a4-ape6evm.dts | 26 ++++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 8 ++++- arch/arm/mach-shmobile/Makefile | 1 arch/arm/mach-shmobile/board-ape6evm.c | 46 ++++++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+), 1 deletion(-)arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +13
-0@@ -0,0 +1,26 @@ +/* + * Device Tree Source for the APE6EVM board + * + * Copyright (C) 2013 Renesas Solutions Corp. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +/include/ "r8a73a4.dtsi" +Quoted 8 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 line 19
Quoted 6 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +6
-0+/ { + model = "APE6EVM"; + compatible = "renesas,ape6evm", "renesas,r8a73a4"; + + chosen { + bootargs = "console=ttySC0,115200 ignore_loglevel";I think that earlyprintk=sh-sci.0,11520 go in here.
Quoted 6 lines
Also, to be consistent with the dts of other shmobile boards could you add root=/dev/nfs ip=dhcp. This history behind this is that many boards defaulted to using nfsroot in their defconfigs, a reasonable default IMHO, and recently the command line for all boards that boot using DT was moved from their defconfig to their .dtsi in preparation for defconfig consolidation.
Quoted 3 lines
Sounds like a good idea. Network is however not existing until pretty late in the series. How about adding it in that patch that includes SMSC ethernet support?
Yes, that sounds reasonable to me.
Magnus Damm
maintainerPATCH 1/3 ARM: shmobile: APE6EVM base support V2
Quoted 64 lines · Simon Horman
Quoted 63 lines · Magnus Damm
Quoted 61 lines · Simon Horman
Quoted 45 lines · Simon Horman
Quoted 44 lines · Magnus Damm
From: Magnus Damm <[email protected]>
V2 of APE6EVM base board support making use of
1 GiB of memory, the SCIFA0 serial port and
ARM architected timer.Signed-off-by Magnus Damm <[email protected]>---
Changes since V1:
- Sorted headers
- Useape6evm_add_standard_devices()to setup SoC devices and clocksWritten against "next" renesas.git
811689afc214564c4a5f238ecf4d8bdc0e52b615Depends on the following series:
[PATCH 00/04] ARM: shmobile: r8a73a4 SoC support V2Does not depend on:
[PATCH 00/02] sh-pfc: Initial r8a73a4 PFC support
arch/arm/boot/dts/Makefile| 1arch/arm/boot/dts/r8a73a4-ape6evm.dts | 26 ++++++++++++++++++ arch/arm/mach-shmobile/Kconfig | 8 ++++- arch/arm/mach-shmobile/Makefile | 1 arch/arm/mach-shmobile/board-ape6evm.c | 46 ++++++++++++++++++++++++++++++++ 5 files changed, 81 insertions(+), 1 deletion(-)arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +13
-0@@ -0,0 +1,26 @@ +/* + * Device Tree Source for the APE6EVM board + * + * Copyright (C) 2013 Renesas Solutions Corp. + * + * This file is licensed under the terms of the GNU General Public License + * version 2. This program is licensed "as is" without any warranty of any + * kind, whether express or implied. + */ + +/dts-v1/; +/include/ "r8a73a4.dtsi" +Quoted 8 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 line 19
Quoted 6 lines
arch/arm/boot/dts/r8a73a4-ape6evm.dts 2013-03-18 21:44:35.000000000 +0900 new file +6
-0+/ { + model = "APE6EVM"; + compatible = "renesas,ape6evm", "renesas,r8a73a4"; + + chosen { + bootargs = "console=ttySC0,115200 ignore_loglevel";I think that earlyprintk=sh-sci.0,11520 go in here.
Also, to be consistent with the dts of other shmobile boards could you add root=/dev/nfs ip=dhcp. This history behind this is that many boards defaulted to using nfsroot in their defconfigs, a reasonable default IMHO, and recently the command line for all boards that boot using DT was moved from their defconfig to their .dtsi in preparation for defconfig consolidation.
Quoted 5 lines
Quoted 3 lines
Sounds like a good idea. Network is however not existing until pretty late in the series. How about adding it in that patch that includes SMSC ethernet support?
Yes, that sounds reasonable to me.
Thanks. I will include that change in V3 together with a bug fix for the SCIF ports. Also, if there is any suggestion about the the split of platform device vs DT then I can also rework that portion of the code. And yes, will need to update the PFC with PINCTRL support too.
Cheers,
/ magnus