add_taint() change left s390 alone
Hi Rusty,
your commit "taint: add explicit flag to show whether lock dep is still OK." missed to change the s390 invocation of add_taint():
CC arch/s390/kernel/dumpstack.oarch/s390/kernel/dumpstack.c: In function ‘die’:arch/s390/kernel/dumpstack.c:228:2: error: too few arguments to function ‘add_taint’
Could be that this is a merge issue since dumpstack.c is a new file which contains stuff that was formerly in arch/s390/kernel/traps.c
Hi Heilo,
Quoted 10 lines · On Wed, 20 Mar 2013 09:38:44 +0100 Heiko Carstens <[email protected]>…
your commit "taint: add explicit flag to show whether lock dep is still OK." missed to change the s390 invocation of
add_taint():CC
arch/s390/kernel/dumpstack.oarch/s390/kernel/dumpstack.c: In function ‘die’:arch/s390/kernel/dumpstack.c:228:2: error: too few arguments to function ‘add_taint’Could be that this is a merge issue since
dumpstack.cis a new file which contains stuff that was formerly inarch/s390/kernel/traps.c
The commit (9ff3d92a818e "s390/dumpstack: fix call chain walking" in today's version of the s390 tree) that adds dumpstack.c has add_taint() with 2 arguments removed from traps.c and add_taint() with one argument added to dumpstack.c ... and add_taint() already has 2 arguments in that tree ...
Signature · 2 lines
Cheers, Stephen Rothwell [email protected]
Quoted 11 lines · Stephen Rothwell
Hi Heilo,
Quoted 8 lines · On Wed, 20 Mar 2013 09:38:44 +0100 Heiko Carstens <[email protected]>…
your commit "taint: add explicit flag to show whether lock dep is still OK." missed to change the s390 invocation of
add_taint():CC
arch/s390/kernel/dumpstack.oarch/s390/kernel/dumpstack.c: In function ‘die’:arch/s390/kernel/dumpstack.c:228:2: error: too few arguments to function ‘add_taint’
Quoted 8 lines
Quoted 2 lines
Could be that this is a merge issue since
dumpstack.cis a new file which contains stuff that was formerly inarch/s390/kernel/traps.cThe commit (
9ff3d92a818e"s390/dumpstack: fix call chain walking" in today's version of the s390 tree) that addsdumpstack.chasadd_taint()with 2 arguments removed fromtraps.candadd_taint()with one argument added todumpstack.c... andadd_taint()already has 2 arguments in that tree ...
Ouch! Looks like our work flow still sucks. Sorry for the noise and blaming others, we'll fix it up!