Skip to contentSkip to conversation

lttng-abi.c: fix the error check

PATCH Maxin B. John 1 participant 1 message Mar 23, 2013 1 message not in the archive

lore
Share & tools
lore

A message that is not in the archive (sent off-list or not yet received): 20130323160334.GB28816@Krystal

#1 lore raw
Quoted 8 lines · Mathieu Desnoyers
Quoted 7 lines · * Mathieu Desnoyers ([email protected]) wrote:
Quoted 6 lines · * Maxin B. John ([email protected]) wrote:

I was trying to fix a random problem happened in hawkboard with· 3.9.0-rc3 kernel.

root@hawkboard:~# uname -a
Linux hawkboard 3.9.0-rc3-00244-g9217cbb #35 PREEMPT Fri Mar 22
18:03:26 CET 2013 armv5tejl GNU/Linux

<snip>

Quoted 14 lines

a look at:

arch/arm/include/uapi/asm/unistd.h

shows:

#define __NR_OABI_SYSCALL_BASE 0x900000

#if defined(__thumb__) || defined(__ARM_EABI__)
#define __NR_SYSCALL_BASE 0
#else
#define __NR_SYSCALL_BASE __NR_OABI_SYSCALL_BASE
#endif

Quoted 3 lines

So this offset "base" might be causing the large allocation. Can you try the following patch and see if it helps ?
---

I have applied the patch and tested it on the device. However, I can still see the random page allocation failure (It works fine at first time and then randomly fails). Could be a hardware problem.. I will verify it in another similar board.

I forgot to mention that even before, with this page allocation failure, lttng works as expected and I can see the output using babeltrace.

oot@hawkboard:~# lttng enable-event -a -k
lttng-sessiond: page allocation failure: order:10, mode:0x10c0d0
[<c001358c>] (unwind_backtrace+0x0/0xfc) from [<c037af14>]
(dump_stack+0x20/0x24)
[<c037af14>] (dump_stack+0x20/0x24) from [<c00b7de8>]
(warn_alloc_failed+0xd0/0x114)
[<c00b7de8>] (warn_alloc_failed+0xd0/0x114) from [<c00bad80>]
(__alloc_pages_nodemask+0x620/0x8bc)
[<c00bad80>] (__alloc_pages_nodemask+0x620/0x8bc) from [<c00bb03c>]
(__get_free_pages+0x20/0x5c)
[<c00bb03c>] (__get_free_pages+0x20/0x5c) from [<c00e9e50>]
(kmalloc_order_trace+0x34/0xf4)
[<c00e9e50>] (kmalloc_order_trace+0x34/0xf4) from [<bf09affc>]
(lttng_syscalls_register+0x1a4/0x240 [lttng_tracer])
[<bf09affc>] (lttng_syscalls_register+0x1a4/0x240 [lttng_tracer]) from
[<bf082ce8>] (lttng_abi_create_event+0x7c/0x138 [lttng_tracer])
[<bf082ce8>] (lttng_abi_create_event+0x7c/0x
....

Thanks & Regards,
Maxin

_______________________________________________
lttng-dev mailing list
[email protected]
http://lists.lttng.org/cgi-bin/mailman/listinfo/lttng-dev