Skip to contentSkip to conversation

drivers/acpi/bgrt.c:undefined reference to `bgrt_tab' (defined in arch/x86/platform/efi/efi-bgrt.c)

DISCUSSION Fengguang Wu 2 participants 2 messages Mar 27, 2013 – Mar 29, 2013

lore
Share & tools
lore
#0 lore raw

Hi,

The error is bisected down to below commit, however I don't see obvious correlations.

The problem is, drivers/acpi/bgrt.c references bgrt_tab etc. variables defined in arch/x86/platform/efi/efi-bgrt.c which is obviously not available in ia64.

tree:   git://git.kernel.org/pub/scm/linux/kernel/git/torvalds/linux master
head:   c4052ba9dad9cc86cb3a1f0f8cb032514fa414be
commit: 18a44a7ff1075ce5157ac07cde573aca6b5e9973 Merge branch 'x86-urgent-for-linus' of git://git.kernel.org/pub/scm/linux/kernel/git/tip/tip
date:   4 weeks ago
config: make ARCH=ia64 allmodconfig

All error/warnings:

drivers/built-in.o: In function `show_yoffset':

Quoted 2 lines
Quoted 2 lines

bgrt.c:(.text+0xe5a71): undefined reference to bgrt_tab' bgrt.c:(.text+0xe5a91): undefined reference to bgrt_tab'

drivers/built-in.o: In function `show_xoffset':

Quoted 2 lines
Quoted 2 lines

bgrt.c:(.text+0xe5b51): undefined reference to bgrt_tab' bgrt.c:(.text+0xe5b71): undefined reference to bgrt_tab'

drivers/built-in.o: In function `show_type':

Quoted 1 line
Quoted 1 line

bgrt.c:(.text+0xe5c31): undefined reference to `bgrt_tab'

drivers/built-in.o:bgrt.c:(.text+0xe5c51): more undefined references to bgrt_tab' follow drivers/built-in.o: In function bgrt_init':
bgrt.c:(.init.text+0x8931): undefined reference to bgrt_image' bgrt.c:(.init.text+0x8932): undefined reference to bgrt_image_size' bgrt.c:(.init.text+0x8950): undefined reference to bgrt_image' bgrt.c:(.init.text+0x8960): undefined reference to bgrt_image_size'

---
0-DAY kernel build testing backend Open Source Technology Center
http://lists.01.org/mailman/listinfo/kbuild Intel Corporation

#1 lore raw

Re: drivers/acpi/bgrt.c:undefined reference to `bgrt_tab' (defined in arch/x86/platform/efi/efi-bgrt

Quoted 26 lines · Tony Luck

On Tue, Mar 26, 2013 at 5:55 PM, Fengguang Wu <[email protected] <mailto:[email protected]>> wrote:

The problem is, drivers/acpi/bgrt.c references bgrt_tab etc. variables defined in arch/x86/platform/efi/efi-bgrt.c which is obviously not available in ia64.

So perhaps the solution is to not let the user configure this on IA64. I don't think we have platforms with boot graphics support (many ia64 machines are headless so have *no* graphics at all!).

gmail will whitespace destroy this patch - but easier to type in the half dozen extra characters anyway:

diff --git a/drivers/acpi/Kconfig b/drivers/acpi/Kconfig
index 4fc0ffc..8fcae6d 100644

drivers/acpi/Kconfig config ACPI_CUSTOM_METHOD · line 401

Quoted 8 lines
drivers/acpi/Kconfig +1 -1
@@ -395,7 +395,7 @@ config ACPI_CUSTOM_METHOD
 
 config ACPI_BGRT
        bool "Boottime Graphics Resource Table support"
-       depends on EFI
+       depends on EFI && X86
         help
          This driver adds support for exposing the ACPI Boottime Graphics
          Resource Table, which allows the operating system to obtain

Makes sense to me.

-hpa