Skip to contentSkip to conversation

posix_cpu_timer: initialize "now" variable

PATCH Arnd Bergmann 2 participants 2 messages Apr 4, 2013

lore
Share & tools
lore
#0 lore raw

Patch 6d0e025 "posix_cpu_timer: consolidate expiry time type" in linux-next introduces a new compiler warning:

kernel/posix-cpu-timers.c: In function 'posix_cpu_timer_schedule':
kernel/posix-cpu-timers.c:1127:19: warning: 'now' may be used uninitialized in this function [-Wmaybe-uninitialized]

    clear_dead_task(timer, now);

As far as I can tell, that warning is about an actual bug an not a false positive, as that variable is clearly never initialized when it gets used in line 1127.

Here is a patch that makes the warning go away for me, no idea if this is the right solution or not.

---

kernel/posix-cpu-timers.c +1 -0
index e5286b5..1828b9f 100644
@@ -1119,6 +1119,7 @@ void posix_cpu_timer_schedule(struct k_itimer *timer)
 			timer->it.cpu.expires = 0;
 			goto out_unlock;
 		} else if (unlikely(p->exit_state) && thread_group_empty(p)) {
+			cpu_clock_sample(timer->it_clock, p, &now);
 			/*
 			 * We've noticed that the thread is dead, but
 			 * not yet reaped.  Take this opportunity to
#1 lore raw

2013/4/4 Arnd Bergmann <[email protected]>:

Quoted 7 lines

Patch 6d0e025 "posix_cpu_timer: consolidate expiry time type" in linux-next introduces a new compiler warning:

kernel/posix-cpu-timers.c: In function 'posix_cpu_timer_schedule':
kernel/posix-cpu-timers.c:1127:19: warning: 'now' may be used uninitialized in this function [-Wmaybe-uninitialized]

    clear_dead_task(timer, now);
Quoted 8 lines

As far as I can tell, that warning is about an actual bug an not a false positive, as that variable is clearly never initialized when it gets used in line 1127.

Here is a patch that makes the warning go away for me, no idea if this is the right solution or not.

I posted a fix two days ago: https://lkml.org/lkml/2013/3/30/63

Thanks.