Skip to contentSkip to conversation

scsi: pcmcia: nsp_cs: remove module init/exit function prototypes

PATCH In review H Hartley Sweeten 2 participants 2 messages Apr 15, 2013

Subsystems (2)
lore
Share & tools
lore
#0 lore raw

PATCH 1/1 scsi: pcmcia: nsp_cs: remove module init/exit function prototypes

This driver now uses the module_pcmcia_driver() macro to supply the init/exit code. The nsp_cs_{init,exit} prototypes should be removed.

---
 drivers/scsi/pcmcia/nsp_cs.h | 4 ----
 1 file changed, 4 deletions(-)
drivers/scsi/pcmcia/nsp_cs.h +0 -4
index afd64f0..ea5122f 100644
@@ -326,10 +326,6 @@ static struct Scsi_Host *nsp_detect(struct scsi_host_template *sht);
 /* Interrupt handler */
 //static irqreturn_t nspintr(int irq, void *dev_id);
 
-/* Module entry point*/
-static int  __init nsp_cs_init(void);
-static void __exit nsp_cs_exit(void);
-
 /* Debug */
 #ifdef NSP_DEBUG
 static void show_command (struct scsi_cmnd *SCpnt);
Signature · 1 line
1.8.1.4
maintainer
#1 lore raw
Quoted 2 lines · H Hartley Sweeten

This driver now uses the module_pcmcia_driver() macro to supply the init/exit code. The nsp_cs_{init,exit} prototypes should be removed.

This reasoning is bogus.

Why the driver actually has all these static prototypes in its header file is entirely unclear to me, but singling these two out for the reason you state above is wrong (both the reason and picking only two of them).

Hiroshi, you're the maintainer, what do you want to do ... since the driver is ancient, I'm happy to leave it untouched, or if you want to tidy it up, I see no reason to have any static prototypes in the header file.

Thanks,

James