go7007: dubious one-bit signed bitfields
Subsystems (3)
PATCH 1/1 go7007: dubious one-bit signed bitfields
Because they're signed, "is_video" and "is_audio" can be 0 and -1
instead of 0 and 1 as intended. It doesn't cause a bug, but it makes Sparse complain:drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfield drivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfield
drivers/staging/media/go7007/go7007-priv.h +2 -2
@@ -91,8 +91,8 @@ struct go7007_board_info {int num_i2c_devs;struct go_i2c {const char *type; -int is_video:1 ; -int is_audio:1 ; +unsigned int is_video:1 ; +unsigned int is_audio:1 ;int addr;u32 flags; } i2c_devs[5 ];
Quoted 7 lines · On Wed 17 April 2013 09:20:30 Dan Carpenter wrote:
Because they're signed, "
is_video" and "is_audio" can be 0 and -1
instead of 0 and 1 as intended. It doesn't cause a bug, but it makes Sparse complain:drivers/staging/media/go7007/go7007-priv.h:94:31: error: dubious one-bit signed bitfielddrivers/staging/media/go7007/go7007-priv.h:95:31: error: dubious one-bit signed bitfieldSigned-off-by Dan Carpenter <[email protected]>
Thanks!
Hans
Quoted 21 lines
drivers/staging/media/go7007/go7007-priv.h +2
-3@@ -91,8 +91,8 @@ struct go7007_board_info {int num_i2c_devs;struct go_i2c {const char *type; -int is_video:1 ; -int is_audio:1 ; +unsigned int is_video:1 ; +unsigned int is_audio:1 ;int addr;u32 flags; } i2c_devs[5 ]; --To unsubscribe from this list: send the line "unsubscribe linux-media" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html