r820t: memory leak in release()

PATCH New Dan Carpenter 1 participant 1 message Apr 18, 2013

Subsystems (2)

Media (V4L/DVB) Kernel janitors

lore

Share & tools

lore

Dan Carpenter

author

2013-04-18 19:21 UTC #0 lore raw

PATCH 2/2 r820t: memory leak in release()

I've moved the kfree(fe->tuner_priv) one line earlier, otherwise it is a no-op.

Signed-off-by Dan Carpenter <[email protected]>

---
This is a static checker fix and I have not tested it.

drivers/media/tuners/r820t.c +1 -2

index ba033fd..36ddbf1 100644
@@ -2252,9 +2252,8 @@ static int r820t_release(struct dvb_frontend *fe)
 
 	mutex_unlock(&r820t_list_mutex);
 
-	fe->tuner_priv = NULL;
-
 	kfree(fe->tuner_priv);
+	fe->tuner_priv = NULL;
 
 	return 0;
 }