Staging: Panel: panel: Fixed checkpatch line length warnings
PATCH 1/1 Staging: Panel: panel: Fixed checkpatch line length warnings
Fixed 4 cases of line length issues with checkpatch. Checkpatch is now clean for panel.c.
Signed-off-by 'Jake Champlin <[email protected]>'
--- drivers/staging/panel/panel.c | 25 ++++++++++++++----------- 1 file changed, 14 insertions(+), 11 deletions(-)
drivers/staging/panel/panel.c +14 -11
@@ -1756,17 +1756,18 @@ static inline int input_state_high(struct logical_input *input)if (input->high_timer ==0 ) {char *press_str = input->u.kbd.press_str; -if (press_str[0 ]) -keypad_send_key (press_str, -sizeof (input->u.kbd.press_str)); +if (press_str[0 ]) { +int s =sizeof (input->u.kbd.press_str); +keypad_send_key (press_str, s); + } }if (input->u.kbd.repeat_str[0 ]) {char *repeat_str = input->u.kbd.repeat_str;if (input->high_timer >=KEYPAD_REP_START ) { +int s =sizeof (input->u.kbd.repeat_str); input->high_timer -=KEYPAD_REP_DELAY ; -keypad_send_key (repeat_str, -sizeof (input->u.kbd.repeat_str)); +keypad_send_key (repeat_str, s); }/* we will need to come back here soon */ inputs_stable =0 ;
@@ -1802,10 +1803,11 @@ static inline void input_state_falling(struct logical_input *input)if (input->u.kbd.repeat_str[0 ]) {char *repeat_str = input->u.kbd.repeat_str; -if (input->high_timer >=KEYPAD_REP_START ) +if (input->high_timer >=KEYPAD_REP_START ) { +int s =sizeof (input->u.kbd.repeat_str); input->high_timer -=KEYPAD_REP_DELAY ; -keypad_send_key (repeat_str, -sizeof (input->u.kbd.repeat_str)); +keypad_send_key (repeat_str, s); + }/* we will need to come back here soon */ inputs_stable =0 ; }
@@ -1822,9 +1824,10 @@ static inline void input_state_falling(struct logical_input *input)release_fct (input->u.std.release_data); }else if (input->type ==INPUT_TYPE_KBD ) {char *release_str = input->u.kbd.release_str; -if (release_str[0 ]) -keypad_send_key (release_str, -sizeof (input->u.kbd.release_str)); +if (release_str[0 ]) { +int s =sizeof (input->u.kbd.release_str); +keypad_send_key (release_str, s); + } } input->state =INPUT_ST_LOW ;
Signature · 7 lines
1.8.2.1 -- Jake Champlin [email protected] <MuttClient>
Quoted 2 lines · Jake Champlin
Fixed 4 cases of line length issues with checkpatch. Checkpatch is now clean for
panel.c.
OK that's clean, thanks!
Quoted 1 line
Signed-off-by 'Jake Champlin <[email protected]>'
Acked-by Willy Tarreau <[email protected]>
Willy
drivers/staging/panel/panel.c static inline void input_state_falling(struct logical_input *input) · line 1810
Quoted 12 lines · Jake Champlin
drivers/staging/panel/panel.c +4
-3@@ -1802,10 +1803,11 @@ static inline void input_state_falling(struct logical_input *input)if (input->u.kbd.repeat_str[0 ]) {char *repeat_str = input->u.kbd.repeat_str; -if (input->high_timer >=KEYPAD_REP_START ) +if (input->high_timer >=KEYPAD_REP_START ) { +int s =sizeof (input->u.kbd.repeat_str); input->high_timer -=KEYPAD_REP_DELAY ; -keypad_send_key (repeat_str, -sizeof (input->u.kbd.repeat_str)); +keypad_send_key (repeat_str, s); + }
This looks like a bugfix. Good job. Please mention bug fixes in the changelog next time.
regards,
dan carpenter