3.8.13-stable review
Subsystems (39)
Greg Kroah-Hartman
maintainercover 3.8.13-stable review
--------------------
NOTE: This is the LAST 3.8.y kernel release to be done by me. After this one, it is end-of-life. You should have moved on to the 3.9.y kernel series by now.
--------------------
This is the start of the stable review cycle for the 3.8.13 release. There are 73 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat May 11 22:26:18 UTC 2013. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v3.0/stable-review/patch-3.8.13-rc1.gz
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 3.8.13-rc1
Jerry Hoemann <[email protected]>
x86/mm: account for PGDIR_SIZE alignment
Chen Gang <[email protected]>
kernel/audit_tree.c: tree will leak memory when failure occurs in audit_trim_trees()
Trond Myklebust <[email protected]>
NFSv4.x: Fix handling of partially delegated locks
Srivatsa S. Bhat <[email protected]>
EDAC: Don't give write permission to read-only files
Josef Bacik <[email protected]>
Btrfs: fix extent logging with O_DIRECT into prealloc
Josef Bacik <[email protected]>
Btrfs: compare relevant parts of delayed tree refs
Steven Rostedt (Red Hat) <[email protected]>
tracing: Fix ftrace_dump()
Alex Deucher <[email protected]>
drm/radeon: fix handling of v6 power tables
Alex Deucher <[email protected]>
drm/radeon: add new richland pci ids
Alex Deucher <[email protected]>
drm/radeon: fix possible segfault when parsing pm tables
Alex Deucher <[email protected]>
drm/radeon: fix endian bugs in atom_allocate_fb_scratch()
Alex Deucher <[email protected]>
drm/radeon: disable the crtcs in mc_stop (r5xx-r7xx) (v2)
Jerome Glisse <[email protected]>
drm/radeon: Always flush the VM
Alex Deucher <[email protected]>
drm/radeon: fix typo in si_select_se_sh()
Alex Deucher <[email protected]>
drm/radeon: fix hdmi mode enable on RS600/RS690/RS740
Alex Deucher <[email protected]>
drm/radeon: cleanup properly if mmio mapping fails
Alex Deucher <[email protected]>
drm/radeon/evergreen+: don't enable HPD interrupts on eDP/LVDS
Alex Deucher <[email protected]>
drm/radeon: add some new SI PCI ids
Alex Deucher <[email protected]>
drm/radeon: disable the crtcs in mc_stop (evergreen+) (v2)
Alex Deucher <[email protected]>
drm/radeon: update wait_for_vblank for r1xx-r4xx
Alex Deucher <[email protected]>
drm/radeon: properly lock disp in mc_stop/resume for r5xx-r7xx
Alex Deucher <[email protected]>
drm/radeon: properly lock disp in mc_stop/resume for evergreen+
Alex Deucher <[email protected]>
drm/radeon: update wait_for_vblank for evergreen+
Alex Deucher <[email protected]>
drm/radeon: update wait_for_vblank for r5xx-r7xx
Alex Deucher <[email protected]>
drm/radeon/dce6: add missing display reg for tiling setup
Alex Deucher <[email protected]>
drm/radeon: fix typo in rv515_mc_resume()
Alex Deucher <[email protected]>
drm/radeon: use frac fb div on RS780/RS880
Alex Deucher <[email protected]>
drm/radeon: don't use get_engine_clock() on APUs
David Müller <[email protected]>
drm/i915: Fall back to bit banging mode for DVO transmitter detection
Daniel Vetter <[email protected]>
drm/i915: Fixup Oops in the pipe config computation
Jani Nikula <[email protected]>
drm/i915: ensure single initialization and cleanup of backlight device
Paulo Zanoni <[email protected]>
drm/i915: set CPT FDI RX polarity bits based on VBT
Chris Wilson <[email protected]>
drm/i915: Use MLC (l3$) for context objects
Chris Wilson <[email protected]>
drm/i915: Workaround incoherence between fences and LLC across multiple CPUs
Egbert Eich <[email protected]>
drm/i915: Fix SDVO connector and encoder get_hw_state functions
Christian Lamparter <[email protected]>
drm/i915: Add no-lvds quirk for Fujitsu Esprimo Q900
Daniel Vetter <[email protected]>
drm/i915: Fix sdvo connector get_hw_state function
Chris Wilson <[email protected]>
drm/i915: Fix detection of base of stolen memory
Dave Airlie <[email protected]>
drm/ast: deal with bo reserve fail in dirty update path
Dave Airlie <[email protected]>
drm/prime: keep a reference from the handle to exported dma-buf (v6)
Anisse Astier <[email protected]>
drm/gma500: fix backlight hotkeys behaviour on netbooks
Dave Airlie <[email protected]>
drm/mgag200: deal with bo reserve fail in dirty update path
Dave Airlie <[email protected]>
drm/cirrus: deal with bo reserve fail in dirty update path
James Bottomley <[email protected]>
block: fix max discard sectors limit
Catalin Marinas <[email protected]>
arm64: Ignore the 'write' ESR flag on cache maintenance faults
Thadeu Lima de Souza Cascardo <[email protected]>
RDMA/cxgb4: Fix SQ allocation when on-chip SQ is disabled
Stefan Bader <[email protected]>
r8169: fix 8168evl frame padding.
Theodore Ts'o <[email protected]>
ext4: add check for inodes_count overflow in new resize ioctl
Matthias Schiffer <[email protected]>
netfilter: ip6t_NPT: Fix translation for non-multiple of 32 prefix lengths
Florian Westphal <[email protected]>
netfilter: xt_rpfilter: skip locally generated broadcast/multicast, too
Florian Westphal <[email protected]>
netfilter: ctnetlink: don't permit ct creation with random tuple
Florian Westphal <[email protected]>
netfilter: nf_ct_helper: don't discard helper if it is actually the same
Jozsef Kadlecsik <[email protected]>
netfilter: ipset: "Directory not empty" error message
Patrick McHardy <[email protected]>
netfilter: nf_ct_sip: don't drop packets with offsets pointing outside the packet
Jozsef Kadlecsik <[email protected]>
netfilter: ipset: list:set: fix reference counter update
Florian Westphal <[email protected]>
netfilter: nf_nat: fix race when unloading protocol modules
Hans Schillstrom <[email protected]>
ipvs: ip_vs_sip_fill_param() BUG: bad check of return value
Sarah Sharp <[email protected]>
xhci: Don't warn on empty ring for suspended devices.
Konstantin Khlebnikov <[email protected]>
e1000e: fix accessing to suspended device
Konstantin Khlebnikov <[email protected]>
e1000e: fix runtime power management transitions
Rafael J. Wysocki <[email protected]>
PCI/PM: Clear state_saved during suspend
Peter Zijlstra <[email protected]>
perf/x86/intel/lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL
Peter Zijlstra <[email protected]>
perf/x86/intel/lbr: Fix LBR filter
Jan-Simon Möller <[email protected]>
perf/x86/intel: Fix unintended variable name reuse
Vince Weaver <[email protected]>
perf/x86/intel: Add support for IvyBridge model 58 Uncore
Benjamin Herrenschmidt <[email protected]>
net/eth/ibmveth: Fixup retrieval of MAC address
Joerg Roedel <[email protected]>
iommu/amd: Properly initialize irq-table lock
Naoya Horiguchi <[email protected]>
hugetlbfs: fix mmap failure in unaligned size request
David Jeffery <[email protected]>
autofs - remove autofs dentry mount check
Axel Lin <[email protected]>
pwm: spear: Fix checking return value of clk_enable() and clk_prepare()
Vaidyanathan Srinivasan <[email protected]>
powerpc: fix numa distance for form0 device tree
Anton Blanchard <[email protected]>
powerpc: Emulate non privileged DSCR read and write
Stefano Stabellini <[email protected]>
xen/arm: actually pass a non-NULL percpu pointer to request_percpu_irq
-------------
Diffstat:
Makefile | 4 +- arch/arm/xen/enlighten.c | 2 +- arch/arm64/mm/fault.c | 3 +- arch/powerpc/include/asm/ppc-opcode.h | 4 + arch/powerpc/kernel/traps.c | 10 ++- arch/powerpc/mm/numa.c | 2 +- arch/x86/kernel/cpu/perf_event_intel_lbr.c | 27 +++++-- arch/x86/kernel/cpu/perf_event_intel_uncore.c | 17 ++-- arch/x86/mm/init.c | 5 ++ drivers/edac/edac_mc_sysfs.c | 12 +-- drivers/gpu/drm/ast/ast_drv.h | 2 + drivers/gpu/drm/ast/ast_fb.c | 43 +++++++++- drivers/gpu/drm/ast/ast_ttm.c | 2 +- drivers/gpu/drm/cirrus/cirrus_drv.h | 2 + drivers/gpu/drm/cirrus/cirrus_fbdev.c | 38 ++++++++- drivers/gpu/drm/cirrus/cirrus_ttm.c | 2 +- drivers/gpu/drm/drm_gem.c | 4 +- drivers/gpu/drm/drm_prime.c | 76 +++++++++--------- drivers/gpu/drm/gma500/psb_irq.c | 2 +- drivers/gpu/drm/i915/i915_drv.h | 2 + drivers/gpu/drm/i915/i915_gem.c | 28 +++++-- drivers/gpu/drm/i915/i915_gem_context.c | 7 ++ drivers/gpu/drm/i915/i915_gem_stolen.c | 81 +++++++++---------- drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_bios.c | 6 +- drivers/gpu/drm/i915/intel_bios.h | 4 +- drivers/gpu/drm/i915/intel_display.c | 26 +++--- drivers/gpu/drm/i915/intel_dp.c | 5 +- drivers/gpu/drm/i915/intel_dvo.c | 13 ++- drivers/gpu/drm/i915/intel_lvds.c | 9 ++- drivers/gpu/drm/i915/intel_panel.c | 7 +- drivers/gpu/drm/i915/intel_pm.c | 9 ++- drivers/gpu/drm/i915/intel_sdvo.c | 5 +- drivers/gpu/drm/mgag200/mgag200_drv.h | 2 + drivers/gpu/drm/mgag200/mgag200_fb.c | 43 +++++++++- drivers/gpu/drm/mgag200/mgag200_ttm.c | 4 +- drivers/gpu/drm/radeon/atom.c | 6 +- drivers/gpu/drm/radeon/atombios_crtc.c | 3 + drivers/gpu/drm/radeon/evergreen.c | 111 +++++++++++++++++++++++--- drivers/gpu/drm/radeon/evergreen_reg.h | 2 + drivers/gpu/drm/radeon/ni.c | 8 +- drivers/gpu/drm/radeon/nid.h | 4 + drivers/gpu/drm/radeon/r100.c | 77 ++++++++++++------ drivers/gpu/drm/radeon/r500_reg.h | 2 + drivers/gpu/drm/radeon/r600_hdmi.c | 4 +- drivers/gpu/drm/radeon/radeon_atombios.c | 21 +++-- drivers/gpu/drm/radeon/radeon_kms.c | 4 + drivers/gpu/drm/radeon/radeon_pm.c | 6 +- drivers/gpu/drm/radeon/radeon_ring.c | 3 +- drivers/gpu/drm/radeon/rs600.c | 52 ++++++++++-- drivers/gpu/drm/radeon/rv515.c | 56 ++++++++++++- drivers/gpu/drm/radeon/si.c | 3 +- drivers/gpu/drm/radeon/sid.h | 2 + drivers/infiniband/hw/cxgb4/qp.c | 25 +++--- drivers/iommu/amd_iommu.c | 3 + drivers/net/ethernet/ibm/ibmveth.c | 23 +++--- drivers/net/ethernet/intel/e1000e/ethtool.c | 13 +++ drivers/net/ethernet/intel/e1000e/netdev.c | 80 +++++-------------- drivers/net/ethernet/realtek/r8169.c | 9 +++ drivers/pci/pci-driver.c | 4 + drivers/pwm/pwm-spear.c | 6 +- drivers/usb/host/xhci-ring.c | 23 ++++-- fs/autofs4/expire.c | 9 --- fs/btrfs/delayed-ref.c | 24 +++--- fs/btrfs/inode.c | 21 +++-- fs/ext4/resize.c | 4 + fs/hugetlbfs/inode.c | 24 +++--- fs/nfs/nfs4proc.c | 4 +- include/drm/drmP.h | 5 +- include/drm/drm_pciids.h | 5 ++ include/linux/blkdev.h | 2 +- include/linux/hugetlb.h | 19 +++-- ipc/shm.c | 6 +- kernel/audit_tree.c | 2 +- kernel/trace/trace.c | 62 ++++++-------- kernel/trace/trace_selftest.c | 9 ++- mm/mmap.c | 7 +- net/ipv4/netfilter/ipt_rpfilter.c | 8 +- net/ipv6/netfilter/ip6t_NPT.c | 2 +- net/ipv6/netfilter/ip6t_rpfilter.c | 8 +- net/netfilter/ipset/ip_set_core.c | 3 +- net/netfilter/ipset/ip_set_list_set.c | 10 ++- net/netfilter/ipvs/ip_vs_pe_sip.c | 6 +- net/netfilter/nf_conntrack_helper.c | 4 +- net/netfilter/nf_conntrack_netlink.c | 3 + net/netfilter/nf_conntrack_sip.c | 2 +- net/netfilter/nf_nat_core.c | 40 ++-------- 87 files changed, 903 insertions(+), 446 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/73 xen/arm: actually pass a non-NULL percpu pointer to request_percpu_irq
3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stefano Stabellini <[email protected]>
commit 2798ba7d19aed645663398a21ec4006bfdbb1ef3 upstream.
--- arch/arm/xen/enlighten.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/arm/xen/enlighten.c +1 -1
@@ -237,7 +237,7 @@ static int __init xen_init_events(void)xen_init_IRQ ();if (request_percpu_irq (xen_events_irq, xen_arm_callback, -"events" , xen_vcpu)) { +"events" , &xen_vcpu)) {pr_err ("Error requesting IRQ %d\n" , xen_events_irq);return -EINVAL ; }
Greg Kroah-Hartman
maintainerPATCH 2/73 powerpc: Emulate non privileged DSCR read and write
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Anton Blanchard <[email protected]>
commit 73d2fb758e678c93bc76d40876c2359f0729b0ef upstream.
POWER8 allows read and write of the DSCR in userspace. We added kernel emulation so applications could always use the instructions regardless of the CPU type.
Unfortunately there are two SPRs for the DSCR and we only added emulation for the privileged one. Add code to match the non privileged one.
A simple test was created to verify the fix:
http://ozlabs.org/~anton/junkcode/user_dscr_test.c
Without the patch we get a SIGILL and it passes with the patch.
--- arch/powerpc/include/asm/ppc-opcode.h | 4 ++++ arch/powerpc/kernel/traps.c | 10 ++++++++-- 2 files changed, 12 insertions(+), 2 deletions(-)
arch/powerpc/include/asm/ppc-opcode.h +4 -0
@@ -112,6 +112,10 @@#define PPC_INST_MFSPR_DSCR_MASK 0xfc1fffff#define PPC_INST_MTSPR_DSCR 0x7c1103a6#define PPC_INST_MTSPR_DSCR_MASK 0xfc1fffff +#define PPC_INST_MFSPR_DSCR_USER 0x7c0302a6 +#define PPC_INST_MFSPR_DSCR_USER_MASK 0xfc1fffff +#define PPC_INST_MTSPR_DSCR_USER 0x7c0303a6 +#define PPC_INST_MTSPR_DSCR_USER_MASK 0xfc1fffff#define PPC_INST_SLBFEE 0x7c0007a7#define PPC_INST_STRING 0x7c00042a
arch/powerpc/kernel/traps.c +8 -2
@@ -961,7 +961,10 @@ static int emulate_instruction(struct pt#ifdef CONFIG_PPC64 /* Emulate the mfspr rD, DSCR. */ -if (((instword &PPC_INST_MFSPR_DSCR_MASK ) ==PPC_INST_MFSPR_DSCR ) && +if ((((instword &PPC_INST_MFSPR_DSCR_USER_MASK ) == +PPC_INST_MFSPR_DSCR_USER ) || + ((instword &PPC_INST_MFSPR_DSCR_MASK ) == +PPC_INST_MFSPR_DSCR )) &&cpu_has_feature (CPU_FTR_DSCR )) {PPC_WARN_EMULATED (mfdscr, regs); rd = (instword >>21 ) &0x1f ;
@@ -969,7 +972,10 @@ static int emulate_instruction(struct ptreturn 0 ; }/* Emulate the mtspr DSCR, rD. */ -if (((instword &PPC_INST_MTSPR_DSCR_MASK ) ==PPC_INST_MTSPR_DSCR ) && +if ((((instword &PPC_INST_MTSPR_DSCR_USER_MASK ) == +PPC_INST_MTSPR_DSCR_USER ) || + ((instword &PPC_INST_MTSPR_DSCR_MASK ) == +PPC_INST_MTSPR_DSCR )) &&cpu_has_feature (CPU_FTR_DSCR )) {PPC_WARN_EMULATED (mtdscr, regs); rd = (instword >>21 ) &0x1f ;
Greg Kroah-Hartman
maintainerPATCH 3/73 powerpc: fix numa distance for form0 device tree
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vaidyanathan Srinivasan <[email protected]>
commit 7122beeee7bc1757682049780179d7c216dd1c83 upstream.
The following commit breaks numa distance setup for old powerpc systems that use form0 encoding in device tree.
commit 41eab6f88f24124df89e38067b3766b7bef06ddb powerpc/numa: Use form 1 affinity to setup node distance
Device tree node /rtas/ibm,associativity-reference-points would index into /cpus/PowerPCxxxx/ibm,associativity based on form0 or form1 encoding detected by ibm,architecture-vec-5 property.
All modern systems use form1 and current kernel code is correct. However, on older systems with form0 encoding, the numa distance will get hard coded as LOCAL_DISTANCE for all nodes. This causes task scheduling anomaly since scheduler will skip building numa level domain (topmost domain with all cpus) if all numa distances are same. (value of 'level' in sched_init_numa() will remain 0)
Prior to the above commit:
((from) == (to) ? LOCAL_DISTANCE : REMOTE_DISTANCE)
Restoring compatible behavior with this patch for old powerpc systems with device tree where numa distance are encoded as form0.
--- arch/powerpc/mm/numa.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
arch/powerpc/mm/numa.c +1 -1
@@ -201,7 +201,7 @@ int __node_distance(int a, int b)int distance =LOCAL_DISTANCE ;if (!form1_affinity) -return distance; +return ((a == b) ?LOCAL_DISTANCE :REMOTE_DISTANCE );for (i =0 ; i < distance_ref_points_depth; i++) {if (distance_lookup_table[a][i] == distance_lookup_table[b][i])
Greg Kroah-Hartman
maintainerPATCH 4/73 pwm: spear: Fix checking return value of clk_enable() and clk_prepare()
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Axel Lin <[email protected]>
commit 563861cd633ae52932843477bb6ca3f1c9e2f78b upstream.
The logic to check return value of clk_enable() and clk_prepare() is reversed, fix it.
--- drivers/pwm/pwm-spear.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/pwm/pwm-spear.c +3 -3
@@ -143,7 +143,7 @@ static int spear_pwm_enable(struct pwm_cu32 val; rc =clk_enable (pc->clk); -if (!rc) +if (rc)return rc; val =spear_pwm_readl (pc, pwm->hwpwm,PWMCR );
@@ -209,12 +209,12 @@ static int spear_pwm_probe(struct platfo pc->chip.npwm =NUM_PWM ; ret =clk_prepare (pc->clk); -if (!ret) +if (ret)return ret;if (of_device_is_compatible (np,"st,spear1340-pwm" )) { ret =clk_enable (pc->clk); -if (!ret) { +if (ret) {clk_unprepare (pc->clk);return ret; }
Greg Kroah-Hartman
maintainerPATCH 5/73 autofs - remove autofs dentry mount check
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Jeffery <[email protected]>
commit ce8a5dbdf9e709bdaf4618d7ef8cceb91e8adc69 upstream.
When checking if an autofs mount point is busy it isn't sufficient to only check if it's a mount point.
For example, if the mount of an offset mountpoint in a tree is denied for this host by its export and the dentry becomes a process working directory the check incorrectly returns the mount as not in use at expire.
This can happen since the default when mounting within a tree is nostrict, which means ingnore mount fails on mounts within the tree and continue. The nostrict option is meant to allow mounting in this case.
--- fs/autofs4/expire.c | 9 --------- 1 file changed, 9 deletions(-)
fs/autofs4/expire.c +0 -9
@@ -61,15 +61,6 @@ static int autofs4_mount_busy(struct vfs/* This is an autofs submount, we can't expire it */ if (autofs_type_indirect (sbi->type)) goto done; - -/* -* Otherwise it's an offset mount and we need to check -* if we can umount its mount, if there is one. -*/ -if (!d_mountpoint (path.dentry)) { - status =0 ; - goto done; - } }/* Update the expiry counter if fs is busy */
Greg Kroah-Hartman
maintainerPATCH 6/73 hugetlbfs: fix mmap failure in unaligned size request
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Naoya Horiguchi <[email protected]>
commit af73e4d9506d3b797509f3c030e7dcd554f7d9c4 upstream.
The current kernel returns -EINVAL unless a given mmap length is "almost" hugepage aligned. This is because in sys_mmap_pgoff() the given length is passed to vm_mmap_pgoff() as it is without being aligned with hugepage boundary.
This is a regression introduced in commit 40716e29243d ("hugetlbfs: fix alignment of huge page requests"), where alignment code is pushed into hugetlb_file_setup() and the variable len in caller side is not changed.
To fix this, this patch partially reverts that commit, and adds alignment code in caller side. And it also introduces hstate_sizelog() in order to get proper hstate to specified hugepage size.
Addresses https://bugzilla.kernel.org/show_bug.cgi?id=56881
--- fs/hugetlbfs/inode.c | 24 ++++++++++-------------- include/linux/hugetlb.h | 19 +++++++++++++------ ipc/shm.c | 6 +++++- mm/mmap.c | 7 ++++++- 4 files changed, 34 insertions(+), 22 deletions(-)
fs/hugetlbfs/inode.c +10 -14
@@ -908,19 +908,19 @@ static int can_do_hugetlb_shm(void)static int get_hstate_idx (int page_size_log) { -struct hstate *h; +struct hstate *h =hstate_sizelog (page_size_log); -if (!page_size_log) -return default_hstate_idx; - h =size_to_hstate (1 << page_size_log);if (!h)return -1 ;return h - hstates; } -struct file *hugetlb_file_setup (const char *name,unsigned long addr, -size_t size,vm_flags_t acctflag, -struct user_struct **user, +/* +* Note that size should be aligned to proper hugepage size in caller side, +* otherwise hugetlb_reserve_pages reserves one less hugepages than intended. +*/ +struct file *hugetlb_file_setup (const char *name,size_t size, +vm_flags_t acctflag,struct user_struct **user,int creat_flags,int page_size_log) {int error = -ENOMEM ;
@@ -929,8 +929,6 @@ struct file *hugetlb_file_setup(const chstruct path path;struct dentry *root;struct qstr quick_string; -struct hstate *hstate; -unsigned long num_pages;int hstate_idx; hstate_idx =get_hstate_idx (page_size_log);
@@ -969,12 +967,10 @@ struct file *hugetlb_file_setup(const chif (!inode) goto out_dentry; - hstate =hstate_inode (inode); - size += addr & ~huge_page_mask (hstate); - num_pages =ALIGN (size,huge_page_size (hstate)) >> -huge_page_shift (hstate); error = -ENOMEM ; -if (hugetlb_reserve_pages (inode,0 , num_pages,NULL , acctflag)) +if (hugetlb_reserve_pages (inode,0 , + size >>huge_page_shift (hstate_inode (inode)),NULL , + acctflag)) goto out_inode;d_instantiate (path.dentry, inode);
include/linux/hugetlb.h +13 -6
@@ -185,8 +185,7 @@ static inline struct hugetlbfs_sb_info *extern const struct file_operations hugetlbfs_file_operations;extern const struct vm_operations_struct hugetlb_vm_ops; -struct file *hugetlb_file_setup (const char *name,unsigned long addr, -size_t size,vm_flags_t acct, +struct file *hugetlb_file_setup (const char *name,size_t size,vm_flags_t acct,struct user_struct **user,int creat_flags,int page_size_log);
@@ -205,8 +204,8 @@ static inline int is_file_hugepages(stru#define is_file_hugepages (file) 0static inline struct file * -hugetlb_file_setup (const char *name,unsigned long addr,size_t size, -vm_flags_t acctflag,struct user_struct **user,int creat_flags, +hugetlb_file_setup (const char *name,size_t size,vm_flags_t acctflag, +struct user_struct **user,int creat_flags,int page_size_log) {return ERR_PTR (-ENOSYS );
@@ -284,6 +283,13 @@ static inline struct hstate *hstate_filereturn hstate_inode (f->f_dentry->d_inode); } +static inline struct hstate *hstate_sizelog (int page_size_log) +{ +if (!page_size_log) +return &default_hstate; +return size_to_hstate (1 << page_size_log); +} +static inline struct hstate *hstate_vma (struct vm_area_struct *vma) {return hstate_file (vma->vm_file);
@@ -348,11 +354,12 @@ static inline int hstate_index(struct hs return h - hstates; } -#else +#else /* CONFIG_HUGETLB_PAGE */ struct hstate {};#define alloc_huge_page_node (h, nid) NULL#define alloc_bootmem_huge_page (h) NULL#define hstate_file (f) NULL +#define hstate_sizelog (s) NULL#define hstate_vma (v) NULL#define hstate_inode (i) NULL#define huge_page_size (h) PAGE_SIZE
@@ -367,6 +374,6 @@ static inline unsigned int pages_per_hug }#define hstate_index_to_shift (index) 0#define hstate_index (h) 0 -#endif +#endif /* CONFIG_HUGETLB_PAGE */ #endif /* _LINUX_HUGETLB_H */
ipc/shm.c +5 -1
@@ -491,10 +491,14 @@ static int newseg(struct ipc_namespace *sprintf (name,"SYSV%08x" , key);if (shmflg &SHM_HUGETLB ) { +struct hstate *hs =hstate_sizelog ((shmflg >>SHM_HUGE_SHIFT ) + &SHM_HUGE_MASK ); +size_t hugesize =ALIGN (size,huge_page_size (hs)); +/* hugetlb_file_setup applies strict accounting */ if (shmflg &SHM_NORESERVE ) acctflag =VM_NORESERVE ; - file =hugetlb_file_setup (name,0 , size, acctflag, + file =hugetlb_file_setup (name, hugesize, acctflag, &shp->mlock_user,HUGETLB_SHMFS_INODE , (shmflg >>SHM_HUGE_SHIFT ) &SHM_HUGE_MASK ); }else {
mm/mmap.c +6 -1
@@ -1296,15 +1296,20 @@ SYSCALL_DEFINE6(mmap_pgoff, unsigned lon file =fget (fd);if (!file) goto out; +if (is_file_hugepages (file)) + len =ALIGN (len,huge_page_size (hstate_file (file))); }else if (flags &MAP_HUGETLB ) {struct user_struct *user =NULL ; + + len =ALIGN (len,huge_page_size (hstate_sizelog ( + (flags >>MAP_HUGE_SHIFT ) &MAP_HUGE_MASK )));/* * VM_NORESERVE is used because the reservations will be * taken when vm_ops->mmap() is called * A dummy user value is used because we are not locking * memory so no accounting is necessary */ - file =hugetlb_file_setup (HUGETLB_ANON_FILE , addr, len, + file =hugetlb_file_setup (HUGETLB_ANON_FILE , len,VM_NORESERVE , &user,HUGETLB_ANONHUGE_INODE , (flags >>MAP_HUGE_SHIFT ) &MAP_HUGE_MASK );
Greg Kroah-Hartman
maintainerPATCH 7/73 iommu/amd: Properly initialize irq-table lock
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Joerg Roedel <[email protected]>
commit 197887f03daecdb3ae21bafeb4155412abad3497 upstream.
Fixes a lockdep warning.
--- drivers/iommu/amd_iommu.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/iommu/amd_iommu.c +3 -0
@@ -3948,6 +3948,9 @@ static struct irq_remap_table *get_irq_tif (!table) goto out; +/* Initialize table spin-lock */ +spin_lock_init (&table->lock); +if (ioapic)/* Keep the first 32 indexes free for IOAPIC interrupts */ table->min_index =32 ;
Greg Kroah-Hartman
maintainerPATCH 8/73 net/eth/ibmveth: Fixup retrieval of MAC address
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Benjamin Herrenschmidt <[email protected]>
commit 13f85203e1060da83d9ec1c1c5a63343eaab8de4 upstream.
Some ancient pHyp versions used to create a 8 bytes local-mac-address property in the device-tree instead of a 6 bytes one for veth.
The Linux driver code to deal with that is an insane hack which also happens to break with some choices of MAC addresses in qemu by testing for a bit in the address rather than just looking at the size of the property.
Sanitize this by doing the latter instead.
--- drivers/net/ethernet/ibm/ibmveth.c | 23 ++++++++++------------- 1 file changed, 10 insertions(+), 13 deletions(-)
drivers/net/ethernet/ibm/ibmveth.c +10 -13
@@ -1326,7 +1326,7 @@ static const struct net_device_ops ibmvestatic int ibmveth_probe (struct vio_dev *dev,const struct vio_device_id *id) { -int rc, i; +int rc, i, mac_len;struct net_device *netdev;struct ibmveth_adapter *adapter;unsigned char *mac_addr_p;
@@ -1336,11 +1336,19 @@ static int ibmveth_probe(struct vio_dev dev->unit_address); mac_addr_p = (unsigned char *)vio_get_attribute (dev,VETH_MAC_ADDR , -NULL ); + &mac_len);if (!mac_addr_p) {dev_err (&dev->dev,"Can't find VETH_MAC_ADDR attribute\n" );return -EINVAL ; } +/* Workaround for old/broken pHyp */ +if (mac_len ==8 ) + mac_addr_p +=2 ; +else if (mac_len !=6 ) { +dev_err (&dev->dev,"VETH_MAC_ADDR attribute wrong len %d\n" , + mac_len); +return -EINVAL ; + } mcastFilterSize_p = (unsigned int *)vio_get_attribute (dev,VETH_MCAST_FILTER_SIZE ,NULL );
@@ -1365,17 +1373,6 @@ static int ibmveth_probe(struct vio_devnetif_napi_add (netdev, &adapter->napi, ibmveth_poll,16 ); -/* -* Some older boxes running PHYP non-natively have an OF that returns -* a 8-byte local-mac-address field (and the first 2 bytes have to be -* ignored) while newer boxes' OF return a 6-byte field. Note that -* IEEE 1275 specifies that local-mac-address must be a 6-byte field. -* The RPA doc specifies that the first byte must be 10b, so we'll -* just look for it to solve this 8 vs. 6 byte field issue -*/ -if ((*mac_addr_p &0x3 ) !=0x02 ) - mac_addr_p +=2 ; - adapter->mac_addr =0 ;memcpy (&adapter->mac_addr, mac_addr_p,6 );
Greg Kroah-Hartman
maintainerPATCH 9/73 perf/x86/intel: Add support for IvyBridge model 58 Uncore
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Vince Weaver <[email protected]>
commit 9a6bc14350b130427725f33e371e86212fa56c85 upstream.
According to Intel Vol3b 18.9, the IvyBridge model 58 uncore is the same as that of SandyBridge.
I've done some simple tests and with this patch things seem to work on my mac-mini.
--- arch/x86/kernel/cpu/perf_event_intel_uncore.c | 1 + 1 file changed, 1 insertion(+)
arch/x86/kernel/cpu/perf_event_intel_uncore.c +1 -0
@@ -2853,6 +2853,7 @@ static int __init uncore_cpu_init(void) msr_uncores = nhm_msr_uncores;break ;case 42 :/* Sandy Bridge */ +case 58 :/* Ivy Bridge */ if (snb_uncore_cbox.num_boxes > max_cores) snb_uncore_cbox.num_boxes = max_cores; msr_uncores = snb_msr_uncores;
Greg Kroah-Hartman
maintainerPATCH 10/73 perf/x86/intel: Fix unintended variable name reuse
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jan-Simon Möller <[email protected]>
commit 1b0dac2ac6debdbf1541e15f2cede03613cf4465 upstream.
The variable name events_group is already in used and led to a compilation error when using clang to build the Linux Kernel . The fix is just to rename the var. No functional change. Please apply.
Fix suggested in discussion by PaX Team <[email protected]>
--- arch/x86/kernel/cpu/perf_event_intel_uncore.c | 16 ++++++++-------- 1 file changed, 8 insertions(+), 8 deletions(-)
arch/x86/kernel/cpu/perf_event_intel_uncore.c +8 -8
@@ -2428,7 +2428,7 @@ static void __init uncore_types_exit(strstatic int __init uncore_type_init (struct intel_uncore_type *type) {struct intel_uncore_pmu *pmus; -struct attribute_group *events_group; +struct attribute_group *attr_group;struct attribute **attrs;int i, j;
@@ -2455,19 +2455,19 @@ static int __init uncore_type_init(strucwhile (type->event_descs[i].attr.attr.name) i++; - events_group =kzalloc (sizeof (struct attribute *) * (i +1 ) + -sizeof (*events_group),GFP_KERNEL ); -if (!events_group) + attr_group =kzalloc (sizeof (struct attribute *) * (i +1 ) + +sizeof (*attr_group),GFP_KERNEL ); +if (!attr_group) goto fail; - attrs = (struct attribute **)(events_group +1 ); - events_group->name ="events" ; - events_group->attrs = attrs; + attrs = (struct attribute **)(attr_group +1 ); + attr_group->name ="events" ; + attr_group->attrs = attrs;for (j =0 ; j < i; j++) attrs[j] = &type->event_descs[j].attr.attr; - type->events_group = events_group; + type->events_group = attr_group; } type->pmu_group = &uncore_pmu_attr_group;
Greg Kroah-Hartman
maintainerPATCH 11/73 perf/x86/intel/lbr: Fix LBR filter
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Zijlstra <[email protected]>
commit 6e15eb3ba6c0249c9e8c783517d131b47db995ca upstream.
The LBR 'from' adddress is under full userspace control; ensure we validate it before reading from it.
Note: is_module_text_address() can potentially be quite expensive; for those running into that with high overhead in modules optimize it using an RCU backed rb-tree.
--- arch/x86/kernel/cpu/perf_event_intel_lbr.c | 14 ++++++++++++-- 1 file changed, 12 insertions(+), 2 deletions(-)
arch/x86/kernel/cpu/perf_event_intel_lbr.c +12 -2
@@ -442,8 +442,18 @@ static int branch_type(unsigned long froreturn X86_BR_NONE ; addr = buf; - }else - addr = (void *)from; + }else { +/* +* The LBR logs any address in the IP, even if the IP just +* faulted. This means userspace can control the from address. +* Ensure we don't blindy read any address by validating it is +* a known text address. +*/ +if (kernel_text_address (from)) + addr = (void *)from; +else +return X86_BR_NONE ; + }/* * decoder needs to know the ABI especially
Greg Kroah-Hartman
maintainerPATCH 12/73 perf/x86/intel/lbr: Demand proper privileges for PERF_SAMPLE_BRANCH_KERNEL
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Peter Zijlstra <[email protected]>
commit 7cc23cd6c0c7d7f4bee057607e7ce01568925717 upstream.
We should always have proper privileges when requesting kernel data.
--- arch/x86/kernel/cpu/perf_event_intel_lbr.c | 13 ++++++++++--- 1 file changed, 10 insertions(+), 3 deletions(-)
arch/x86/kernel/cpu/perf_event_intel_lbr.c +10 -3
@@ -310,7 +310,7 @@ void intel_pmu_lbr_read(void)* - in case there is no HW filter * - in case the HW filter has errata or limitations */ -static void intel_pmu_setup_sw_lbr_filter (struct perf_event *event) +static int intel_pmu_setup_sw_lbr_filter (struct perf_event *event) {u64 br_type = event->attr.branch_sample_type;int mask =0 ;
@@ -318,8 +318,11 @@ static void intel_pmu_setup_sw_lbr_filteif (br_type &PERF_SAMPLE_BRANCH_USER ) mask |=X86_BR_USER ; -if (br_type &PERF_SAMPLE_BRANCH_KERNEL ) +if (br_type &PERF_SAMPLE_BRANCH_KERNEL ) { +if (perf_paranoid_kernel () && !capable (CAP_SYS_ADMIN )) +return -EACCES ; mask |=X86_BR_KERNEL ; + }/* we ignore BRANCH_HV here */
@@ -339,6 +342,8 @@ static void intel_pmu_setup_sw_lbr_filte* be used by fixup code for some CPU */ event->hw.branch_reg.reg = mask; + +return 0 ; }/*
@@ -386,7 +391,9 @@ int intel_pmu_setup_lbr_filter(struct pe/* * setup SW LBR filter */ -intel_pmu_setup_sw_lbr_filter (event); + ret =intel_pmu_setup_sw_lbr_filter (event); +if (ret) +return ret;/* * setup HW LBR filter, if any
Greg Kroah-Hartman
maintainerPATCH 13/73 PCI/PM: Clear state_saved during suspend
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Rafael J. Wysocki <[email protected]>
commit 82fee4d67ab86d6fe5eb0f9a9e988ca9d654d765 upstream.
This patch clears pci_dev->state_saved at the beginning of suspending. PCI config state may be saved long before that. Some drivers call pci_save_state() from the ->probe() callback to get snapshot of sane configuration space to use in the ->slot_reset() callback.
--- drivers/pci/pci-driver.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/pci/pci-driver.c +4 -0
@@ -628,6 +628,7 @@ static int pci_pm_suspend(struct device goto Fixup; } + pci_dev->state_saved = false;if (pm->suspend) {pci_power_t prev = pci_dev->current_state;int error;
@@ -774,6 +775,7 @@ static int pci_pm_freeze(struct device *return 0 ; } + pci_dev->state_saved = false;if (pm->freeze) {int error;
@@ -862,6 +864,7 @@ static int pci_pm_poweroff(struct device goto Fixup; } + pci_dev->state_saved = false;if (pm->poweroff) {int error;
@@ -987,6 +990,7 @@ static int pci_pm_runtime_suspend(structif (!pm || !pm->runtime_suspend)return -ENOSYS ; + pci_dev->state_saved = false; pci_dev->no_d3cold = false; error = pm->runtime_suspend (dev);suspend_report_result (pm->runtime_suspend, error);
Greg Kroah-Hartman
maintainerPATCH 14/73 e1000e: fix runtime power management transitions
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Konstantin Khlebnikov <[email protected]>
commit 66148babe728f3e00e13c56f6b0ecf325abd80da upstream.
This patch removes redundant actions from driver and fixes its interaction with actions in pci-bus runtime power management code.
It removes pci_save_state() from __e1000_shutdown() for normal adapters, PCI bus callbacks pci_pm_*() will do all this for us. Now __e1000_shutdown() switches to D3-state only quad-port adapters, because they needs quirk for clearing false-positive error from downsteam pci-e port.
pci_save_state() now called after clearing bus-master bit, thus __e1000_resume() and e1000_io_slot_reset() must set it back after restoring configuration space.
This patch set get_link_status before calling pm_runtime_put() in e1000_open() to allow e1000_idle() get real link status and schedule first runtime suspend.
This patch also enables wakeup for device if management mode is enabled (like for WoL) as result pci_prepare_to_sleep() would setup wakeup without special actions like custom 'enable_wakeup' sign.
--- drivers/net/ethernet/intel/e1000e/netdev.c | 78 ++++++----------------------- 1 file changed, 18 insertions(+), 60 deletions(-)
drivers/net/ethernet/intel/e1000e/netdev.c +18 -60
@@ -3952,6 +3952,7 @@ static int e1000_open(struct net_devicenetif_start_queue (netdev); adapter->idle_check = true; + hw->mac.get_link_status = true;pm_runtime_put (&pdev->dev);/* fire a link status change interrupt to start the watchdog */
@@ -5450,8 +5451,7 @@ release:return retval; } -static int __e1000_shutdown (struct pci_dev *pdev,bool *enable_wake, -bool runtime) +static int __e1000_shutdown (struct pci_dev *pdev,bool runtime) {struct net_device *netdev =pci_get_drvdata (pdev);struct e1000_adapter *adapter =netdev_priv (netdev);
@@ -5475,10 +5475,6 @@ static int __e1000_shutdown(struct pci_d }e1000e_reset_interrupt_capability (adapter); - retval =pci_save_state (pdev); -if (retval) -return retval; - status =er32 (STATUS );if (status &E1000_STATUS_LU ) wufc &= ~E1000_WUFC_LNKC ;
@@ -5534,13 +5530,6 @@ static int __e1000_shutdown(struct pci_dew32 (WUFC ,0 ); } - *enable_wake = !!wufc; - -/* make sure adapter isn't asleep if manageability is enabled */ -if ((adapter->flags &FLAG_MNG_PT_ENABLED ) || - (hw->mac.ops.check_mng_mode (hw))) - *enable_wake = true; -if (adapter->hw.phy.type == e1000_phy_igp_3)e1000e_igp3_phy_powerdown_workaround_ich8lan (&adapter->hw);
@@ -5551,26 +5540,6 @@ static int __e1000_shutdown(struct pci_dpci_clear_master (pdev); -return 0 ; -} - -static void e1000_power_off (struct pci_dev *pdev,bool sleep,bool wake) -{ -if (sleep && wake) { -pci_prepare_to_sleep (pdev); -return ; - } - -pci_wake_from_d3 (pdev, wake); -pci_set_power_state (pdev, PCI_D3hot); -} - -static void e1000_complete_shutdown (struct pci_dev *pdev,bool sleep, -bool wake) -{ -struct net_device *netdev =pci_get_drvdata (pdev); -struct e1000_adapter *adapter =netdev_priv (netdev); -/* The pci-e switch on some quad port adapters will report a * correctable error when the MAC transitions from D0 to D3. To * prevent this we need to mask off the correctable errors on the
@@ -5584,12 +5553,13 @@ static void e1000_complete_shutdown(strupcie_capability_write_word (us_dev,PCI_EXP_DEVCTL , (devctl & ~PCI_EXP_DEVCTL_CERE )); -e1000_power_off (pdev, sleep, wake); +pci_save_state (pdev); +pci_prepare_to_sleep (pdev);pcie_capability_write_word (us_dev,PCI_EXP_DEVCTL , devctl); - }else { -e1000_power_off (pdev, sleep, wake); } + +return 0 ; }#ifdef CONFIG_PCIEASPM
@@ -5640,9 +5610,7 @@ static int __e1000_resume(struct pci_devif (aspm_disable_flag)e1000e_disable_aspm (pdev, aspm_disable_flag); -pci_set_power_state (pdev,PCI_D0 ); -pci_restore_state (pdev); -pci_save_state (pdev); +pci_set_master (pdev);e1000e_set_interrupt_capability (adapter);if (netif_running (netdev)) {
@@ -5708,14 +5676,8 @@ static int __e1000_resume(struct pci_devstatic int e1000_suspend (struct device *dev) {struct pci_dev *pdev =to_pci_dev (dev); -int retval; -bool wake; - - retval =__e1000_shutdown (pdev, &wake, false); -if (!retval) -e1000_complete_shutdown (pdev, true, wake); -return retval; +return __e1000_shutdown (pdev, false); }static int e1000_resume (struct device *dev)
@@ -5738,13 +5700,10 @@ static int e1000_runtime_suspend(structstruct net_device *netdev =pci_get_drvdata (pdev);struct e1000_adapter *adapter =netdev_priv (netdev); -if (e1000e_pm_ready (adapter)) { -bool wake; - -__e1000_shutdown (pdev, &wake, true); - } +if (!e1000e_pm_ready (adapter)) +return 0 ; -return 0 ; +return __e1000_shutdown (pdev, true); }static int e1000_idle (struct device *dev)
@@ -5782,12 +5741,7 @@ static int e1000_runtime_resume(struct dstatic void e1000_shutdown (struct pci_dev *pdev) { -bool wake = false; - -__e1000_shutdown (pdev, &wake, false); - -if (system_state ==SYSTEM_POWER_OFF ) -e1000_complete_shutdown (pdev, false, wake); +__e1000_shutdown (pdev, false); }#ifdef CONFIG_NET_POLL_CONTROLLER
@@ -5908,9 +5862,9 @@ static pci_ers_result_t e1000_io_slot_re "Cannot re-enable PCI device after reset.\n"); result =PCI_ERS_RESULT_DISCONNECT ; }else { -pci_set_master (pdev); pdev->state_saved = true;pci_restore_state (pdev); +pci_set_master (pdev);pci_enable_wake (pdev, PCI_D3hot,0 );pci_enable_wake (pdev, PCI_D3cold,0 );
@@ -6341,7 +6295,11 @@ static int e1000_probe(struct pci_dev *p/* initialize the wol settings based on the eeprom settings */ adapter->wol = adapter->eeprom_wol; -device_set_wakeup_enable (&adapter->pdev->dev, adapter->wol); + +/* make sure adapter isn't asleep if manageability is enabled */ +if (adapter->wol || (adapter->flags &FLAG_MNG_PT_ENABLED ) || + (hw->mac.ops.check_mng_mode (hw))) +device_wakeup_enable (&pdev->dev);/* save off EEPROM version number */ e1000_read_nvm (&adapter->hw,5 ,1 , &adapter->eeprom_vers);
Greg Kroah-Hartman
maintainerPATCH 15/73 e1000e: fix accessing to suspended device
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Konstantin Khlebnikov <[email protected]>
commit e60b22c5b7e59db09a7c9490b1e132c7e49ae904 upstream.
This patch fixes some annoying messages like 'Error reading PHY register' and 'Hardware Erorr' and saves several seconds on reboot.
--- drivers/net/ethernet/intel/e1000e/ethtool.c | 13 +++++++++++++ drivers/net/ethernet/intel/e1000e/netdev.c | 2 ++ 2 files changed, 15 insertions(+)
drivers/net/ethernet/intel/e1000e/ethtool.c +13 -0
@@ -35,6 +35,7 @@#include <linux/slab.h> #include <linux/delay.h> #include <linux/vmalloc.h> +#include <linux/pm_runtime.h> #include "e1000.h"
@@ -2053,7 +2054,19 @@ static int e1000_get_rxnfc(struct net_de } } +static int e1000e_ethtool_begin (struct net_device *netdev) +{ +return pm_runtime_get_sync (netdev->dev.parent); +} + +static void e1000e_ethtool_complete (struct net_device *netdev) +{ +pm_runtime_put_sync (netdev->dev.parent); +} +static const struct ethtool_ops e1000_ethtool_ops = { + .begin = e1000e_ethtool_begin, + .complete = e1000e_ethtool_complete, .get_settings = e1000_get_settings, .set_settings = e1000_set_settings, .get_drvinfo = e1000_get_drvinfo,
drivers/net/ethernet/intel/e1000e/netdev.c +2 -0
@@ -4313,6 +4313,7 @@ static void e1000_phy_read_status(struct (adapter->hw.phy.media_type == e1000_media_type_copper)) {int ret_val; +pm_runtime_get_sync (&adapter->pdev->dev); ret_val =e1e_rphy (hw,PHY_CONTROL , &phy->bmcr); ret_val |=e1e_rphy (hw,PHY_STATUS , &phy->bmsr); ret_val |=e1e_rphy (hw,PHY_AUTONEG_ADV , &phy->advertise);
@@ -4323,6 +4324,7 @@ static void e1000_phy_read_status(struct ret_val |=e1e_rphy (hw,PHY_EXT_STATUS , &phy->estatus);if (ret_val)e_warn ("Error reading PHY register\n" ); +pm_runtime_put_sync (&adapter->pdev->dev); }else {/* Do not read PHY registers if link is not up * Set values to typical power-on defaults
Greg Kroah-Hartman
maintainerPATCH 16/73 xhci: Dont warn on empty ring for suspended devices.
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Sarah Sharp <[email protected]>
commit a83d6755814e4614ba77e15d82796af0f695c6b8 upstream.
When a device attached to the roothub is suspended, the endpoint rings are stopped. The host may generate a completion event with the completion code set to 'Stopped' or 'Stopped Invalid' when the ring is halted. The current xHCI code prints a warning in that case, which can be really annoying if the USB device is coming into and out of suspend.
Remove the unnecessary warning.
--- drivers/usb/host/xhci-ring.c | 23 +++++++++++++++-------- 1 file changed, 15 insertions(+), 8 deletions(-)
drivers/usb/host/xhci-ring.c +15 -8
@@ -2461,14 +2461,21 @@ static int handle_tx_event(struct xhci_h* TD list. */ if (list_empty (&ep_ring->td_list)) { -xhci_warn (xhci,"WARN Event TRB for slot %d ep %d " -"with no TDs queued?\n" , -TRB_TO_SLOT_ID (le32_to_cpu (event->flags)), - ep_index); -xhci_dbg (xhci,"Event TRB with TRB type ID %u\n" , - (le32_to_cpu (event->flags) & -TRB_TYPE_BITMASK )>>10 ); -xhci_print_trb_offsets (xhci, (union xhci_trb *) event); +/* +* A stopped endpoint may generate an extra completion +* event if the device was suspended. Don't print +* warnings. +*/ +if (!(trb_comp_code ==COMP_STOP || + trb_comp_code ==COMP_STOP_INVAL )) { +xhci_warn (xhci,"WARN Event TRB for slot %d ep %d with no TDs queued?\n" , +TRB_TO_SLOT_ID (le32_to_cpu (event->flags)), + ep_index); +xhci_dbg (xhci,"Event TRB with TRB type ID %u\n" , + (le32_to_cpu (event->flags) & +TRB_TYPE_BITMASK )>>10 ); +xhci_print_trb_offsets (xhci, (union xhci_trb *) event); + }if (ep->skip) { ep->skip = false; xhci_dbg(xhci, "td_list is empty while skip "
Greg Kroah-Hartman
maintainerPATCH 17/73 ipvs: ip_vs_sip_fill_param() BUG: bad check of return value
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Hans Schillstrom <[email protected]>
commit f7a1dd6e3ad59f0cfd51da29dfdbfd54122c5916 upstream.
The reason for this patch is crash in kmemdup caused by returning from get_callid with uniialized matchoff and matchlen.
Removing Zero check of matchlen since it's done by ct_sip_get_header()
BUG: unable to handle kernel paging request at ffff880457b5763f IP: [<ffffffff810df7fc>] kmemdup+0x2e/0x35 PGD 27f6067 PUD 0 Oops: 0000 [#1] PREEMPT SMP Modules linked in: xt_state xt_helper nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_mangle xt_connmark xt_conntrack ip6_tables nf_conntrack_ftp ip_vs_ftp nf_nat xt_tcpudp iptable_mangle xt_mark ip_tables x_tables ip_vs_rr ip_vs_lblcr ip_vs_pe_sip ip_vs nf_conntrack_sip nf_conntrack bonding igb i2c_algo_bit i2c_core CPU 5 Pid: 0, comm: swapper/5 Not tainted 3.9.0-rc5+ #5 /S1200KP RIP: 0010:[<ffffffff810df7fc>] [<ffffffff810df7fc>] kmemdup+0x2e/0x35 RSP: 0018:ffff8803fea03648 EFLAGS: 00010282 RAX: ffff8803d61063e0 RBX: 0000000000000003 RCX: 0000000000000003 RDX: 0000000000000003 RSI: ffff880457b5763f RDI: ffff8803d61063e0 RBP: ffff8803fea03658 R08: 0000000000000008 R09: 0000000000000011 R10: 0000000000000011 R11: 00ffffffff81a8a3 R12: ffff880457b5763f R13: ffff8803d67f786a R14: ffff8803fea03730 R15: ffffffffa0098e90 FS: 0000000000000000(0000) GS:ffff8803fea00000(0000) knlGS:0000000000000000 CS: 0010 DS: 0000 ES: 0000 CR0: 0000000080050033 CR2: ffff880457b5763f CR3: 0000000001a0c000 CR4: 00000000001407e0 DR0: 0000000000000000 DR1: 0000000000000000 DR2: 0000000000000000 DR3: 0000000000000000 DR6: 00000000ffff0ff0 DR7: 0000000000000400 Process swapper/5 (pid: 0, threadinfo ffff8803ee18c000, task ffff8803ee18a480) Stack: ffff8803d822a080 000000000000001c ffff8803fea036c8 ffffffffa000937a ffffffff81f0d8a0 000000038135fdd5 ffff880300000014 ffff880300110000 ffffffff150118ac ffff8803d7e8a000 ffff88031e0118ac 0000000000000000 Call Trace: <IRQ> [<ffffffffa000937a>] ip_vs_sip_fill_param+0x13a/0x187 [ip_vs_pe_sip] [<ffffffffa007b209>] ip_vs_sched_persist+0x2c6/0x9c3 [ip_vs] [<ffffffff8107dc53>] ? __lock_acquire+0x677/0x1697 [<ffffffff8100972e>] ? native_sched_clock+0x3c/0x7d [<ffffffff8100972e>] ? native_sched_clock+0x3c/0x7d [<ffffffff810649bc>] ? sched_clock_cpu+0x43/0xcf [<ffffffffa007bb1e>] ip_vs_schedule+0x181/0x4ba [ip_vs]
...
--- net/netfilter/ipvs/ip_vs_pe_sip.c | 6 +----- 1 file changed, 1 insertion(+), 5 deletions(-)
net/netfilter/ipvs/ip_vs_pe_sip.c +1 -5
@@ -37,14 +37,10 @@ static int get_callid(const char *dptr,if (ret >0 )break ;if (!ret) -return 0 ; +return -EINVAL ; dataoff += *matchoff; } -/* Empty callid is useless */ -if (!*matchlen) -return -EINVAL ; -/* Too large is useless */ if (*matchlen >IP_VS_PEDATA_MAXLEN )return -EINVAL ;
Greg Kroah-Hartman
maintainerPATCH 18/73 netfilter: nf_nat: fix race when unloading protocol modules
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Florian Westphal <[email protected]>
commit c2d421e171868586939c328dfb91bab840fe4c49 upstream.
following oops was reported:
RIP: 0010:[<ffffffffa03227f2>] [<ffffffffa03227f2>] nf_nat_cleanup_conntrack+0x42/0x70 [nf_nat] RSP: 0018:ffff880202c63d40 EFLAGS: 00010246 RAX: 0000000000000000 RBX: ffff8801ac7bec28 RCX: ffff8801d0eedbe0 RDX: dead000000200200 RSI: 0000000000000011 RDI: ffffffffa03265b8 [..] Call Trace: [..] [<ffffffffa02febed>] destroy_conntrack+0xbd/0x110 [nf_conntrack]
Happens when a conntrack timeout expires right after first part of the nat cleanup has completed (bysrc hash removal), but before part 2 has completed (re-initialization of nat area).
[ destroy callback tries to delete bysrc again ]
Patrick suggested to just remove the affected conntracks -- the connections won't work properly anyway without nat transformation.
So, lets do that.
--- net/netfilter/nf_nat_core.c | 40 +++++++--------------------------------- 1 file changed, 7 insertions(+), 33 deletions(-)
net/netfilter/nf_nat_core.c +7 -33
@@ -468,33 +468,22 @@ EXPORT_SYMBOL_GPL(nf_nat_packet);struct nf_nat_proto_clean {u8 l3proto;u8 l4proto; -bool hash; }; -/* Clear NAT section of all conntracks, in case we're loaded again. */ -static int nf_nat_proto_clean (struct nf_conn *i,void *data) +/* kill conntracks with affected NAT section */ +static int nf_nat_proto_remove (struct nf_conn *i,void *data) {const struct nf_nat_proto_clean *clean = data;struct nf_conn_nat *nat =nfct_nat (i);if (!nat)return 0 ; -if (!(i->status &IPS_SRC_NAT_DONE )) -return 0 ; +if ((clean->l3proto &&nf_ct_l3num (i) != clean->l3proto) || (clean->l4proto &&nf_ct_protonum (i) != clean->l4proto))return 0 ; -if (clean->hash) { -spin_lock_bh (&nf_nat_lock); -hlist_del_rcu (&nat->bysource); -spin_unlock_bh (&nf_nat_lock); - }else { -memset (nat,0 ,sizeof (*nat)); - i->status &= ~(IPS_NAT_MASK |IPS_NAT_DONE_MASK | -IPS_SEQ_ADJUST ); - } -return 0 ; +return i->status &IPS_NAT_MASK ?1 :0 ; }static void nf_nat_l4proto_clean (u8 l3proto,u8 l4proto)
@@ -506,16 +495,8 @@ static void nf_nat_l4proto_clean(u8 l3prstruct net *net;rtnl_lock (); -/* Step 1 - remove from bysource hash */ - clean.hash = true;for_each_net (net) -nf_ct_iterate_cleanup (net, nf_nat_proto_clean, &clean); -synchronize_rcu (); - -/* Step 2 - clean NAT section */ - clean.hash = false; -for_each_net (net) -nf_ct_iterate_cleanup (net, nf_nat_proto_clean, &clean); +nf_ct_iterate_cleanup (net, nf_nat_proto_remove, &clean);rtnl_unlock (); }
@@ -527,16 +508,9 @@ static void nf_nat_l3proto_clean(u8 l3prstruct net *net;rtnl_lock (); -/* Step 1 - remove from bysource hash */ - clean.hash = true; -for_each_net (net) -nf_ct_iterate_cleanup (net, nf_nat_proto_clean, &clean); -synchronize_rcu (); -/* Step 2 - clean NAT section */ - clean.hash = false;for_each_net (net) -nf_ct_iterate_cleanup (net, nf_nat_proto_clean, &clean); +nf_ct_iterate_cleanup (net, nf_nat_proto_remove, &clean);rtnl_unlock (); }
@@ -774,7 +748,7 @@ static void __net_exit nf_nat_net_exit(s {struct nf_nat_proto_clean clean = {}; -nf_ct_iterate_cleanup (net, &nf_nat_proto_clean, &clean); +nf_ct_iterate_cleanup (net, &nf_nat_proto_remove, &clean);synchronize_rcu ();nf_ct_free_hashtable (net->ct.nat_bysource, net->ct.nat_htable_size); }
Greg Kroah-Hartman
maintainerPATCH 19/73 netfilter: ipset: list:set: fix reference counter update
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jozsef Kadlecsik <[email protected]>
commit 02f815cb6d3f57914228be84df9613ee5a01c2e6 upstream.
The last element can be replaced or pushed off and in both cases the reference counter must be updated.
--- net/netfilter/ipset/ip_set_list_set.c | 10 +++++++--- 1 file changed, 7 insertions(+), 3 deletions(-)
net/netfilter/ipset/ip_set_list_set.c +7 -3
@@ -174,9 +174,13 @@ list_set_add(struct list_set *map, u32 i {const struct set_elem *e =list_set_elem (map, i); -if (i == map->size -1 && e->id !=IPSET_INVALID_ID ) -/* Last element replaced: e.g. add new,before,last */ -ip_set_put_byindex (e->id); +if (e->id !=IPSET_INVALID_ID ) { +const struct set_elem *x =list_set_elem (map, map->size -1 ); + +/* Last element replaced or pushed off */ +if (x->id !=IPSET_INVALID_ID ) +ip_set_put_byindex (x->id); + }if (with_timeout (map->timeout))list_elem_tadd (map, i, id,ip_set_timeout_set (timeout));else
Greg Kroah-Hartman
maintainerPATCH 20/73 netfilter: nf_ct_sip: dont drop packets with offsets pointing outside the packet
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Patrick McHardy <[email protected]>
commit 3a7b21eaf4fb3c971bdb47a98f570550ddfe4471 upstream.
Some Cisco phones create huge messages that are spread over multiple packets. After calculating the offset of the SIP body, it is validated to be within the packet and the packet is dropped otherwise. This breaks operation of these phones. Since connection tracking is supposed to be passive, just let those packets pass unmodified and untracked.
--- net/netfilter/nf_conntrack_sip.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/netfilter/nf_conntrack_sip.c +1 -1
@@ -1547,7 +1547,7 @@ static int sip_help_tcp(struct sk_buff * msglen = origlen = end - dptr;if (msglen > datalen) -return NF_DROP ; +return NF_ACCEPT ; ret =process_sip_msg (skb, ct, protoff, dataoff, &dptr, &msglen);
Greg Kroah-Hartman
maintainerPATCH 21/73 netfilter: ipset: "Directory not empty" error message
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jozsef Kadlecsik <[email protected]>
commit dd82088dab3646ed28e4aa43d1a5b5d5ffc2afba upstream.
When an entry flagged with "nomatch" was tested by ipset, it returned the error message "Kernel error received:
Directory not empty" instead of "<element> is NOT in set <setname>" (reported by John Brendler).
The internal error code was not properly transformed before returning to userspace, fixed.
--- net/netfilter/ipset/ip_set_core.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
net/netfilter/ipset/ip_set_core.c +2 -1
@@ -1470,7 +1470,8 @@ ip_set_utest(struct sock *ctnl, struct sif (ret == -EAGAIN ) ret =1 ; -return ret <0 ? ret : ret >0 ?0 : -IPSET_ERR_EXIST ; +return (ret <0 && ret != -ENOTEMPTY ) ? ret : + ret >0 ?0 : -IPSET_ERR_EXIST ; }/* Get headed data of a set */
Greg Kroah-Hartman
maintainerPATCH 22/73 netfilter: nf_ct_helper: dont discard helper if it is actually the same
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Florian Westphal <[email protected]>
commit 6e2f0aa8cf8892868bf2c19349cb5d7c407f690d upstream.
commit (32f5376 netfilter: nf_ct_helper: disable automatic helper re-assignment of different type) broke transparent proxy scenarios.
For example, initial helper lookup might yield "ftp" (dport 21), while re-lookup after REDIRECT yields "ftp-2121".
This causes the autoassign code to toss the ftp helper, even though these are just different instances of the same helper.
Change the test to check for the helper function address instead of the helper address, as suggested by Pablo.
--- net/netfilter/nf_conntrack_helper.c | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-)
net/netfilter/nf_conntrack_helper.c +3 -1
@@ -236,7 +236,9 @@ int __nf_ct_try_assign_helper(struct nf_/* We only allow helper re-assignment of the same sort since * we cannot reallocate the helper extension area. */ -if (help->helper != helper) { +struct nf_conntrack_helper *tmp =rcu_dereference (help->helper); + +if (tmp && tmp->help != helper->help) {RCU_INIT_POINTER (help->helper,NULL ); goto out; }
Greg Kroah-Hartman
maintainerPATCH 23/73 netfilter: ctnetlink: dont permit ct creation with random tuple
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Florian Westphal <[email protected]>
commit 442fad9423b78319e0019a7f5047eddf3317afbc upstream.
Userspace can cause kernel panic by not specifying orig/reply
tuple: kernel will create a tuple with random stack values.
Problem is that tuple.dst.dir will be random, too, which causes nf_ct_tuplehash_to_ctrack() to return garbage.
--- net/netfilter/nf_conntrack_netlink.c | 3 +++ 1 file changed, 3 insertions(+)
net/netfilter/nf_conntrack_netlink.c +3 -0
@@ -1705,6 +1705,9 @@ ctnetlink_new_conntrack(struct sock *ctnif (nlh->nlmsg_flags &NLM_F_CREATE ) {enum ip_conntrack_events events; +if (!cda[CTA_TUPLE_ORIG ] || !cda[CTA_TUPLE_REPLY ]) +return -EINVAL ; + ct =ctnetlink_create_conntrack (net, zone, cda, &otuple, &rtuple, u3);if (IS_ERR (ct))
Greg Kroah-Hartman
maintainerPATCH 24/73 netfilter: xt_rpfilter: skip locally generated broadcast/multicast, too
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Florian Westphal <[email protected]>
commit f83a7ea2075ca896f2dbf07672bac9cf3682ff74 upstream.
Alex Efros reported rpfilter module doesn't match following packets:
IN=br.qemu SRC=192.168.2.1 DST=192.168.2.255 [ .. ] (netfilter bugzilla #814).
Problem is that network stack arranges for the locally generated broadcasts to appear on the interface they were sent out, so the IFF_LOOPBACK check doesn't trigger.
As -m rpfilter is restricted to PREROUTING, we can check for existing rtable instead, it catches locally-generated broad/multicast case, too.
--- net/ipv4/netfilter/ipt_rpfilter.c | 8 +++++++- net/ipv6/netfilter/ip6t_rpfilter.c | 8 +++++++- 2 files changed, 14 insertions(+), 2 deletions(-)
net/ipv4/netfilter/ipt_rpfilter.c +7 -1
@@ -66,6 +66,12 @@ static bool rpfilter_lookup_reverse(strureturn dev_match; } +static bool rpfilter_is_local (const struct sk_buff *skb) +{ +const struct rtable *rt =skb_rtable (skb); +return rt && (rt->rt_flags &RTCF_LOCAL ); +} +static bool rpfilter_mt (const struct sk_buff *skb,struct xt_action_param *par) {const struct xt_rpfilter_info *info;
@@ -76,7 +82,7 @@ static bool rpfilter_mt(const struct sk_ info = par->matchinfo; invert = info->flags &XT_RPFILTER_INVERT ; -if (par->in->flags &IFF_LOOPBACK ) +if (rpfilter_is_local (skb))return true ^ invert; iph =ip_hdr (skb);
net/ipv6/netfilter/ip6t_rpfilter.c +7 -1
@@ -71,6 +71,12 @@ static bool rpfilter_lookup_reverse6(conreturn ret; } +static bool rpfilter_is_local (const struct sk_buff *skb) +{ +const struct rt6_info *rt = (const void *)skb_dst (skb); +return rt && (rt->rt6i_flags &RTF_LOCAL ); +} +static bool rpfilter_mt (const struct sk_buff *skb,struct xt_action_param *par) {const struct xt_rpfilter_info *info = par->matchinfo;
@@ -78,7 +84,7 @@ static bool rpfilter_mt(const struct sk_struct ipv6hdr *iph;bool invert = info->flags &XT_RPFILTER_INVERT ; -if (par->in->flags &IFF_LOOPBACK ) +if (rpfilter_is_local (skb))return true ^ invert; iph =ipv6_hdr (skb);
Greg Kroah-Hartman
maintainerPATCH 25/73 netfilter: ip6t_NPT: Fix translation for non-multiple of 32 prefix lengths
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Matthias Schiffer <[email protected]>
commit 906b1c394d0906a154fbdc904ca506bceb515756 upstream.
The bitmask used for the prefix mangling was being calculated incorrectly, leading to the wrong part of the address being replaced when the prefix length wasn't a multiple of 32.
--- net/ipv6/netfilter/ip6t_NPT.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
net/ipv6/netfilter/ip6t_NPT.c +1 -1
@@ -57,7 +57,7 @@ static bool ip6t_npt_map_pfx(const strucif (pfx_len - i >=32 ) mask =0 ;else - mask =htonl (~((1 << (pfx_len - i)) -1 )); + mask =htonl ((1 << (i - pfx_len +32 )) -1 ); idx = i /32 ; addr->s6_addr32[idx] &= mask;
Greg Kroah-Hartman
maintainerPATCH 26/73 ext4: add check for inodes_count overflow in new resize ioctl
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Theodore Ts'o <[email protected]>
commit 3f8a6411fbada1fa482276591e037f3b1adcf55b upstream.
Addresses-Red-Hat-Bugzilla: #913245
--- fs/ext4/resize.c | 4 ++++ 1 file changed, 4 insertions(+)
fs/ext4/resize.c +4 -0
@@ -1880,6 +1880,10 @@ retry:return 0 ;ext4_get_group_no_and_offset (sb, n_blocks_count -1 , &n_group, &offset); +if (n_group > (0xFFFFFFFFUL /EXT4_INODES_PER_GROUP (sb))) { +ext4_warning (sb,"resize would cause inodes_count overflow" ); +return -EINVAL ; + }ext4_get_group_no_and_offset (sb, o_blocks_count -1 , &o_group, &offset); n_desc_blocks =num_desc_blocks (sb, n_group +1 );
Greg Kroah-Hartman
maintainerPATCH 27/73 r8169: fix 8168evl frame padding.
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Stefan Bader <[email protected]>
commit e5195c1f31f399289347e043d6abf3ffa80f0005 upstream.
--- drivers/net/ethernet/realtek/r8169.c | 9 +++++++++ 1 file changed, 9 insertions(+)
drivers/net/ethernet/realtek/r8169.c +9 -0
@@ -5779,6 +5779,14 @@ static netdev_tx_t rtl8169_start_xmit(st goto err_stop_0; } +/* 8168evl does not automatically pad to minimum length. */ +if (unlikely (tp->mac_version ==RTL_GIGA_MAC_VER_34 && + skb->len <ETH_ZLEN )) { +if (skb_padto (skb,ETH_ZLEN )) + goto err_update_stats; +skb_put (skb,ETH_ZLEN - skb->len); + } +if (unlikely (le32_to_cpu (txd->opts1) & DescOwn)) goto err_stop_0;
@@ -5850,6 +5858,7 @@ err_dma_1:rtl8169_unmap_tx_skb (d, tp->tx_skb + entry, txd); err_dma_0:dev_kfree_skb (skb); +err_update_stats: dev->stats.tx_dropped++;return NETDEV_TX_OK ;
Greg Kroah-Hartman
maintainerPATCH 28/73 RDMA/cxgb4: Fix SQ allocation when on-chip SQ is disabled
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Thadeu Lima de Souza Cascardo <[email protected]>
commit 5b0c275926b8149c555da874bb4ec258ea3292aa upstream.
Commit c079c28714e4 ("RDMA/cxgb4: Fix error handling in create_qp()") broke SQ allocation. Instead of falling back to host allocation when on-chip allocation fails, it tries to allocate both. And when it does, and we try to free the address from the genpool using the host address, we hit a BUG and the system crashes as below.
We create a new function that has the previous behavior and properly propagate the error, as intended.
kernel BUG at /usr/src/packages/BUILD/kernel-ppc64-3.0.68/linux-3.0/lib/genalloc.c:340!
Oops: Exception in kernel mode, sig: 5 [#1]
SMP NR_CPUS=1024 NUMA pSeries
Modules linked in: rdma_ucm rdma_cm ib_addr ib_cm iw_cm ib_sa ib_mad ib_uverbs iw_cxgb4 ib_core ip6t_LOG xt_tcpudp xt_pkttype ipt_LOG xt_limit ip6t_REJECT nf_conntrack_ipv6 nf_defrag_ipv6 ip6table_raw xt_NOTRACK ipt_REJECT xt_state iptable_raw iptable_filter ip6table_mangle nf_conntrack_netbios_ns nf_conntrack_broadcast nf_conntrack_ipv4 nf_conntrack nf_defrag_ipv4 ip_tables ip6table_filter ip6_tables x_tables fuse loop dm_mod ipv6 ipv6_lib sr_mod cdrom ibmveth(X) cxgb4 sg ext3 jbd mbcache sd_mod crc_t10dif scsi_dh_emc scsi_dh_hp_sw scsi_dh_alua scsi_dh_rdac scsi_dh ibmvscsic(X) scsi_transport_srp scsi_tgt scsi_mod
Supported: Yes
NIP: c00000000037d41c LR: d000000003913824 CTR: c00000000037d3b0
REGS: c0000001f350ae50 TRAP: 0700 Tainted: G X (3.0.68-0.9-ppc64)
MSR: 8000000000029032 <EE,ME,CE,IR,DR> CR: 24042482 XER: 00000001
TASK = c0000001f6f2a840[3616] 'rping' THREAD: c0000001f3508000 CPU: 0
GPR00: c0000001f6e875c8 c0000001f350b0d0 c000000000fc9690 c0000001f6e875c0
GPR04: 00000000000c0000 0000000000010000 0000000000000000 c0000000009d482a
GPR08: 000000006a170000 0000000000100000 c0000001f350b140 c0000001f6e875c8
GPR12: d000000003915dd0 c000000003f40000 000000003e3ecfa8 c0000001f350bea0
GPR16: c0000001f350bcd0 00000000003c0000 0000000000040100 c0000001f6e74a80
GPR20: d00000000399a898 c0000001f6e74ac8 c0000001fad91600 c0000001f6e74ab0
GPR24: c0000001f7d23f80 0000000000000000 0000000000000002 000000006a170000
GPR28: 000000000000000c c0000001f584c8d0 d000000003925180 c0000001f6e875c8
NIP [c00000000037d41c] .gen_pool_free+0x6c/0xf8
LR [d000000003913824] .c4iw_ocqp_pool_free+0x8c/0xd8 [iw_cxgb4]
Call Trace:
[c0000001f350b0d0] [c0000001f350b180] 0xc0000001f350b180 (unreliable)
[c0000001f350b170] [d000000003913824] .c4iw_ocqp_pool_free+0x8c/0xd8 [iw_cxgb4]
[c0000001f350b210] [d00000000390fd70] .dealloc_sq+0x90/0xb0 [iw_cxgb4]
[c0000001f350b280] [d00000000390fe08] .destroy_qp+0x78/0xf8 [iw_cxgb4]
[c0000001f350b310] [d000000003912738] .c4iw_destroy_qp+0x208/0x2d0 [iw_cxgb4]
[c0000001f350b460] [d000000003861874] .ib_destroy_qp+0x5c/0x130 [ib_core]
[c0000001f350b510] [d0000000039911bc] .ib_uverbs_cleanup_ucontext+0x174/0x4f8 [ib_uverbs]
[c0000001f350b5f0] [d000000003991568] .ib_uverbs_close+0x28/0x70 [ib_uverbs]
[c0000001f350b670] [c0000000001e7b2c] .__fput+0xdc/0x278
[c0000001f350b720] [c0000000001a9590] .remove_vma+0x68/0xd8
[c0000001f350b7b0] [c0000000001a9720] .exit_mmap+0x120/0x160
[c0000001f350b8d0] [c0000000000af330] .mmput+0x80/0x160
[c0000001f350b960] [c0000000000b5d0c] .exit_mm+0x1ac/0x1e8
[c0000001f350ba10] [c0000000000b8154] .do_exit+0x1b4/0x4b8
[c0000001f350bad0] [c0000000000b84b0] .do_group_exit+0x58/0xf8
[c0000001f350bb60] [c0000000000ce9f4] .get_signal_to_deliver+0x2f4/0x5d0
[c0000001f350bc60] [c000000000017ee4] .do_signal_pending+0x6c/0x3e0
[c0000001f350bdb0] [c0000000000182cc] .do_signal+0x74/0x78
[c0000001f350be30] [c000000000009e74] do_work+0x24/0x28--- drivers/infiniband/hw/cxgb4/qp.c | 25 +++++++++++++------------ 1 file changed, 13 insertions(+), 12 deletions(-)
drivers/infiniband/hw/cxgb4/qp.c +13 -12
@@ -100,6 +100,16 @@ static int alloc_host_sq(struct c4iw_rdereturn 0 ; } +static int alloc_sq (struct c4iw_rdev *rdev,struct t4_sq *sq,int user) +{ +int ret = -ENOSYS ; +if (user) + ret =alloc_oc_sq (rdev, sq); +if (ret) + ret =alloc_host_sq (rdev, sq); +return ret; +} +static int destroy_qp (struct c4iw_rdev *rdev,struct t4_wq *wq,struct c4iw_dev_ucontext *uctx) {
@@ -168,18 +178,9 @@ static int create_qp(struct c4iw_rdev *r goto free_sw_rq; } -if (user) { - ret =alloc_oc_sq (rdev, &wq->sq); -if (ret) - goto free_hwaddr; - - ret =alloc_host_sq (rdev, &wq->sq); -if (ret) - goto free_sq; - }else - ret =alloc_host_sq (rdev, &wq->sq); -if (ret) - goto free_hwaddr; + ret =alloc_sq (rdev, &wq->sq, user); +if (ret) + goto free_hwaddr;memset (wq->sq.queue,0 , wq->sq.memsize);dma_unmap_addr_set (&wq->sq, mapping, wq->sq.dma_addr);
Greg Kroah-Hartman
maintainerPATCH 29/73 arm64: Ignore the write ESR flag on cache maintenance faults
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Catalin Marinas <[email protected]>
commit 0e7f7bcc3fc87489cda5aa6aff8ce40eed912279 upstream.
ESR.WnR bit is always set on data cache maintenance faults even though the page is not required to have write permission. If a translation fault (page not yet mapped) happens for read-only user address range, Linux incorrectly assumes a permission fault. This patch adds the check of the ESR.CM bit during the page fault handling to ignore the 'write' flag.
--- arch/arm64/mm/fault.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
arch/arm64/mm/fault.c +2 -1
@@ -148,6 +148,7 @@ void do_bad_area(unsigned long addr, uns#define VM_FAULT_BADACCESS 0x020000#define ESR_WRITE (1 << 6) +#define ESR_CM (1 << 8)#define ESR_LNX_EXEC (1 << 24)/*
@@ -206,7 +207,7 @@ static int __kprobes do_page_fault(unsigstruct task_struct *tsk;struct mm_struct *mm;int fault, sig, code; -int write = esr &ESR_WRITE ; +bool write = (esr &ESR_WRITE ) && !(esr &ESR_CM );unsigned int flags =FAULT_FLAG_ALLOW_RETRY |FAULT_FLAG_KILLABLE | (write ?FAULT_FLAG_WRITE :0 );
Greg Kroah-Hartman
maintainerPATCH 30/73 block: fix max discard sectors limit
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: James Bottomley <[email protected]>
commit 871dd9286e25330c8a581e5dacfa8b1dfe1dd641 upstream.
linux-v3.8-rc1 and later support for plug for blkdev_issue_discard with commit 0cfbcafcae8b7364b5fa96c2b26ccde7a3a296a9
(block: add plug for blkdev_issue_discard )
For example,
1) DISCARD rq-1 with size size 4GB
2) DISCARD rq-2 with size size 1GB
If these 2 discard requests get merged, final request size will be 5GB.
In this case, request's __data_len field may overflow as it can store max 4GB(unsigned int).
This issue was observed while doing mkfs.f2fs on 5GB SD card:
https://lkml.org/lkml/2013/4/1/292
Info: sector size = 512
Info: total sectors = 11370496 (in 512bytes)
Info: zone aligned segment0 blkaddr: 512
[ 257.789764] blk_update_request: bio idx 0 >= vcnt 0
mkfs process gets stuck in D state and I see the following in the dmesg:
[ 257.789733] __end_that: dev mmcblk0: type=1, flags=122c8081 [ 257.789764] sector 4194304, nr/cnr 2981888/4294959104 [ 257.789764] bio df3840c0, biotail df3848c0, buffer (null), len 1526726656 [ 257.789764] blk_update_request: bio idx 0 >= vcnt 0 [ 257.794921] request botched: dev mmcblk0: type=1, flags=122c8081 [ 257.794921] sector 4194304, nr/cnr 2981888/4294959104 [ 257.794921] bio df3840c0, biotail df3848c0, buffer (null), len
1526726656
This patch fixes this issue.
--- include/linux/blkdev.h | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
include/linux/blkdev.h +1 -1
@@ -836,7 +836,7 @@ static inline unsigned int blk_queue_get unsigned int cmd_flags) {if (unlikely (cmd_flags &REQ_DISCARD )) -return q->limits.max_discard_sectors; +return min (q->limits.max_discard_sectors,UINT_MAX >>9 );if (unlikely (cmd_flags &REQ_WRITE_SAME ))return q->limits.max_write_same_sectors;
Greg Kroah-Hartman
maintainerPATCH 31/73 drm/cirrus: deal with bo reserve fail in dirty update path
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dave Airlie <[email protected]>
commit f3b2bbdc8a87a080ccd23d27fca4b87d61340dd4 upstream.
Port over the mgag200 fix to cirrus as it suffers the same issue.
On F19 testing, it was noticed we get a lot of errors in dmesg about being unable to reserve the buffer when plymouth starts, this is due to the buffer being in the process of migrating, so it makes sense we can't reserve it.
In order to deal with it, this adds delayed updates for the dirty updates, when the bo is unreservable, in the normal console case this shouldn't ever happen, its just when plymouth or X is pushing the console bo to system memory.
--- drivers/gpu/drm/cirrus/cirrus_drv.h | 2 + drivers/gpu/drm/cirrus/cirrus_fbdev.c | 38 +++++++++++++++++++++++++++++++++- drivers/gpu/drm/cirrus/cirrus_ttm.c | 2 - 3 files changed, 40 insertions(+), 2 deletions(-)
drivers/gpu/drm/cirrus/cirrus_drv.h +2 -0
@@ -154,6 +154,8 @@ struct cirrus_fbdev {struct list_head fbdev_list;void *sysram;int size; +int x1, y1, x2, y2;/* dirty rect */ +spinlock_t dirty_lock; };struct cirrus_bo {
drivers/gpu/drm/cirrus/cirrus_fbdev.c +37 -1
@@ -26,16 +26,51 @@ static void cirrus_dirty_update(struct cint bpp = (afbdev->gfb.base.bits_per_pixel +7 )/8 ;int ret;bool unmap = false; +bool store_for_later = false; +int x2, y2; +unsigned long flags; obj = afbdev->gfb.obj; bo =gem_to_cirrus_bo (obj); +/* +* try and reserve the BO, if we fail with busy +* then the BO is being moved and we should +* store up the damage until later. +*/ ret =cirrus_bo_reserve (bo, true);if (ret) { -DRM_ERROR ("failed to reserve fb bo\n" ); +if (ret != -EBUSY ) +return ; + store_for_later = true; + } + + x2 = x + width -1 ; + y2 = y + height -1 ; +spin_lock_irqsave (&afbdev->dirty_lock, flags); + +if (afbdev->y1 < y) + y = afbdev->y1; +if (afbdev->y2 > y2) + y2 = afbdev->y2; +if (afbdev->x1 < x) + x = afbdev->x1; +if (afbdev->x2 > x2) + x2 = afbdev->x2; + +if (store_for_later) { + afbdev->x1 = x; + afbdev->x2 = x2; + afbdev->y1 = y; + afbdev->y2 = y2; +spin_unlock_irqrestore (&afbdev->dirty_lock, flags);return ; } + afbdev->x1 = afbdev->y1 =INT_MAX ; + afbdev->x2 = afbdev->y2 =0 ; +spin_unlock_irqrestore (&afbdev->dirty_lock, flags); +if (!bo->kmap.virtual) { ret =ttm_bo_kmap (&bo->bo,0 , bo->bo.num_pages, &bo->kmap);if (ret) {
@@ -282,6 +317,7 @@ int cirrus_fbdev_init(struct cirrus_devi cdev->mode_info.gfbdev = gfbdev; gfbdev->helper.funcs = &cirrus_fb_helper_funcs; +spin_lock_init (&gfbdev->dirty_lock); ret =drm_fb_helper_init (cdev->dev, &gfbdev->helper, cdev->num_crtc,CIRRUSFB_CONN_LIMIT );
drivers/gpu/drm/cirrus/cirrus_ttm.c +1 -1
@@ -321,7 +321,7 @@ int cirrus_bo_reserve(struct cirrus_bo * ret =ttm_bo_reserve (&bo->bo, true, no_wait, false,0 );if (ret) { -if (ret != -ERESTARTSYS ) +if (ret != -ERESTARTSYS && ret != -EBUSY )DRM_ERROR ("reserve failed %p\n" , bo);return ret; }
Greg Kroah-Hartman
maintainerPATCH 32/73 drm/mgag200: deal with bo reserve fail in dirty update path
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dave Airlie <[email protected]>
commit 641719599528d806e00de8ae8c8453361266a312 upstream.
On F19 testing, it was noticed we get a lot of errors in dmesg about being unable to reserve the buffer when plymouth starts, this is due to the buffer being in the process of migrating, so it makes sense we can't reserve it.
In order to deal with it, this adds delayed updates for the dirty updates, when the bo is unreservable, in the normal console case this shouldn't ever happen, its just when plymouth or X is pushing the console bo to system memory.
--- drivers/gpu/drm/mgag200/mgag200_drv.h | 2 + drivers/gpu/drm/mgag200/mgag200_fb.c | 43 +++++++++++++++++++++++++++++++--- drivers/gpu/drm/mgag200/mgag200_ttm.c | 4 +-- 3 files changed, 44 insertions(+), 5 deletions(-)
drivers/gpu/drm/mgag200/mgag200_drv.h +2 -0
@@ -116,6 +116,8 @@ struct mga_fbdev {void *sysram;int size;struct ttm_bo_kmap_obj mapping; +int x1, y1, x2, y2;/* dirty rect */ +spinlock_t dirty_lock; };struct mga_crtc {
drivers/gpu/drm/mgag200/mgag200_fb.c +40 -3
72 lines not on this page · raw message
drivers/gpu/drm/mgag200/mgag200_ttm.c +2 -2
@@ -315,8 +315,8 @@ int mgag200_bo_reserve(struct mgag200_bo ret =ttm_bo_reserve (&bo->bo, true, no_wait, false,0 );if (ret) { -if (ret != -ERESTARTSYS ) -DRM_ERROR ("reserve failed %p\n" , bo); +if (ret != -ERESTARTSYS && ret != -EBUSY ) +DRM_ERROR ("reserve failed %p %d\n" , bo, ret);return ret; }return 0 ;
Greg Kroah-Hartman
maintainerPATCH 33/73 drm/gma500: fix backlight hotkeys behaviour on netbooks
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Anisse Astier <[email protected]>
commit e127dc28cc3057575da0216cde85687153ca180f upstream.
Backlight hotkeys weren't working before on certain cedartrail laptops.
The source of this problem is that the hotkeys' ASLE opregion interrupts were simply ignored. Driver seemed to expect the interrupt to be associated with a pipe, but it wasn't.
Accepting the ASLE interrupt without an associated pipe event flag fixes the issue, the backlight code is called when needed, making the brightness keys work properly.
[patrik: This patch affects irq handling on any netbook with opregion support]
Bugzilla: https://bugzilla.redhat.com/show_bug.cgi?id=833597
Reference: http://lists.freedesktop.org/archives/dri-devel/2012-July/025279.html
--- drivers/gpu/drm/gma500/psb_irq.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/gma500/psb_irq.c +1 -1
@@ -211,7 +211,7 @@ irqreturn_t psb_irq_handler(DRM_IRQ_ARGS vdc_stat =PSB_RVDC32 (PSB_INT_IDENTITY_R ); -if (vdc_stat & _PSB_PIPE_EVENT_FLAG) +if (vdc_stat & (_PSB_PIPE_EVENT_FLAG|_PSB_IRQ_ASLE)) dsp_int =1 ;/* FIXME: Handle Medfield
Greg Kroah-Hartman
maintainerPATCH 34/73 drm/prime: keep a reference from the handle to exported dma-buf (v6)
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dave Airlie <[email protected]>
commit 219b47339ced80ca580bb6ce7d1636166984afa7 upstream.
Currently we have a problem with this:
1. i915: create gem object
2. i915: export gem object to prime
3. radeon: import gem object
4. close prime fd
5. radeon: unref object
6. i915: unref object
i915 has an imported object reference in its file priv, that isn't cleaned up properly until fd close. The reference gets added at step 2, but at step 6 we don't have enough info to clean it up.
The solution is to take a reference on the dma-buf when we export it, and drop the reference when the gem handle goes away.
So when we export a dma_buf from a gem object, we keep track of it with the handle, we take a reference to the dma_buf. When we close the handle (i.e. userspace is finished with the buffer), we drop the reference to the dma_buf, and it gets collected.
This patch isn't meant to fix any other problem or bikesheds, and it doesn't fix any races with other scenarios.
v1.1: move export symbol line back up.
v2: okay I had to do a bit more, as the first patch showed a leak on one of my tests, that I found using the dma-buf debugfs support, the problem case is exporting a buffer twice with the same handle, we'd add another export handle for it unnecessarily, however
we now fail if we try to export the same object with a different gem handle, however I'm not sure if that is a case I want to support, and I've gotten the code to WARN_ON if we hit something like that.
v2.1: rebase this patch, write better commit msg.
v3: cleanup error handling, track import vs export in linked list, these two patches were separate previously, but seem to work better like this.
v4: danvet is correct, this code is no longer useful, since the buffer better exist, so remove it.
v5: always take a reference to the dma buf object, import or export. (Imre Deak contributed this originally)
v6: square the circle, remove import vs export tracking now that there is no difference
--- drivers/gpu/drm/drm_gem.c | 4 +- drivers/gpu/drm/drm_prime.c | 76 +++++++++++++++++++++++--------------------- include/drm/drmP.h | 5 +- 3 files changed, 44 insertions(+), 41 deletions(-)
drivers/gpu/drm/drm_gem.c +2 -2
@@ -205,11 +205,11 @@ static void drm_gem_remove_prime_handles(struct drm_gem_object *obj, struct drm_file *filp) {if (obj->import_attach) { -drm_prime_remove_imported_buf_handle (&filp->prime, +drm_prime_remove_buf_handle (&filp->prime, obj->import_attach->dmabuf); }if (obj->export_dma_buf) { -drm_prime_remove_imported_buf_handle (&filp->prime, +drm_prime_remove_buf_handle (&filp->prime, obj->export_dma_buf); } }
drivers/gpu/drm/drm_prime.c +40 -36
150 lines not on this page · raw message
include/drm/drmP.h +2 -3
@@ -1559,9 +1559,8 @@ extern void drm_prime_gem_destroy(structvoid drm_prime_init_file_private (struct drm_prime_file_private *prime_fpriv);void drm_prime_destroy_file_private (struct drm_prime_file_private *prime_fpriv); -int drm_prime_add_imported_buf_handle (struct drm_prime_file_private *prime_fpriv,struct dma_buf *dma_buf,uint32_t handle); -int drm_prime_lookup_imported_buf_handle (struct drm_prime_file_private *prime_fpriv,struct dma_buf *dma_buf,uint32_t *handle); -void drm_prime_remove_imported_buf_handle (struct drm_prime_file_private *prime_fpriv,struct dma_buf *dma_buf); +int drm_prime_lookup_buf_handle (struct drm_prime_file_private *prime_fpriv,struct dma_buf *dma_buf,uint32_t *handle); +void drm_prime_remove_buf_handle (struct drm_prime_file_private *prime_fpriv,struct dma_buf *dma_buf);int drm_prime_add_dma_buf (struct drm_device *dev,struct drm_gem_object *obj); int drm_prime_lookup_obj(struct drm_device *dev, struct dma_buf *buf,
Greg Kroah-Hartman
maintainerPATCH 35/73 drm/ast: deal with bo reserve fail in dirty update path
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Dave Airlie <[email protected]>
commit 306373b645d80625335b8e684fa09b14ba460cec upstream.
Port over the mgag200 fix to ast as it suffers the same issue.
On F19 testing, it was noticed we get a lot of errors in dmesg about being unable to reserve the buffer when plymouth starts, this is due to the buffer being in the process of migrating, so it makes sense we can't reserve it.
In order to deal with it, this adds delayed updates for the dirty updates, when the bo is unreservable, in the normal console case this shouldn't ever happen, its just when plymouth or X is pushing the console bo to system memory.
--- drivers/gpu/drm/ast/ast_drv.h | 2 + drivers/gpu/drm/ast/ast_fb.c | 43 +++++++++++++++++++++++++++++++++++++++--- drivers/gpu/drm/ast/ast_ttm.c | 2 - 3 files changed, 43 insertions(+), 4 deletions(-)
drivers/gpu/drm/ast/ast_drv.h +2 -0
@@ -239,6 +239,8 @@ struct ast_fbdev {void *sysram;int size;struct ttm_bo_kmap_obj mapping; +int x1, y1, x2, y2;/* dirty rect */ +spinlock_t dirty_lock; };#define to_ast_crtc (x) container_of(x, struct ast_crtc, base)
drivers/gpu/drm/ast/ast_fb.c +40 -3
72 lines not on this page · raw message
drivers/gpu/drm/ast/ast_ttm.c +1 -1
@@ -316,7 +316,7 @@ int ast_bo_reserve(struct ast_bo *bo, bo ret =ttm_bo_reserve (&bo->bo, true, no_wait, false,0 );if (ret) { -if (ret != -ERESTARTSYS ) +if (ret != -ERESTARTSYS && ret != -EBUSY )DRM_ERROR ("reserve failed %p\n" , bo);return ret; }
Greg Kroah-Hartman
maintainerPATCH 36/73 drm/i915: Fix detection of base of stolen memory
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Wilson <[email protected]>
commit e12a2d53ae45a69aea499b64f75e7222cca0f12f upstream.
The routine to query the base of stolen memory was using the wrong registers and the wrong encodings on virtually every platform.
It was not until the G33 refresh, that a PCI config register was introduced that explicitly said where the stolen memory was. Prior to 865G there was not even a register that said where the end of usable low memory was and where the stolen memory began (or ended depending upon chipset). Before then, one has to look at the BIOS memory maps to find the Top of Memory. Alas that is not exported by arch/x86 and so we have to resort to disabling stolen memory on gen2 for the time being.
Then SandyBridge enlarged the PCI register to a full 32-bits and change the encoding of the address, so even though we happened to be querying the right register, we read the wrong bits and ended up using address 0 for our stolen data, i.e. notably FBC.
--- drivers/gpu/drm/i915/i915_drv.h | 1 drivers/gpu/drm/i915/i915_gem_stolen.c | 81 ++++++++++++++++----------------- 2 files changed, 42 insertions(+), 40 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -774,6 +774,7 @@ typedef struct drm_i915_private {unsigned long gtt_start;unsigned long gtt_mappable_end;unsigned long gtt_end; +unsigned long stolen_base;/* limited to low memory (32-bit) */ struct io_mapping *gtt_mapping;phys_addr_t gtt_base_addr;
drivers/gpu/drm/i915/i915_gem_stolen.c +41 -40
124 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 37/73 drm/i915: Fix sdvo connector get_hw_state function
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Daniel Vetter <[email protected]>
commit bd6946e87a98fea11907b2a47368e13044458a35 upstream.
The active output is only the currently selected one, which does not imply that it's actually enabled. Since we don't use the sdvo encoder side dpms support, we need to check whether the chip-side sdvo port is enabled instead.
v2: Fix up Bugzilla links.
v3: Simplify logic a bit (Chris).
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=60138
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63031
--- drivers/gpu/drm/i915/intel_sdvo.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/i915/intel_sdvo.c +4 -0
@@ -1197,8 +1197,12 @@ static bool intel_sdvo_connector_get_hw_struct intel_sdvo_connector *intel_sdvo_connector =to_intel_sdvo_connector (&connector->base);struct intel_sdvo *intel_sdvo =intel_attached_sdvo (&connector->base); +struct drm_i915_private *dev_priv = intel_sdvo->base.base.dev->dev_private;u16 active_outputs; +if (!(I915_READ (intel_sdvo->sdvo_reg) &SDVO_ENABLE )) +return false; +intel_sdvo_get_active_outputs (intel_sdvo, &active_outputs);if (active_outputs & intel_sdvo_connector->output_flag)
Greg Kroah-Hartman
maintainerPATCH 38/73 drm/i915: Add no-lvds quirk for Fujitsu Esprimo Q900
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Christian Lamparter <[email protected]>
commit 9e9dd0e889c76c786e8f2e164c825c3c06dea30c upstream.
The "Mobile Sandy Bridge CPUs" in the Fujitsu Esprimo Q900 mini desktop PCs are probably misleading the LVDS detection code in intel_lvds_supported. Nothing is connected to the LVDS ports in these systems.
--- drivers/gpu/drm/i915/intel_lvds.c | 8 ++++++++ 1 file changed, 8 insertions(+)
drivers/gpu/drm/i915/intel_lvds.c +8 -0
@@ -790,6 +790,14 @@ static const struct dmi_system_id intel_ DMI_MATCH(DMI_PRODUCT_NAME, "X7SPA-H"), }, }, + { + .callback = intel_no_lvds_dmi_callback, + .ident = "Fujitsu Esprimo Q900", + .matches = { + DMI_MATCH(DMI_SYS_VENDOR, "FUJITSU"), + DMI_MATCH(DMI_PRODUCT_NAME, "ESPRIMO Q900"), + }, + }, { }/* terminating entry */ };
Greg Kroah-Hartman
maintainerPATCH 39/73 drm/i915: Fix SDVO connector and encoder get_hw_state functions
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Egbert Eich <[email protected]>
commit 7a7d1fb79fb581553f4830498045de774a9659f8 upstream.
The connector associated with the encoder is considered active when the output associtated with this connector is active on the encoder. The encoder itself is considered active when either there is an active output on it or the respective SDVO channel is active. Having active outputs when the SDVO channel is inactive seems to be
inconsistent: such states can be found when intel_modeset_setup_hw_state() collects the hardware state set by the BIOS.
This inconsistency will be fixed in intel_sanitize_crtc() (when intel_crtc_update_dpms() is called), this however only happens when the encoder is associated with a crtc.
This patch also reverts:
commit bd6946e87a98fea11907b2a47368e13044458a35
Author: Daniel Vetter <[email protected]>
Date: Tue Apr 2 21:30:34 2013 +0200
drm/i915: Fix sdvo connector get_hw_state function
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=63031
--- drivers/gpu/drm/i915/intel_sdvo.c | 9 +++------ 1 file changed, 3 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/intel_sdvo.c +3 -6
@@ -1197,12 +1197,8 @@ static bool intel_sdvo_connector_get_hw_struct intel_sdvo_connector *intel_sdvo_connector =to_intel_sdvo_connector (&connector->base);struct intel_sdvo *intel_sdvo =intel_attached_sdvo (&connector->base); -struct drm_i915_private *dev_priv = intel_sdvo->base.base.dev->dev_private;u16 active_outputs; -if (!(I915_READ (intel_sdvo->sdvo_reg) &SDVO_ENABLE )) -return false; -intel_sdvo_get_active_outputs (intel_sdvo, &active_outputs);if (active_outputs & intel_sdvo_connector->output_flag)
@@ -1217,11 +1213,13 @@ static bool intel_sdvo_get_hw_state(strustruct drm_device *dev = encoder->base.dev;struct drm_i915_private *dev_priv = dev->dev_private;struct intel_sdvo *intel_sdvo =to_intel_sdvo (&encoder->base); +u16 active_outputs;u32 tmp; tmp =I915_READ (intel_sdvo->sdvo_reg); +intel_sdvo_get_active_outputs (intel_sdvo, &active_outputs); -if (!(tmp &SDVO_ENABLE )) +if (!(tmp &SDVO_ENABLE ) && (active_outputs ==0 ))return false;if (HAS_PCH_CPT (dev))
@@ -2708,7 +2706,6 @@ bool intel_sdvo_init(struct drm_device *struct intel_sdvo *intel_sdvo;u32 hotplug_mask;int i; - intel_sdvo =kzalloc (sizeof (struct intel_sdvo ),GFP_KERNEL );if (!intel_sdvo)return false;
Greg Kroah-Hartman
maintainerPATCH 40/73 drm/i915: Workaround incoherence between fences and LLC across multiple CPUs
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Wilson <[email protected]>
commit 25ff1195f8a0b3724541ae7bbe331b4296de9c06 upstream.
In order to fully serialize access to the fenced region and the update to the fence register we need to take extreme measures on SNB+, and manually flush writes to memory prior to writing the fence register in conjunction with the memory barriers placed around the register write.
Fixes i-g-t/gem_fence_thrash
v2: Bring a bigger gun
v3: Switch the bigger gun for heavier bullets (Arjan van de Ven)
v4: Remove changes for working generations.
v5: Reduce to a per-cpu wbinvd() call prior to updating the fences.
v6: Rewrite comments to ellide forgotten history.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=62191
--- drivers/gpu/drm/i915/i915_gem.c | 26 ++++++++++++++++++++++---- 1 file changed, 22 insertions(+), 4 deletions(-)
drivers/gpu/drm/i915/i915_gem.c +22 -4
@@ -2662,17 +2662,35 @@ static inline int fence_number(struct drreturn fence - dev_priv->fence_regs; } +static void i915_gem_write_fence__ipi (void *data) +{ +wbinvd (); +} +static void i915_gem_object_update_fence (struct drm_i915_gem_object *obj,struct drm_i915_fence_reg *fence,bool enable) { -struct drm_i915_private *dev_priv = obj->base.dev->dev_private; -int reg =fence_number (dev_priv, fence); +struct drm_device *dev = obj->base.dev; +struct drm_i915_private *dev_priv = dev->dev_private; +int fence_reg =fence_number (dev_priv, fence); -i915_gem_write_fence (obj->base.dev, reg, enable ? obj :NULL ); +/* In order to fully serialize access to the fenced region and +* the update to the fence register we need to take extreme +* measures on SNB+. In theory, the write to the fence register +* flushes all memory transactions before, and coupled with the +* mb() placed around the register write we serialise all memory +* operations with respect to the changes in the tiler. Yet, on +* SNB+ we need to take a step further and emit an explicit wbinvd() +* on each processor in order to manually flush all memory +* transactions before updating the fence register. +*/ +if (HAS_LLC (obj->base.dev)) +on_each_cpu (i915_gem_write_fence__ipi,NULL ,1 ); +i915_gem_write_fence (dev, fence_reg, enable ? obj :NULL );if (enable) { - obj->fence_reg = reg; + obj->fence_reg = fence_reg; fence->obj = obj;list_move_tail (&fence->lru_list, &dev_priv->mm.fence_list); }else {
Greg Kroah-Hartman
maintainerPATCH 41/73 drm/i915: Use MLC (l3$) for context objects
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chris Wilson <[email protected]>
commit 4615d4c9e27eda42c3e965f208a4b4065841498c upstream.
Enabling context support increases SwapBuffers latency by about 20% (measured on an i7-3720qm). We can offset that loss slightly by enabling faster caching for the contexts. As they are not backed by any particular cache (such as the sampler or render caches) our only option is to select the generic mid-level cache. This reduces the latency of the swap by about 5%.
Oddly this effect can be observed running smokin-guns on IVB at 1280x1024:
Using BLT copies for swaps: 151.67 fps
Using Render copies for swaps (unpatched): 141.70 fps With contexts disabled: 150.23 fps
With contexts in L3$: 150.77 fps
--- drivers/gpu/drm/i915/i915_gem_context.c | 7 +++++++ 1 file changed, 7 insertions(+)
drivers/gpu/drm/i915/i915_gem_context.c +7 -0
@@ -157,6 +157,13 @@ create_hw_context(struct drm_device *devreturn ERR_PTR (-ENOMEM ); } +if (INTEL_INFO (dev)->gen >=7 ) { + ret =i915_gem_object_set_cache_level (ctx->obj, +I915_CACHE_LLC_MLC ); +if (ret) + goto err_out; + } +/* The ring associated with the context object is handled by the normal * object tracking code. We give an initial ring value simple to pass an * assertion in the context switch code.
Greg Kroah-Hartman
maintainerPATCH 42/73 drm/i915: set CPT FDI RX polarity bits based on VBT
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Paulo Zanoni <[email protected]>
commit 3f704fa2778d3fe45e6529825a5c7a8bcbc686f4 upstream.
Check the VBT to see if the machine has inverted FDI RX polarity on CPT. Based on this bit, set the appropriate bit on the TRANS_CHICKEN2 registers.
This should fix some machines that were showing black screens on all outputs.
Bugzilla: https://bugs.freedesktop.org/show_bug.cgi?id=60029
--- drivers/gpu/drm/i915/i915_drv.h | 1 + drivers/gpu/drm/i915/i915_reg.h | 2 +- drivers/gpu/drm/i915/intel_bios.c | 6 ++++-- drivers/gpu/drm/i915/intel_bios.h | 4 +++- drivers/gpu/drm/i915/intel_pm.c | 9 +++++++-- 5 files changed, 16 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/i915_drv.h +1 -0
@@ -711,6 +711,7 @@ typedef struct drm_i915_private { unsigned int int_crt_support:1; unsigned int lvds_use_ssc:1; unsigned int display_clock_mode:1; + unsigned int fdi_rx_polarity_inverted:1;int lvds_ssc_freq;unsigned int bios_lvds_val;/* initial [PCH_]LVDS reg val in VBIOS */ unsigned int lvds_val;/* used for checking LVDS channel mode */
drivers/gpu/drm/i915/i915_reg.h +1 -1
@@ -3839,7 +3839,7 @@#define _TRANSB_CHICKEN2 0xf1064#define TRANS_CHICKEN2 (pipe) _PIPE(pipe, _TRANSA_CHICKEN2, _TRANSB_CHICKEN2)#define TRANS_CHICKEN2_TIMING_OVERRIDE (1<<31) - +#define TRANS_CHICKEN2_FDI_POLARITY_REVERSED (1<<29)#define SOUTH_CHICKEN1 0xc2000#define FDIA_PHASE_SYNC_SHIFT_OVR 19
drivers/gpu/drm/i915/intel_bios.c +4 -2
@@ -351,12 +351,14 @@ parse_general_features(struct drm_i915_p dev_priv->lvds_ssc_freq =intel_bios_ssc_frequency (dev, general->ssc_freq); dev_priv->display_clock_mode = general->display_clock_mode; -DRM_DEBUG_KMS ("BDB_GENERAL_FEATURES int_tv_support %d int_crt_support %d lvds_use_ssc %d lvds_ssc_freq %d display_clock_mode %d\n" , + dev_priv->fdi_rx_polarity_inverted = general->fdi_rx_polarity_inverted; +DRM_DEBUG_KMS ("BDB_GENERAL_FEATURES int_tv_support %d int_crt_support %d lvds_use_ssc %d lvds_ssc_freq %d display_clock_mode %d fdi_rx_polarity_inverted %d\n" , dev_priv->int_tv_support, dev_priv->int_crt_support, dev_priv->lvds_use_ssc, dev_priv->lvds_ssc_freq, - dev_priv->display_clock_mode); + dev_priv->display_clock_mode, + dev_priv->fdi_rx_polarity_inverted); } }
drivers/gpu/drm/i915/intel_bios.h +3 -1
@@ -127,7 +127,9 @@ struct bdb_general_features {/* bits 3 */ u8 disable_smooth_vision:1; u8 single_dvi:1; - u8 rsvd9:6; /* finish byte */ + u8 rsvd9:1; + u8 fdi_rx_polarity_inverted:1; + u8 rsvd10:4; /* finish byte *//* bits 4 */ u8 legacy_monitor_detect;
drivers/gpu/drm/i915/intel_pm.c +7 -2
@@ -3560,6 +3560,7 @@ static void cpt_init_clock_gating(struct {struct drm_i915_private *dev_priv = dev->dev_private;int pipe; +uint32_t val;/* * On Ibex Peak and Cougar Point, we need to disable clock
@@ -3572,8 +3573,12 @@ static void cpt_init_clock_gating(struct/* The below fixes the weird display corruption, a few pixels shifted * downward, on (only) LVDS of some HP laptops with IVY. */ -for_each_pipe (pipe) -I915_WRITE (TRANS_CHICKEN2 (pipe),TRANS_CHICKEN2_TIMING_OVERRIDE ); +for_each_pipe (pipe) { + val =TRANS_CHICKEN2_TIMING_OVERRIDE ; +if (dev_priv->fdi_rx_polarity_inverted) + val |=TRANS_CHICKEN2_FDI_POLARITY_REVERSED ; +I915_WRITE (TRANS_CHICKEN2 (pipe), val); + }/* WADP0ClockGatingDisable */ for_each_pipe (pipe) { I915_WRITE(TRANS_CHICKEN1(pipe),
Greg Kroah-Hartman
maintainerPATCH 43/73 drm/i915: ensure single initialization and cleanup of backlight device
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jani Nikula <[email protected]>
commit dc652f90e088798bfa31f496ba994ddadd5d5680 upstream.
Backlight cleanup in the eDP connector destroy callback caused the backlight device to be removed on some systems that first initialized LVDS and then attempted to initialize eDP. Prevent multiple backlight initializations, and ensure backlight cleanup is only done once by moving it to modeset cleanup.
A small wrinkle is the introduced asymmetry in backlight setup/cleanup. This could be solved by adding refcounting, but it seems overkill considering that there should only ever be one backlight device.
Bugzilla: https://bugzilla.kernel.org/show_bug.cgi?id=55701
--- drivers/gpu/drm/i915/intel_display.c | 3 +++ drivers/gpu/drm/i915/intel_dp.c | 5 +---- drivers/gpu/drm/i915/intel_lvds.c | 1 - drivers/gpu/drm/i915/intel_panel.c | 7 ++++++- 4 files changed, 10 insertions(+), 6 deletions(-)
drivers/gpu/drm/i915/intel_display.c +3 -0
@@ -9388,6 +9388,9 @@ void intel_modeset_cleanup(struct drm_de/* flush any delayed tasks or pending work */ flush_scheduled_work (); +/* destroy backlight, if any, before the connectors */ +intel_panel_destroy_backlight (dev); +drm_mode_config_cleanup (dev); }
drivers/gpu/drm/i915/intel_dp.c +1 -4
@@ -2467,17 +2467,14 @@ done:static void intel_dp_destroy (struct drm_connector *connector) { -struct drm_device *dev = connector->dev;struct intel_dp *intel_dp =intel_attached_dp (connector);struct intel_connector *intel_connector =to_intel_connector (connector);if (!IS_ERR_OR_NULL (intel_connector->edid))kfree (intel_connector->edid); -if (is_edp (intel_dp)) { -intel_panel_destroy_backlight (dev); +if (is_edp (intel_dp))intel_panel_fini (&intel_connector->panel); - }drm_sysfs_connector_remove (connector);drm_connector_cleanup (connector);
drivers/gpu/drm/i915/intel_lvds.c +0 -1
@@ -556,7 +556,6 @@ static void intel_lvds_destroy(struct drif (!IS_ERR_OR_NULL (lvds_connector->base.edid))kfree (lvds_connector->base.edid); -intel_panel_destroy_backlight (connector->dev);intel_panel_fini (&lvds_connector->base.panel);drm_sysfs_connector_remove (connector);
drivers/gpu/drm/i915/intel_panel.c +6 -1
@@ -422,6 +422,9 @@ int intel_panel_setup_backlight(struct dintel_panel_init_backlight (dev); +if (WARN_ON (dev_priv->backlight)) +return -ENODEV ; +memset (&props,0 ,sizeof (props)); props.type =BACKLIGHT_RAW ; props.max_brightness =_intel_panel_get_max_backlight (dev);
@@ -447,8 +450,10 @@ int intel_panel_setup_backlight(struct dvoid intel_panel_destroy_backlight (struct drm_device *dev) {struct drm_i915_private *dev_priv = dev->dev_private; -if (dev_priv->backlight) +if (dev_priv->backlight) {backlight_device_unregister (dev_priv->backlight); + dev_priv->backlight =NULL ; + } }#else int intel_panel_setup_backlight (struct drm_connector *connector)
Greg Kroah-Hartman
maintainerPATCH 44/73 drm/i915: Fixup Oops in the pipe config computation
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Daniel Vetter <[email protected]>
commit b6c5164d7bf624f3e1b750787ddb983150c5117c upstream.
Yet again our current confusion between doing the modeset globally, but only having the new parameters for one crtc at a time.
So that intel_set_mode essentially already does a global modeset:intel_modeset_affected_pipes compares the current state with where we want to go to (which is carefully set up by intel_crtc_set_config) and then goes through the modeset sequence for any crtc which needs updating.
Now the issue is that the actual interface with the remaining code still only works on one crtc, and so we only pass in one fb and one mode. In intel_set_mode we also only compute one intel_crtc_config (which should be the one for the crtc we're doing a modeset on).
The reason for that mismatch is twofold:
- We want to eventually do all modeset as global state changes, so it's just infrastructure prep.
- But even the old semantics can change more than one crtc when you e.g. move a connector from crtc A to crtc B, then both crtc A and B need to be updated. Usually that means one pipe is disabled and the other enabled. This is also the reason why the hack doesn't touch the disable_pipes mask.
Now hilarity ensued in our kms config restore paths when we actually try to do a modeset on all crtcs: If the first crtc should be off and the second should be on, then the call on the first crtc will notice that the 2nd one should be switched on and so tries to compute the pipe_config. But due to a lack of passed-in fb (crtc 1 should be off after all) it only results in tears.
This case is ridiculously easy to hit on gen2/3 where the lvds output is restricted to pipe B. Note that before the pipe_config bpp rework gen2/3 didn't care really about the fb->depth, so this is a regression brought to light with
commit 4e53c2e010e531b4a014692199e978482d471c7e
Author: Daniel Vetter <[email protected]> Date: Wed Mar 27 00:44:58 2013 +0100
drm/i915: precompute pipe bpp before touching the hw
But apparently Ajax also managed to blow up pch platforms, probably with some randomized configs, and pch platforms trip up over the lack of an fb even in the old code. So this actually goes back to the first introduction of the new modeset restore code in
commit 45e2b5f640b3766da3eda48f6c35f088155c06f3
Author: Daniel Vetter <[email protected]> Date: Fri Nov 23 18:16:34 2012 +0100
drm/i915: force restore on lid open
Fix this mess by now by justing shunting all the cool new global modeset logic in intel_modeset_affected_pipes.
v2: Improve commit message and clean up all the comments in intel_modeset_affected_pipes - since the introduction of the modeset restore code they've been a bit outdated.
Bugzill: https://bugzilla.redhat.com/show_bug.cgi?id=917725
References: http://www.mail-archive.com/[email protected]/msg38084.html
--- drivers/gpu/drm/i915/intel_display.c | 23 +++++++++++++---------- 1 file changed, 13 insertions(+), 10 deletions(-)
drivers/gpu/drm/i915/intel_display.c +13 -10
@@ -7732,22 +7732,25 @@ intel_modeset_affected_pipes(struct drm_if (crtc->enabled) *prepare_pipes |=1 << intel_crtc->pipe; -/* We only support modeset on one single crtc, hence we need to do that -* only for the passed in crtc iff we change anything else than just -* disable crtcs. -* -* This is actually not true, to be fully compatible with the old crtc -* helper we automatically disable _any_ output (i.e. doesn't need to be -* connected to the crtc we're modesetting on) if it's disconnected. -* Which is a rather nutty api (since changed the output configuration -* without userspace's explicit request can lead to confusion), but -* alas. Hence we currently need to modeset on all pipes we prepare. */ +/* +* For simplicity do a full modeset on any pipe where the output routing +* changed. We could be more clever, but that would require us to be +* more careful with calling the relevant encoder->mode_set functions. +*/ if (*prepare_pipes) *modeset_pipes = *prepare_pipes;/* ... and mask these out. */ *modeset_pipes &= ~(*disable_pipes); *prepare_pipes &= ~(*disable_pipes); + +/* +* HACK: We don't (yet) fully support global modesets. intel_set_config +* obies this rule, but the modeset restore mode of +* intel_modeset_setup_hw_state does not. +*/ + *modeset_pipes &=1 << intel_crtc->pipe; + *prepare_pipes &=1 << intel_crtc->pipe; }static bool intel_crtc_in_use (struct drm_crtc *crtc)
Greg Kroah-Hartman
maintainerPATCH 45/73 drm/i915: Fall back to bit banging mode for DVO transmitter detection
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: David Müller <[email protected]>
commit e4bfff54ed3f5de88f5358504c78c2cb037813aa upstream.
As discussed in this thread
http://lists.freedesktop.org/archives/dri-devel/2013-April/037411.html
GMBUS based DVO transmitter detection seems to be unreliable which could result in an unusable DVO port.
The attached patch fixes this by falling back to bit banging mode for the time DVO transmitter detection is in progress.
--- drivers/gpu/drm/i915/intel_dvo.c | 13 ++++++++++++- 1 file changed, 12 insertions(+), 1 deletion(-)
drivers/gpu/drm/i915/intel_dvo.c +12 -1
@@ -449,6 +449,7 @@ void intel_dvo_init(struct drm_device *dconst struct intel_dvo_device *dvo = &intel_dvo_devices[i];struct i2c_adapter *i2c;int gpio; +bool dvoinit;/* Allow the I2C driver info to specify the GPIO to be used in * special cases, but otherwise default to what's defined
@@ -468,7 +469,17 @@ void intel_dvo_init(struct drm_device *d i2c =intel_gmbus_get_adapter (dev_priv, gpio); intel_dvo->dev = *dvo; -if (!dvo->dev_ops->init (&intel_dvo->dev, i2c)) + +/* GMBUS NAK handling seems to be unstable, hence let the +* transmitter detection run in bit banging mode for now. +*/ +intel_gmbus_force_bit (i2c, true); + + dvoinit = dvo->dev_ops->init (&intel_dvo->dev, i2c); + +intel_gmbus_force_bit (i2c, false); + +if (!dvoinit)continue ; intel_encoder->type =INTEL_OUTPUT_DVO ;
Greg Kroah-Hartman
maintainerPATCH 46/73 drm/radeon: dont use get_engine_clock() on APUs
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit bf05d9985111f85ed6922c134567b96eb789283b upstream.
It doesn't work reliably. Just report back the currently selected engine clock.
Partially fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=62493
--- drivers/gpu/drm/radeon/radeon_pm.c | 6 +++++- 1 file changed, 5 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_pm.c +5 -1
@@ -843,7 +843,11 @@ static int radeon_debugfs_pm_info(structstruct radeon_device *rdev = dev->dev_private;seq_printf (m,"default engine clock: %u0 kHz\n" , rdev->pm.default_sclk); -seq_printf (m,"current engine clock: %u0 kHz\n" ,radeon_get_engine_clock (rdev)); +/* radeon_get_engine_clock is not reliable on APUs so just print the current clock */ +if ((rdev->family >=CHIP_PALM ) && (rdev->flags &RADEON_IS_IGP )) +seq_printf (m,"current engine clock: %u0 kHz\n" , rdev->pm.current_sclk); +else +seq_printf (m,"current engine clock: %u0 kHz\n" ,radeon_get_engine_clock (rdev));seq_printf (m,"default memory clock: %u0 kHz\n" , rdev->pm.default_mclk);if (rdev->asic->pm.get_memory_clock)seq_printf (m,"current memory clock: %u0 kHz\n" ,radeon_get_memory_clock (rdev));
Greg Kroah-Hartman
maintainerPATCH 47/73 drm/radeon: use frac fb div on RS780/RS880
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 411678288d61ba17afe1f8afed92200be6bbc65d upstream.
Monitors seem to prefer it. Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=37696
--- drivers/gpu/drm/radeon/atombios_crtc.c | 3 +++ 1 file changed, 3 insertions(+)
drivers/gpu/drm/radeon/atombios_crtc.c +3 -0
@@ -557,6 +557,9 @@ static u32 atombios_adjust_pll(struct dr/* use frac fb div on APUs */ if (ASIC_IS_DCE41 (rdev) ||ASIC_IS_DCE61 (rdev)) radeon_crtc->pll_flags |=RADEON_PLL_USE_FRAC_FB_DIV ; +/* use frac fb div on RS780/RS880 */ +if ((rdev->family ==CHIP_RS780 ) || (rdev->family ==CHIP_RS880 )) + radeon_crtc->pll_flags |=RADEON_PLL_USE_FRAC_FB_DIV ;if (ASIC_IS_DCE32 (rdev) && mode->clock >165000 ) radeon_crtc->pll_flags |=RADEON_PLL_USE_FRAC_FB_DIV ; }else {
Greg Kroah-Hartman
maintainerPATCH 48/73 drm/radeon: fix typo in rv515_mc_resume()
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 367cbe2fec9b57b72605e2ac4cfd4f2fa823a256 upstream.
Doesn't affect anything as the same address gets written in both cases.
--- drivers/gpu/drm/radeon/rv515.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/rv515.c +1 -1
@@ -348,7 +348,7 @@ void rv515_mc_resume(struct radeon_devic/* update crtc base addresses */ for (i =0 ; i < rdev->num_crtc; i++) {if (rdev->family >=CHIP_RV770 ) { -if (i ==1 ) { +if (i ==0 ) {WREG32 (R700_D1GRPH_PRIMARY_SURFACE_ADDRESS_HIGH ,upper_32_bits (rdev->mc.vram_start)); WREG32(R700_D1GRPH_SECONDARY_SURFACE_ADDRESS_HIGH,
Greg Kroah-Hartman
maintainerPATCH 49/73 drm/radeon/dce6: add missing display reg for tiling setup
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 7c1c7c18fc752b2a1d07597286467ef186312463 upstream.
A new tiling config register for the display blocks was added on DCE6.
May fix:
https://bugs.freedesktop.org/show_bug.cgi?id=62889
https://bugs.freedesktop.org/show_bug.cgi?id=57919
--- drivers/gpu/drm/radeon/ni.c | 2 ++ drivers/gpu/drm/radeon/nid.h | 4 ++++ drivers/gpu/drm/radeon/si.c | 1 + drivers/gpu/drm/radeon/sid.h | 2 ++ 4 files changed, 9 insertions(+)
drivers/gpu/drm/radeon/ni.c +2 -0
@@ -619,6 +619,8 @@ static void cayman_gpu_init(struct radeoWREG32 (GB_ADDR_CONFIG , gb_addr_config);WREG32 (DMIF_ADDR_CONFIG , gb_addr_config); +if (ASIC_IS_DCE6 (rdev)) +WREG32 (DMIF_ADDR_CALC , gb_addr_config);WREG32 (HDP_ADDR_CONFIG , gb_addr_config);WREG32 (DMA_TILING_CONFIG +DMA0_REGISTER_OFFSET , gb_addr_config);WREG32 (DMA_TILING_CONFIG +DMA1_REGISTER_OFFSET , gb_addr_config);
drivers/gpu/drm/radeon/nid.h +4 -0
@@ -45,6 +45,10 @@#define ARUBA_GB_ADDR_CONFIG_GOLDEN 0x12010001#define DMIF_ADDR_CONFIG 0xBD4 + +/* DCE6 only */ +#define DMIF_ADDR_CALC 0xC00 +#define SRBM_GFX_CNTL 0x0E44#define RINGID (x) (((x) & 0x3) << 0)#define VMID (x) (((x) & 0x7) << 0)
drivers/gpu/drm/radeon/si.c +1 -0
@@ -1659,6 +1659,7 @@ static void si_gpu_init(struct radeon_deWREG32 (GB_ADDR_CONFIG , gb_addr_config);WREG32 (DMIF_ADDR_CONFIG , gb_addr_config); +WREG32 (DMIF_ADDR_CALC , gb_addr_config);WREG32 (HDP_ADDR_CONFIG , gb_addr_config);WREG32 (DMA_TILING_CONFIG +DMA0_REGISTER_OFFSET , gb_addr_config);WREG32 (DMA_TILING_CONFIG +DMA1_REGISTER_OFFSET , gb_addr_config);
drivers/gpu/drm/radeon/sid.h +2 -0
@@ -60,6 +60,8 @@#define DMIF_ADDR_CONFIG 0xBD4 +#define DMIF_ADDR_CALC 0xC00 +#define SRBM_STATUS 0xE50#define SRBM_SOFT_RESET 0x0E60
Greg Kroah-Hartman
maintainerPATCH 50/73 drm/radeon: update wait_for_vblank for r5xx-r7xx
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit bea5497bfc1067620c8c8e9d37a42e0bb6d7d7fa upstream.
Properly wait for the next vblank region. The previous code didn't always wait long enough depending on the timing.
--- drivers/gpu/drm/radeon/rs600.c | 52 ++++++++++++++++++++++++++++++++++------- 1 file changed, 44 insertions(+), 8 deletions(-)
drivers/gpu/drm/radeon/rs600.c +44 -8
@@ -52,23 +52,59 @@ static const u32 crtc_offsets[2] =AVIVO_D2CRTC_H_TOTAL -AVIVO_D1CRTC_H_TOTAL }; +static bool avivo_is_in_vblank (struct radeon_device *rdev,int crtc) +{ +if (RREG32 (AVIVO_D1CRTC_STATUS + crtc_offsets[crtc]) &AVIVO_D1CRTC_V_BLANK ) +return true; +else +return false; +} + +static bool avivo_is_counter_moving (struct radeon_device *rdev,int crtc) +{ +u32 pos1, pos2; + + pos1 =RREG32 (AVIVO_D1CRTC_STATUS_POSITION + crtc_offsets[crtc]); + pos2 =RREG32 (AVIVO_D1CRTC_STATUS_POSITION + crtc_offsets[crtc]); + +if (pos1 != pos2) +return true; +else +return false; +} + +/** +* avivo_wait_for_vblank - vblank wait asic callback. +* +* @rdev: radeon_device pointer +* @crtc: crtc to wait for vblank on +* +* Wait for vblank on the requested crtc (r5xx-r7xx). +*/ void avivo_wait_for_vblank (struct radeon_device *rdev,int crtc) { -int i; +unsigned i =0 ;if (crtc >= rdev->num_crtc)return ; -if (RREG32 (AVIVO_D1CRTC_CONTROL + crtc_offsets[crtc]) &AVIVO_CRTC_EN ) { -for (i =0 ; i < rdev->usec_timeout; i++) { -if (!(RREG32 (AVIVO_D1CRTC_STATUS + crtc_offsets[crtc]) &AVIVO_D1CRTC_V_BLANK )) +if (!(RREG32 (AVIVO_D1CRTC_CONTROL + crtc_offsets[crtc]) &AVIVO_CRTC_EN )) +return ; + +/* depending on when we hit vblank, we may be close to active; if so, +* wait for another frame. +*/ +while (avivo_is_in_vblank (rdev, crtc)) { +if (i++ %100 ==0 ) { +if (!avivo_is_counter_moving (rdev, crtc))break ; -udelay (1 ); } -for (i =0 ; i < rdev->usec_timeout; i++) { -if (RREG32 (AVIVO_D1CRTC_STATUS + crtc_offsets[crtc]) &AVIVO_D1CRTC_V_BLANK ) + } + +while (!avivo_is_in_vblank (rdev, crtc)) { +if (i++ %100 ==0 ) { +if (!avivo_is_counter_moving (rdev, crtc))break ; -udelay (1 ); } } }
Greg Kroah-Hartman
maintainerPATCH 51/73 drm/radeon: update wait_for_vblank for evergreen+
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 10257a6d8359c41407eb26b7ad7bf710a7e00155 upstream.
Properly wait for the next vblank region. The previous code didn't always wait long enough depending on the timing.
--- drivers/gpu/drm/radeon/evergreen.c | 44 ++++++++++++++++++++++++++++++------- 1 file changed, 36 insertions(+), 8 deletions(-)
drivers/gpu/drm/radeon/evergreen.c +36 -8
@@ -105,6 +105,27 @@ void evergreen_fix_pci_max_read_req_size } } +static bool dce4_is_in_vblank (struct radeon_device *rdev,int crtc) +{ +if (RREG32 (EVERGREEN_CRTC_STATUS + crtc_offsets[crtc]) &EVERGREEN_CRTC_V_BLANK ) +return true; +else +return false; +} + +static bool dce4_is_counter_moving (struct radeon_device *rdev,int crtc) +{ +u32 pos1, pos2; + + pos1 =RREG32 (EVERGREEN_CRTC_STATUS_POSITION + crtc_offsets[crtc]); + pos2 =RREG32 (EVERGREEN_CRTC_STATUS_POSITION + crtc_offsets[crtc]); + +if (pos1 != pos2) +return true; +else +return false; +} +/** * dce4_wait_for_vblank - vblank wait asic callback. *
@@ -115,21 +136,28 @@ void evergreen_fix_pci_max_read_req_size*/ void dce4_wait_for_vblank (struct radeon_device *rdev,int crtc) { -int i; +unsigned i =0 ;if (crtc >= rdev->num_crtc)return ; -if (RREG32 (EVERGREEN_CRTC_CONTROL + crtc_offsets[crtc]) &EVERGREEN_CRTC_MASTER_EN ) { -for (i =0 ; i < rdev->usec_timeout; i++) { -if (!(RREG32 (EVERGREEN_CRTC_STATUS + crtc_offsets[crtc]) &EVERGREEN_CRTC_V_BLANK )) +if (!(RREG32 (EVERGREEN_CRTC_CONTROL + crtc_offsets[crtc]) &EVERGREEN_CRTC_MASTER_EN )) +return ; + +/* depending on when we hit vblank, we may be close to active; if so, +* wait for another frame. +*/ +while (dce4_is_in_vblank (rdev, crtc)) { +if (i++ %100 ==0 ) { +if (!dce4_is_counter_moving (rdev, crtc))break ; -udelay (1 ); } -for (i =0 ; i < rdev->usec_timeout; i++) { -if (RREG32 (EVERGREEN_CRTC_STATUS + crtc_offsets[crtc]) &EVERGREEN_CRTC_V_BLANK ) + } + +while (!dce4_is_in_vblank (rdev, crtc)) { +if (i++ %100 ==0 ) { +if (!dce4_is_counter_moving (rdev, crtc))break ; -udelay (1 ); } } }
Greg Kroah-Hartman
maintainerPATCH 52/73 drm/radeon: properly lock disp in mc_stop/resume for evergreen+
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 968c01664ccbe0e46c19a1af662c4c266a904203 upstream.
Need to wait for the new addresses to take affect before re-enabling the MC.
--- drivers/gpu/drm/radeon/evergreen.c | 47 ++++++++++++++++++++++++++++++--- drivers/gpu/drm/radeon/evergreen_reg.h | 2 + 2 files changed, 45 insertions(+), 4 deletions(-)
drivers/gpu/drm/radeon/evergreen.c +43 -4
@@ -1354,18 +1354,14 @@ void evergreen_mc_stop(struct radeon_devif (!(tmp &EVERGREEN_CRTC_BLANK_DATA_EN )) {radeon_wait_for_vblank (rdev, i); tmp |=EVERGREEN_CRTC_BLANK_DATA_EN ; -WREG32 (EVERGREEN_CRTC_UPDATE_LOCK + crtc_offsets[i],1 );WREG32 (EVERGREEN_CRTC_BLANK_CONTROL + crtc_offsets[i], tmp); -WREG32 (EVERGREEN_CRTC_UPDATE_LOCK + crtc_offsets[i],0 ); } }else { tmp =RREG32 (EVERGREEN_CRTC_CONTROL + crtc_offsets[i]);if (!(tmp &EVERGREEN_CRTC_DISP_READ_REQUEST_DISABLE )) {radeon_wait_for_vblank (rdev, i); tmp |=EVERGREEN_CRTC_DISP_READ_REQUEST_DISABLE ; -WREG32 (EVERGREEN_CRTC_UPDATE_LOCK + crtc_offsets[i],1 );WREG32 (EVERGREEN_CRTC_CONTROL + crtc_offsets[i], tmp); -WREG32 (EVERGREEN_CRTC_UPDATE_LOCK + crtc_offsets[i],0 ); } }/* wait for the next frame */
@@ -1392,6 +1388,22 @@ void evergreen_mc_stop(struct radeon_dev }/* wait for the MC to settle */ udelay (100 ); + +/* lock double buffered regs */ +for (i =0 ; i < rdev->num_crtc; i++) { +if (save->crtc_enabled[i]) { + tmp =RREG32 (EVERGREEN_GRPH_UPDATE + crtc_offsets[i]); +if (!(tmp &EVERGREEN_GRPH_UPDATE_LOCK )) { + tmp |=EVERGREEN_GRPH_UPDATE_LOCK ; +WREG32 (EVERGREEN_GRPH_UPDATE + crtc_offsets[i], tmp); + } + tmp =RREG32 (EVERGREEN_MASTER_UPDATE_LOCK + crtc_offsets[i]); +if (!(tmp &1 )) { + tmp |=1 ; +WREG32 (EVERGREEN_MASTER_UPDATE_LOCK + crtc_offsets[i], tmp); + } + } + } }void evergreen_mc_resume (struct radeon_device *rdev,struct evergreen_mc_save *save)
@@ -1413,6 +1425,33 @@ void evergreen_mc_resume(struct radeon_dWREG32 (EVERGREEN_VGA_MEMORY_BASE_ADDRESS_HIGH ,upper_32_bits (rdev->mc.vram_start));WREG32 (EVERGREEN_VGA_MEMORY_BASE_ADDRESS , (u32 )rdev->mc.vram_start); +/* unlock regs and wait for update */ +for (i =0 ; i < rdev->num_crtc; i++) { +if (save->crtc_enabled[i]) { + tmp =RREG32 (EVERGREEN_MASTER_UPDATE_MODE + crtc_offsets[i]); +if ((tmp &0x3 ) !=0 ) { + tmp &= ~0x3 ; +WREG32 (EVERGREEN_MASTER_UPDATE_MODE + crtc_offsets[i], tmp); + } + tmp =RREG32 (EVERGREEN_GRPH_UPDATE + crtc_offsets[i]); +if (tmp &EVERGREEN_GRPH_UPDATE_LOCK ) { + tmp &= ~EVERGREEN_GRPH_UPDATE_LOCK ; +WREG32 (EVERGREEN_GRPH_UPDATE + crtc_offsets[i], tmp); + } + tmp =RREG32 (EVERGREEN_MASTER_UPDATE_LOCK + crtc_offsets[i]); +if (tmp &1 ) { + tmp &= ~1 ; +WREG32 (EVERGREEN_MASTER_UPDATE_LOCK + crtc_offsets[i], tmp); + } +for (j =0 ; j < rdev->usec_timeout; j++) { + tmp =RREG32 (EVERGREEN_GRPH_UPDATE + crtc_offsets[i]); +if ((tmp &EVERGREEN_GRPH_SURFACE_UPDATE_PENDING ) ==0 ) +break ; +udelay (1 ); + } + } + } +/* unblackout the MC */ tmp =RREG32 (MC_SHARED_BLACKOUT_CNTL ); tmp &= ~BLACKOUT_MODE_MASK ;
drivers/gpu/drm/radeon/evergreen_reg.h +2 -0
@@ -225,6 +225,8 @@#define EVERGREEN_CRTC_STATUS_POSITION 0x6e90#define EVERGREEN_MASTER_UPDATE_MODE 0x6ef8#define EVERGREEN_CRTC_UPDATE_LOCK 0x6ed4 +#define EVERGREEN_MASTER_UPDATE_LOCK 0x6ef4 +#define EVERGREEN_MASTER_UPDATE_MODE 0x6ef8#define EVERGREEN_DC_GPIO_HPD_MASK 0x64b0#define EVERGREEN_DC_GPIO_HPD_A 0x64b4
Greg Kroah-Hartman
maintainerPATCH 53/73 drm/radeon: properly lock disp in mc_stop/resume for r5xx-r7xx
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 2f86e2ede39a98650c2d465857405ef1c51372b1 upstream.
Need to wait for the new addresses to take affect before re-enabling the MC.
--- drivers/gpu/drm/radeon/r500_reg.h | 1 drivers/gpu/drm/radeon/rv515.c | 43 ++++++++++++++++++++++++++++++++++++++ 2 files changed, 44 insertions(+)
drivers/gpu/drm/radeon/r500_reg.h +1 -0
@@ -357,6 +357,7 @@#define AVIVO_D1CRTC_FRAME_COUNT 0x60a4#define AVIVO_D1CRTC_STEREO_CONTROL 0x60c4 +#define AVIVO_D1MODE_MASTER_UPDATE_LOCK 0x60e0#define AVIVO_D1MODE_MASTER_UPDATE_MODE 0x60e4/* master controls */
drivers/gpu/drm/radeon/rv515.c +43 -0
55 lines not on this page · raw message
Greg Kroah-Hartman
maintainerPATCH 54/73 drm/radeon: update wait_for_vblank for r1xx-r4xx
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 2b48b968c0d00aa5ab520b65a15a4f374cda7dda upstream.
Properly wait for the next vblank region. The previous code didn't always wait long enough depending on the timing.
--- drivers/gpu/drm/radeon/r100.c | 77 ++++++++++++++++++++++++++++-------------- 1 file changed, 53 insertions(+), 24 deletions(-)
drivers/gpu/drm/radeon/r100.c +53 -24
@@ -69,6 +69,38 @@ MODULE_FIRMWARE(FIRMWARE_R520);* and others in some cases. */ +static bool r100_is_in_vblank (struct radeon_device *rdev,int crtc) +{ +if (crtc ==0 ) { +if (RREG32 (RADEON_CRTC_STATUS ) &RADEON_CRTC_VBLANK_CUR ) +return true; +else +return false; + }else { +if (RREG32 (RADEON_CRTC2_STATUS ) &RADEON_CRTC2_VBLANK_CUR ) +return true; +else +return false; + } +} + +static bool r100_is_counter_moving (struct radeon_device *rdev,int crtc) +{ +u32 vline1, vline2; + +if (crtc ==0 ) { + vline1 = (RREG32 (RADEON_CRTC_VLINE_CRNT_VLINE ) >>16 ) &RADEON_CRTC_V_TOTAL ; + vline2 = (RREG32 (RADEON_CRTC_VLINE_CRNT_VLINE ) >>16 ) &RADEON_CRTC_V_TOTAL ; + }else { + vline1 = (RREG32 (RADEON_CRTC2_VLINE_CRNT_VLINE ) >>16 ) &RADEON_CRTC_V_TOTAL ; + vline2 = (RREG32 (RADEON_CRTC2_VLINE_CRNT_VLINE ) >>16 ) &RADEON_CRTC_V_TOTAL ; + } +if (vline1 != vline2) +return true; +else +return false; +} +/** * r100_wait_for_vblank - vblank wait asic callback. *
@@ -79,36 +111,33 @@ MODULE_FIRMWARE(FIRMWARE_R520);*/ void r100_wait_for_vblank (struct radeon_device *rdev,int crtc) { -int i; +unsigned i =0 ;if (crtc >= rdev->num_crtc)return ;if (crtc ==0 ) { -if (RREG32 (RADEON_CRTC_GEN_CNTL ) &RADEON_CRTC_EN ) { -for (i =0 ; i < rdev->usec_timeout; i++) { -if (!(RREG32 (RADEON_CRTC_STATUS ) &RADEON_CRTC_VBLANK_CUR )) -break ; -udelay (1 ); - } -for (i =0 ; i < rdev->usec_timeout; i++) { -if (RREG32 (RADEON_CRTC_STATUS ) &RADEON_CRTC_VBLANK_CUR ) -break ; -udelay (1 ); - } - } +if (!(RREG32 (RADEON_CRTC_GEN_CNTL ) &RADEON_CRTC_EN )) +return ; }else { -if (RREG32 (RADEON_CRTC2_GEN_CNTL ) &RADEON_CRTC2_EN ) { -for (i =0 ; i < rdev->usec_timeout; i++) { -if (!(RREG32 (RADEON_CRTC2_STATUS ) &RADEON_CRTC2_VBLANK_CUR )) -break ; -udelay (1 ); - } -for (i =0 ; i < rdev->usec_timeout; i++) { -if (RREG32 (RADEON_CRTC2_STATUS ) &RADEON_CRTC2_VBLANK_CUR ) -break ; -udelay (1 ); - } +if (!(RREG32 (RADEON_CRTC2_GEN_CNTL ) &RADEON_CRTC2_EN )) +return ; + } + +/* depending on when we hit vblank, we may be close to active; if so, +* wait for another frame. +*/ +while (r100_is_in_vblank (rdev, crtc)) { +if (i++ %100 ==0 ) { +if (!r100_is_counter_moving (rdev, crtc)) +break ; + } + } + +while (!r100_is_in_vblank (rdev, crtc)) { +if (i++ %100 ==0 ) { +if (!r100_is_counter_moving (rdev, crtc)) +break ; } } }
Greg Kroah-Hartman
maintainerPATCH 55/73 drm/radeon: disable the crtcs in mc_stop (evergreen+) (v2)
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit abf1457bbbe4c62066bd03c6d31837dea28644dc upstream.
Just disabling the mem requests should be enough, but that doesn't seem to work correctly on efi systems.
May fix:
https://bugs.freedesktop.org/show_bug.cgi?id=57567
https://bugs.freedesktop.org/show_bug.cgi?id=43655
https://bugzilla.kernel.org/show_bug.cgi?id=56441
v2: blank displays first, then disable.
--- drivers/gpu/drm/radeon/evergreen.c | 12 ++++++++++++ 1 file changed, 12 insertions(+)
drivers/gpu/drm/radeon/evergreen.c +12 -0
@@ -1353,6 +1353,7 @@ void evergreen_mc_stop(struct radeon_dev tmp =RREG32 (EVERGREEN_CRTC_BLANK_CONTROL + crtc_offsets[i]);if (!(tmp &EVERGREEN_CRTC_BLANK_DATA_EN )) {radeon_wait_for_vblank (rdev, i); +WREG32 (EVERGREEN_CRTC_UPDATE_LOCK + crtc_offsets[i],1 ); tmp |=EVERGREEN_CRTC_BLANK_DATA_EN ;WREG32 (EVERGREEN_CRTC_BLANK_CONTROL + crtc_offsets[i], tmp); }
@@ -1360,8 +1361,10 @@ void evergreen_mc_stop(struct radeon_dev tmp =RREG32 (EVERGREEN_CRTC_CONTROL + crtc_offsets[i]);if (!(tmp &EVERGREEN_CRTC_DISP_READ_REQUEST_DISABLE )) {radeon_wait_for_vblank (rdev, i); +WREG32 (EVERGREEN_CRTC_UPDATE_LOCK + crtc_offsets[i],1 ); tmp |=EVERGREEN_CRTC_DISP_READ_REQUEST_DISABLE ;WREG32 (EVERGREEN_CRTC_CONTROL + crtc_offsets[i], tmp); +WREG32 (EVERGREEN_CRTC_UPDATE_LOCK + crtc_offsets[i],0 ); } }/* wait for the next frame */
@@ -1371,6 +1374,15 @@ void evergreen_mc_stop(struct radeon_devbreak ;udelay (1 ); } + +/* XXX this is a hack to avoid strange behavior with EFI on certain systems */ +WREG32 (EVERGREEN_CRTC_UPDATE_LOCK + crtc_offsets[i],1 ); + tmp =RREG32 (EVERGREEN_CRTC_CONTROL + crtc_offsets[i]); + tmp &= ~EVERGREEN_CRTC_MASTER_EN ; +WREG32 (EVERGREEN_CRTC_CONTROL + crtc_offsets[i], tmp); +WREG32 (EVERGREEN_CRTC_UPDATE_LOCK + crtc_offsets[i],0 ); + save->crtc_enabled[i] = false; +/* ***** */ }else { save->crtc_enabled[i] = false; }
Greg Kroah-Hartman
maintainerPATCH 56/73 drm/radeon: add some new SI PCI ids
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 18932a28419596bc9403770f5d8a108c5433fe59 upstream.
--- include/drm/drm_pciids.h | 3 +++ 1 file changed, 3 insertions(+)
include/drm/drm_pciids.h +3 -0
@@ -227,6 +227,7 @@ {0x1002, 0x6819, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_PITCAIRN|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6820, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6821, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ + {0x1002, 0x6822, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6823, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6824, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6825, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \
@@ -234,11 +235,13 @@ {0x1002, 0x6827, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6828, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6829, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_NEW_MEMMAP}, \ + {0x1002, 0x682A, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x682B, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x682D, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x682F, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6830, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6831, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP}, \ + {0x1002, 0x6835, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6837, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6838, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_NEW_MEMMAP}, \ {0x1002, 0x6839, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_VERDE|RADEON_NEW_MEMMAP}, \
Greg Kroah-Hartman
maintainerPATCH 57/73 drm/radeon/evergreen+: dont enable HPD interrupts on eDP/LVDS
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 2e97be73e5f74a317232740ae82eb8f95326a660 upstream.
Avoids potential interrupt storms when the display is disabled.
May fix:
https://bugzilla.kernel.org/show_bug.cgi?id=56041
--- drivers/gpu/drm/radeon/evergreen.c | 10 ++++++++++ 1 file changed, 10 insertions(+)
drivers/gpu/drm/radeon/evergreen.c +10 -0
@@ -636,6 +636,16 @@ void evergreen_hpd_init(struct radeon_delist_for_each_entry (connector, &dev->mode_config.connector_list, head) {struct radeon_connector *radeon_connector =to_radeon_connector (connector); + +if (connector->connector_type == DRM_MODE_CONNECTOR_eDP || + connector->connector_type ==DRM_MODE_CONNECTOR_LVDS ) { +/* don't try to enable hpd on eDP or LVDS avoid breaking the +* aux dp channel on imac and help (but not completely fix) +* https://bugzilla.redhat.com/show_bug.cgi?id=726143 +* also avoid interrupt storms during dpms. +*/ +continue ; + }switch (radeon_connector->hpd.hpd) {case RADEON_HPD_1 :WREG32 (DC_HPD1_CONTROL , tmp);
Greg Kroah-Hartman
maintainerPATCH 58/73 drm/radeon: cleanup properly if mmio mapping fails
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 0cd9cb76ae26a19df21abc6f94f5fff141e689c7 upstream.
If we fail to map the mmio BAR, skip driver tear down that requires mmio.
Should fix:
https://bugzilla.kernel.org/show_bug.cgi?id=56541
--- drivers/gpu/drm/radeon/radeon_kms.c | 4 ++++ 1 file changed, 4 insertions(+)
drivers/gpu/drm/radeon/radeon_kms.c +4 -0
@@ -50,9 +50,13 @@ int radeon_driver_unload_kms(struct drm_if (rdev ==NULL )return 0 ; +if (rdev->rmmio ==NULL ) + goto done_free;radeon_acpi_fini (rdev);radeon_modeset_fini (rdev);radeon_device_fini (rdev); + +done_free:kfree (rdev); dev->dev_private =NULL ;return 0 ;
Greg Kroah-Hartman
maintainerPATCH 59/73 drm/radeon: fix hdmi mode enable on RS600/RS690/RS740
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit dcb852905772416e322536ced5cb3c796d176af5 upstream.
These chips were previously skipped since they are pre-R600.
--- drivers/gpu/drm/radeon/r600_hdmi.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/r600_hdmi.c +2 -2
@@ -489,7 +489,7 @@ void r600_hdmi_enable(struct drm_encoder offset = dig->afmt->offset;/* Older chipsets require setting HDMI and routing manually */ -if (rdev->family >=CHIP_R600 && !ASIC_IS_DCE3 (rdev)) { +if (ASIC_IS_DCE2 (rdev) && !ASIC_IS_DCE3 (rdev)) { hdmi =HDMI0_ERROR_ACK |HDMI0_ENABLE ;switch (radeon_encoder->encoder_id) {case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1 :
@@ -557,7 +557,7 @@ void r600_hdmi_disable(struct drm_encoderadeon_irq_kms_disable_afmt (rdev, dig->afmt->id);/* Older chipsets not handled by AtomBIOS */ -if (rdev->family >=CHIP_R600 && !ASIC_IS_DCE3 (rdev)) { +if (ASIC_IS_DCE2 (rdev) && !ASIC_IS_DCE3 (rdev)) {switch (radeon_encoder->encoder_id) {case ENCODER_OBJECT_ID_INTERNAL_KLDSCP_TMDS1 : WREG32_P(AVIVO_TMDSA_CNTL, 0,
Greg Kroah-Hartman
maintainerPATCH 60/73 drm/radeon: fix typo in si_select_se_sh()
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 79b52d6a7085a3e430c6de450a5847fdbe04159b upstream.
--- drivers/gpu/drm/radeon/si.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
drivers/gpu/drm/radeon/si.c +1 -1
@@ -1374,7 +1374,7 @@ static void si_select_se_sh(struct radeou32 data =INSTANCE_BROADCAST_WRITES ;if ((se_num ==0xffffffff ) && (sh_num ==0xffffffff )) - data =SH_BROADCAST_WRITES |SE_BROADCAST_WRITES ; + data |=SH_BROADCAST_WRITES |SE_BROADCAST_WRITES ;else if (se_num ==0xffffffff ) data |=SE_BROADCAST_WRITES |SH_INDEX (sh_num);else if (sh_num ==0xffffffff )
Greg Kroah-Hartman
maintainerPATCH 61/73 drm/radeon: Always flush the VM
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jerome Glisse <[email protected]>
commit 466476dfdcafbb4286ffa232a3a792731b9dc852 upstream.
This is slightly cleaned up version of Jerome's patch. There seems to be an issue tracking the last flush of the VM which results in hangs in certain cases when VM is used. For now just flush the VM for every IB.
Fixes:
https://bugs.freedesktop.org/show_bug.cgi?id=62959
https://bugs.freedesktop.org/show_bug.cgi?id=62997
--- drivers/gpu/drm/radeon/radeon_ring.c | 3 ++- 1 file changed, 2 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_ring.c +2 -1
@@ -161,7 +161,8 @@ int radeon_ib_schedule(struct radeon_devradeon_semaphore_free (rdev, &ib->semaphore,NULL ); }/* if we can't remember our last VM flush then flush now! */ -if (ib->vm && !ib->vm->last_flush) { +/* XXX figure out why we have to flush for every IB */ +if (ib->vm/*&& !ib->vm->last_flush*/ ) {radeon_ring_vm_flush (rdev, ib->ring, ib->vm); }if (const_ib) {
Greg Kroah-Hartman
maintainerPATCH 62/73 drm/radeon: disable the crtcs in mc_stop (r5xx-r7xx) (v2)
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit e884fc640ccbdb6f94b9bdb57cfb8464b6688f4c upstream.
Just disabling the mem requests should be enough, but that doesn't seem to work correctly on efi systems.
v2: blank displays first, then disable.
--- drivers/gpu/drm/radeon/r500_reg.h | 1 + drivers/gpu/drm/radeon/rv515.c | 11 +++++++++++ 2 files changed, 12 insertions(+)
drivers/gpu/drm/radeon/r500_reg.h +1 -0
@@ -359,6 +359,7 @@#define AVIVO_D1MODE_MASTER_UPDATE_LOCK 0x60e0#define AVIVO_D1MODE_MASTER_UPDATE_MODE 0x60e4 +#define AVIVO_D1CRTC_UPDATE_LOCK 0x60e8/* master controls */ #define AVIVO_DC_CRTC_MASTER_EN 0x60f8
drivers/gpu/drm/radeon/rv515.c +11 -0
@@ -303,8 +303,10 @@ void rv515_mc_stop(struct radeon_device tmp =RREG32 (AVIVO_D1CRTC_CONTROL + crtc_offsets[i]);if (!(tmp &AVIVO_CRTC_DISP_READ_REQUEST_DISABLE )) {radeon_wait_for_vblank (rdev, i); +WREG32 (AVIVO_D1CRTC_UPDATE_LOCK + crtc_offsets[i],1 ); tmp |=AVIVO_CRTC_DISP_READ_REQUEST_DISABLE ;WREG32 (AVIVO_D1CRTC_CONTROL + crtc_offsets[i], tmp); +WREG32 (AVIVO_D1CRTC_UPDATE_LOCK + crtc_offsets[i],0 ); }/* wait for the next frame */ frame_count =radeon_get_vblank_counter (rdev, i);
@@ -313,6 +315,15 @@ void rv515_mc_stop(struct radeon_devicebreak ;udelay (1 ); } + +/* XXX this is a hack to avoid strange behavior with EFI on certain systems */ +WREG32 (AVIVO_D1CRTC_UPDATE_LOCK + crtc_offsets[i],1 ); + tmp =RREG32 (AVIVO_D1CRTC_CONTROL + crtc_offsets[i]); + tmp &= ~AVIVO_CRTC_EN ; +WREG32 (AVIVO_D1CRTC_CONTROL + crtc_offsets[i], tmp); +WREG32 (AVIVO_D1CRTC_UPDATE_LOCK + crtc_offsets[i],0 ); + save->crtc_enabled[i] = false; +/* ***** */ }else { save->crtc_enabled[i] = false; }
Greg Kroah-Hartman
maintainerPATCH 63/73 drm/radeon: fix endian bugs in atom_allocate_fb_scratch()
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit beb71fc61c2cad64e347f164991b8ef476529e64 upstream.
--- drivers/gpu/drm/radeon/atom.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
drivers/gpu/drm/radeon/atom.c +3 -3
@@ -1389,10 +1389,10 @@ int atom_allocate_fb_scratch(struct atom firmware_usage = (struct _ATOM_VRAM_USAGE_BY_FIRMWARE *)(ctx->bios + data_offset);DRM_DEBUG ("atom firmware requested %08x %dkb\n" , - firmware_usage->asFirmwareVramReserveInfo[0 ].ulStartAddrUsedByFirmware, - firmware_usage->asFirmwareVramReserveInfo[0 ].usFirmwareUseInKb); +le32_to_cpu (firmware_usage->asFirmwareVramReserveInfo[0 ].ulStartAddrUsedByFirmware), +le16_to_cpu (firmware_usage->asFirmwareVramReserveInfo[0 ].usFirmwareUseInKb)); - usage_bytes = firmware_usage->asFirmwareVramReserveInfo[0 ].usFirmwareUseInKb *1024 ; + usage_bytes =le16_to_cpu (firmware_usage->asFirmwareVramReserveInfo[0 ].usFirmwareUseInKb) *1024 ; } ctx->scratch_size_bytes =0 ;if (usage_bytes ==0 )
Greg Kroah-Hartman
maintainerPATCH 64/73 drm/radeon: fix possible segfault when parsing pm tables
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit f8e6bfc2ce162855fa4f9822a45659f4b542c960 upstream.
If we have a empty power table, bail early and allocate the default power state.
Should fix:
https://bugs.freedesktop.org/show_bug.cgi?id=63865
--- drivers/gpu/drm/radeon/radeon_atombios.c | 10 +++++++++- 1 file changed, 9 insertions(+), 1 deletion(-)
drivers/gpu/drm/radeon/radeon_atombios.c +9 -1
@@ -2028,6 +2028,8 @@ static int radeon_atombios_parse_power_t num_modes = power_info->info.ucNumOfPowerModeEntries;if (num_modes >ATOM_MAX_NUMBEROF_POWER_BLOCK ) num_modes =ATOM_MAX_NUMBEROF_POWER_BLOCK ; +if (num_modes ==0 ) +return state_index; rdev->pm.power_state =kzalloc (sizeof (struct radeon_power_state ) * num_modes,GFP_KERNEL );if (!rdev->pm.power_state)return state_index;
@@ -2432,6 +2434,8 @@ static int radeon_atombios_parse_power_t power_info = (union power_info *)(mode_info->atom_context->bios + data_offset);radeon_atombios_add_pplib_thermal_controller (rdev, &power_info->pplib.sThermalController); +if (power_info->pplib.ucNumStates ==0 ) +return state_index; rdev->pm.power_state =kzalloc (sizeof (struct radeon_power_state ) * power_info->pplib.ucNumStates,GFP_KERNEL );if (!rdev->pm.power_state)
@@ -2530,6 +2534,8 @@ static int radeon_atombios_parse_power_t non_clock_info_array = (struct _NonClockInfoArray *) (mode_info->atom_context->bios + data_offset +le16_to_cpu (power_info->pplib.usNonClockInfoArrayOffset)); +if (state_array->ucNumEntries ==0 ) +return state_index; rdev->pm.power_state =kzalloc (sizeof (struct radeon_power_state ) * state_array->ucNumEntries,GFP_KERNEL );if (!rdev->pm.power_state)
@@ -2620,7 +2626,9 @@ void radeon_atombios_get_power_modes(strdefault :break ; } - }else { + } + +if (state_index ==0 ) { rdev->pm.power_state =kzalloc (sizeof (struct radeon_power_state ),GFP_KERNEL );if (rdev->pm.power_state) { rdev->pm.power_state[0].clock_info =
Greg Kroah-Hartman
maintainerPATCH 65/73 drm/radeon: add new richland pci ids
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 62d1f92e06aef9665d71ca7e986b3047ecf0b3c7 upstream.
--- drivers/gpu/drm/radeon/ni.c | 6 ++++-- include/drm/drm_pciids.h | 2 ++ 2 files changed, 6 insertions(+), 2 deletions(-)
drivers/gpu/drm/radeon/ni.c +4 -2
@@ -471,7 +471,8 @@ static void cayman_gpu_init(struct radeo (rdev->pdev->device ==0x990F ) || (rdev->pdev->device ==0x9910 ) || (rdev->pdev->device ==0x9917 ) || - (rdev->pdev->device == 0x9999)) { + (rdev->pdev->device ==0x9999 ) || + (rdev->pdev->device == 0x999C)) { rdev->config.cayman.max_simds_per_se = 6; rdev->config.cayman.max_backends_per_se =2 ; } else if ((rdev->pdev->device == 0x9903) ||
@@ -480,7 +481,8 @@ static void cayman_gpu_init(struct radeo (rdev->pdev->device ==0x990D ) || (rdev->pdev->device ==0x990E ) || (rdev->pdev->device ==0x9913 ) || - (rdev->pdev->device == 0x9918)) { + (rdev->pdev->device ==0x9918 ) || + (rdev->pdev->device == 0x999D)) { rdev->config.cayman.max_simds_per_se = 4; rdev->config.cayman.max_backends_per_se =2 ; } else if ((rdev->pdev->device == 0x9919) ||
include/drm/drm_pciids.h +2 -0
@@ -593,6 +593,8 @@ {0x1002, 0x9999, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_ARUBA|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ {0x1002, 0x999A, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_ARUBA|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ {0x1002, 0x999B, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_ARUBA|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ + {0x1002, 0x999C, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_ARUBA|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ + {0x1002, 0x999D, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_ARUBA|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ {0x1002, 0x99A0, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_ARUBA|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ {0x1002, 0x99A2, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_ARUBA|RADEON_IS_MOBILITY|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \ {0x1002, 0x99A4, PCI_ANY_ID, PCI_ANY_ID, 0, 0, CHIP_ARUBA|RADEON_NEW_MEMMAP|RADEON_IS_IGP}, \
Greg Kroah-Hartman
maintainerPATCH 66/73 drm/radeon: fix handling of v6 power tables
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alex Deucher <[email protected]>
commit 441e76ca83ac604eaf0f046def96d8e3a27eea28 upstream.
The code was mis-handling variable sized arrays.
--- drivers/gpu/drm/radeon/radeon_atombios.c | 11 +++++------ 1 file changed, 5 insertions(+), 6 deletions(-)
drivers/gpu/drm/radeon/radeon_atombios.c +5 -6
@@ -2518,6 +2518,7 @@ static int radeon_atombios_parse_power_tint index =GetIndexIntoMasterTable (DATA , PowerPlayInfo);u16 data_offset;u8 frev, crev; +u8 *power_state_offset;if (!atom_parse_data_header (mode_info->atom_context, index,NULL , &frev, &crev, &data_offset))
@@ -2540,11 +2541,11 @@ static int radeon_atombios_parse_power_t state_array->ucNumEntries, GFP_KERNEL);if (!rdev->pm.power_state)return state_index; + power_state_offset = (u8 *)state_array->states;for (i =0 ; i < state_array->ucNumEntries; i++) { mode_index =0 ; - power_state = (union pplib_power_state *)&state_array->states[i]; -/* XXX this might be an inagua bug... */ - non_clock_array_index = i;/* power_state->v2.nonClockInfoIndex */ + power_state = (union pplib_power_state *)power_state_offset; + non_clock_array_index = power_state->v2.nonClockInfoIndex; non_clock_info = (struct _ATOM_PPLIB_NONCLOCK_INFO *) &non_clock_info_array->nonClockInfo[non_clock_array_index]; rdev->pm.power_state[i].clock_info = kzalloc(sizeof(struct radeon_pm_clock_info) *
@@ -2556,9 +2557,6 @@ static int radeon_atombios_parse_power_tif (power_state->v2.ucNumDPMLevels) {for (j =0 ; j < power_state->v2.ucNumDPMLevels; j++) { clock_array_index = power_state->v2.clockInfoIndex[j]; -/* XXX this might be an inagua bug... */ -if (clock_array_index >= clock_info_array->ucNumEntries) -continue ; clock_info = (union pplib_clock_info *) &clock_info_array->clockInfo[clock_array_index * clock_info_array->ucEntrySize]; valid = radeon_atombios_parse_pplib_clock_info(rdev,
@@ -2580,6 +2578,7 @@ static int radeon_atombios_parse_power_t non_clock_info); state_index++; } + power_state_offset +=2 + power_state->v2.ucNumDPMLevels; }/* if multiple clock modes, mark the lowest as no display */ for (i =0 ; i < state_index; i++) {
Greg Kroah-Hartman
maintainerPATCH 67/73 tracing: Fix ftrace_dump()
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Steven Rostedt (Red Hat)" <[email protected]>
commit 7fe70b579c9e3daba71635e31b6189394e7b79d3 upstream.
ftrace_dump() had a lot of issues. What ftrace_dump() does, is when ftrace_dump_on_oops is set (via a kernel parameter or sysctl), it will dump out the ftrace buffers to the console when either a oops, panic, or a sysrq-z occurs.
This was written a long time ago when ftrace was fragile to recursion. But it wasn't written well even for that.
There's a possible deadlock that can occur if a ftrace_dump() is happening and an NMI triggers another dump. This is because it grabs a lock before checking if the dump ran.
It also totally disables ftrace, and tracing for no good reasons.
As the ring_buffer now checks if it is read via a oops or NMI, where there's a chance that the buffer gets corrupted, it will disable itself. No need to have ftrace_dump() do the same.
ftrace_dump() is now cleaned up where it uses an atomic counter to make sure only one dump happens at a time. A simple atomic_inc_return() is enough that is needed for both other CPUs and NMIs. No need for a spinlock, as if one CPU is running the dump, no other CPU needs to do it too.
The tracing_on variable is turned off and not turned on. The original code did this, but it wasn't pretty. By just disabling this variable we get the result of not seeing traces that happen between crashes.
For sysrq-z, it doesn't get turned on, but the user can always write a '1' to the tracing_on file. If they are using sysrq-z, then they should know about tracing_on.
The new code is much easier to read and less error prone. No more deadlock possibility when an NMI triggers here.
--- kernel/trace/trace.c | 62 +++++++++++++++++------------------------- kernel/trace/trace_selftest.c | 9 +++--- 2 files changed, 31 insertions(+), 40 deletions(-)
kernel/trace/trace.c +26 -36
@@ -5020,36 +5020,32 @@ void trace_init_global_iter(struct trace iter->cpu_file =TRACE_PIPE_ALL_CPU ; } -static void -__ftrace_dump (bool disable_tracing,enum ftrace_dump_mode oops_dump_mode) +void ftrace_dump (enum ftrace_dump_mode oops_dump_mode) { -static arch_spinlock_t ftrace_dump_lock = - (arch_spinlock_t )__ARCH_SPIN_LOCK_UNLOCKED;/* use static because iter can be a bit big for the stack */ static struct trace_iterator iter; +static atomic_t dump_running;unsigned int old_userobj; -static int dump_ran;unsigned long flags;int cnt =0 , cpu; -/* only one dump */ -local_irq_save (flags); -arch_spin_lock (&ftrace_dump_lock); -if (dump_ran) - goto out; - - dump_ran =1 ; +/* Only allow one dump user at a time. */ +if (atomic_inc_return (&dump_running) !=1 ) { +atomic_dec (&dump_running); +return ; + } +/* +* Always turn off tracing when we dump. +* We don't need to show trace output of what happens +* between multiple crashes. +* +* If the user does a sysrq-z, then they can re-enable +* tracing with echo 1 > tracing_on. +*/ tracing_off (); -/* Did function tracer already get disabled? */ -if (ftrace_is_dead ()) { -printk ("# WARNING: FUNCTION TRACING IS CORRUPTED\n" ); -printk ("# MAY BE MISSING FUNCTION EVENTS\n" ); - } - -if (disable_tracing) -ftrace_kill (); +local_irq_save (flags);trace_init_global_iter (&iter);
@@ -5082,6 +5078,12 @@ __ftrace_dump(bool disable_tracing, enumprintk (KERN_TRACE "Dumping ftrace buffer:\n" ); +/* Did function tracer already get disabled? */ +if (ftrace_is_dead ()) { +printk ("# WARNING: FUNCTION TRACING IS CORRUPTED\n" ); +printk ("# MAY BE MISSING FUNCTION EVENTS\n" ); + } +/* * We need to stop all tracing on all CPUS to read the * the next buffer. This is a bit expensive, but is
@@ -5121,26 +5123,14 @@ __ftrace_dump(bool disable_tracing, enumprintk (KERN_TRACE "---------------------------------\n" ); out_enable: -/* Re-enable tracing if requested */ -if (!disable_tracing) { - trace_flags |= old_userobj; + trace_flags |= old_userobj; -for_each_tracing_cpu (cpu) { -atomic_dec (&iter.tr->data[cpu]->disabled); - } -tracing_on (); +for_each_tracing_cpu (cpu) { +atomic_dec (&iter.tr->data[cpu]->disabled); } - - out: -arch_spin_unlock (&ftrace_dump_lock); +atomic_dec (&dump_running);local_irq_restore (flags); } - -/* By default: disable tracing after the dump */ -void ftrace_dump (enum ftrace_dump_mode oops_dump_mode) -{ -__ftrace_dump (true, oops_dump_mode); -}EXPORT_SYMBOL_GPL (ftrace_dump);__init static int tracer_alloc_buffers (void )
kernel/trace/trace_selftest.c +5 -4
@@ -702,8 +702,6 @@ trace_selftest_startup_function(struct t/* Maximum number of functions to trace before diagnosing a hang */ #define GRAPH_MAX_FUNC_TEST 100000000 -static void -__ftrace_dump (bool disable_tracing,enum ftrace_dump_mode oops_dump_mode);static unsigned int graph_hang_thresh;/* Wrap the real function entry probe to avoid possible hanging */
@@ -713,8 +711,11 @@ static int trace_graph_entry_watchdog(stif (unlikely (++graph_hang_thresh >GRAPH_MAX_FUNC_TEST )) {ftrace_graph_stop ();printk (KERN_WARNING "BUG: Function graph tracer hang!\n" ); -if (ftrace_dump_on_oops) -__ftrace_dump (false,DUMP_ALL ); +if (ftrace_dump_on_oops) { +ftrace_dump (DUMP_ALL ); +/* ftrace_dump() disables tracing */ +tracing_on (); + }return 0 ; }
Greg Kroah-Hartman
maintainerPATCH 68/73 Btrfs: compare relevant parts of delayed tree refs
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Josef Bacik <[email protected]>
commit 41b0fc42800569f63e029549b75c4c9cb63f2dfd upstream.
A user reported a panic while running a balance. What was happening was he was relocating a block, which added the reference to the relocation tree. Then relocation would walk through the relocation tree and drop that reference and free that block, and then it would walk down a snapshot which referenced the same block and add another ref to the block. The problem is this was all happening in the same transaction, so the parent block was free'ed up when we drop our reference which was immediately available for allocation, and then it was used _again_ to add a reference for the same block from a different snapshot. This resulted in something like this in the delayed ref tree
add ref to 90234880, parent=2067398656, ref_root 1766, level 1 del ref to 90234880, parent=2067398656, ref_root 18446744073709551608, level 1 add ref to 90234880, parent=2067398656, ref_root 1767, level 1
as you can see the ref_root's don't match, because when we inc the ref we use the header owner, which is the original tree the block belonged to, instead of the data reloc tree. Then when we remove the extent we use the reloc tree objectid. But none of this matters, since it is a shared reference which means only the parent matters. When the delayed ref stuff runs it adds all the increments first, and then does all the drops, to make sure that we don't delete the ref if we net a positive ref count. But tree blocks aren't allowed to have multiple refs from the same block, so this panics when it tries to add the second ref. We need the add and the drop to cancel each other out in memory so we only do the final add.
So to fix this we need to adjust how the delayed refs are added to the tree. Only the ref_root matters when it is a normal backref, and only the parent matters when it is a shared backref. So make our decision based on what ref type we have. This allows us to keep the ref_root in memory in case anybody wants to use it for something else, and it allows the delayed refs to be merged properly so we don't end up with this panic.
With this patch the users image no longer panics on mount, and it has a clean fsck after a normal mount/umount cycle. Thanks,
--- fs/btrfs/delayed-ref.c | 24 ++++++++++++++---------- 1 file changed, 14 insertions(+), 10 deletions(-)
fs/btrfs/delayed-ref.c +14 -10
@@ -36,16 +36,19 @@* compare two delayed tree backrefs with same bytenr and type */ static int comp_tree_refs (struct btrfs_delayed_tree_ref *ref2, -struct btrfs_delayed_tree_ref *ref1) +struct btrfs_delayed_tree_ref *ref1,int type) { -if (ref1->root < ref2->root) -return -1 ; -if (ref1->root > ref2->root) -return 1 ; -if (ref1->parent < ref2->parent) -return -1 ; -if (ref1->parent > ref2->parent) -return 1 ; +if (type ==BTRFS_TREE_BLOCK_REF_KEY ) { +if (ref1->root < ref2->root) +return -1 ; +if (ref1->root > ref2->root) +return 1 ; + }else { +if (ref1->parent < ref2->parent) +return -1 ; +if (ref1->parent > ref2->parent) +return 1 ; + }return 0 ; }
@@ -109,7 +112,8 @@ static int comp_entry(struct btrfs_delayif (ref1->type ==BTRFS_TREE_BLOCK_REF_KEY || ref1->type ==BTRFS_SHARED_BLOCK_REF_KEY ) {return comp_tree_refs (btrfs_delayed_node_to_tree_ref (ref2), -btrfs_delayed_node_to_tree_ref (ref1)); +btrfs_delayed_node_to_tree_ref (ref1), + ref1->type); }else if (ref1->type ==BTRFS_EXTENT_DATA_REF_KEY || ref1->type ==BTRFS_SHARED_DATA_REF_KEY ) { return comp_data_refs(btrfs_delayed_node_to_data_ref(ref2),
Greg Kroah-Hartman
maintainerPATCH 69/73 Btrfs: fix extent logging with O_DIRECT into prealloc
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Josef Bacik <[email protected]>
commit eb384b55ae9c2055ea00c5cc87971e182d47aefa upstream.
This is the same as the fix from commit
Btrfs: fix bad extent logging
but for O_DIRECT. I missed this when I fixed the problem originally, we were still using the em for the orig_start and orig_block_len, which would be the merged extent. We need to use the actual extent from the on disk file extent item, which we have to lookup to make sure it's ok to nocow anyway so just pass in some pointers to hold this info. Thanks,
--- fs/btrfs/inode.c | 21 +++++++++++++-------- 1 file changed, 13 insertions(+), 8 deletions(-)
fs/btrfs/inode.c +13 -8
@@ -5794,7 +5794,9 @@ out:* block must be cow'd */ static noinline int can_nocow_odirect(struct btrfs_trans_handle *trans, -struct inode *inode,u64 offset,u64 len) +struct inode *inode,u64 offset,u64 *len, +u64 *orig_start,u64 *orig_block_len, +u64 *ram_bytes) {struct btrfs_path *path;int ret;
@@ -5851,8 +5853,12 @@ static noinline int can_nocow_odirect(st disk_bytenr =btrfs_file_extent_disk_bytenr (leaf, fi); backref_offset =btrfs_file_extent_offset (leaf, fi); + *orig_start = key.offset - backref_offset; + *orig_block_len =btrfs_file_extent_disk_num_bytes (leaf, fi); + *ram_bytes =btrfs_file_extent_ram_bytes (leaf, fi); + extent_end = key.offset +btrfs_file_extent_num_bytes (leaf, fi); -if (extent_end < offset + len) { +if (extent_end < offset + *len) {/* extent doesn't include our full range, must cow */ goto out; }
@@ -5876,13 +5882,14 @@ static noinline int can_nocow_odirect(st*/ disk_bytenr += backref_offset; disk_bytenr += offset - key.offset; - num_bytes =min (offset + len, extent_end) - offset; + num_bytes =min (offset + *len, extent_end) - offset;if (csum_exist_in_range (root, disk_bytenr, num_bytes)) goto out;/* * all of the above have passed, it is safe to overwrite this extent * without cow */ + *len = num_bytes; ret =1 ; out:btrfs_free_path (path);
@@ -6092,7 +6099,7 @@ static int btrfs_get_blocks_direct(struc em->block_start != EXTENT_MAP_HOLE)) {int type;int ret; -u64 block_start; +u64 block_start, orig_start, orig_block_len, ram_bytes;if (test_bit (EXTENT_FLAG_PREALLOC , &em->flags)) type =BTRFS_ORDERED_PREALLOC ;
@@ -6110,10 +6117,8 @@ static int btrfs_get_blocks_direct(strucif (IS_ERR (trans)) goto must_cow; -if (can_nocow_odirect (trans, inode, start, len) ==1 ) { -u64 orig_start = em->orig_start; -u64 orig_block_len = em->orig_block_len; - +if (can_nocow_odirect (trans, inode, start, &len, &orig_start, + &orig_block_len, &ram_bytes) ==1 ) {if (type ==BTRFS_ORDERED_PREALLOC ) {free_extent_map (em); em = create_pinned_em(inode, start, len,
Greg Kroah-Hartman
maintainerPATCH 70/73 EDAC: Dont give write permission to read-only files
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: "Srivatsa S. Bhat" <[email protected]>
commit c8c64d165ccfd2274058ac84e0c680f9b48c4ec1 upstream.
I get the following warning on boot:
------------[ cut here ]------------ WARNING: at drivers/base/core.c:575 device_create_file+0x9a/0xa0() Hardware name: -[8737R2A]-
Write permission without 'store'
...
</snip>
Drilling down, this is related to dynamic channel ce_count attribute files sporting a S_IWUSR mode without a ->store() function. Looking around, it appears that they aren't supposed to have a ->store() function. So remove the bogus write permission to get rid of the warning.
--- drivers/edac/edac_mc_sysfs.c | 12 ++++++------ 1 file changed, 6 insertions(+), 6 deletions(-)
drivers/edac/edac_mc_sysfs.c +6 -6
@@ -330,17 +330,17 @@ static struct device_attribute *dynamic_ };/* possible dynamic channel ce_count attribute files */ -DEVICE_CHANNEL (ch0_ce_count,S_IRUGO |S_IWUSR , +DEVICE_CHANNEL (ch0_ce_count,S_IRUGO , channel_ce_count_show,NULL ,0 ); -DEVICE_CHANNEL (ch1_ce_count,S_IRUGO |S_IWUSR , +DEVICE_CHANNEL (ch1_ce_count,S_IRUGO , channel_ce_count_show,NULL ,1 ); -DEVICE_CHANNEL (ch2_ce_count,S_IRUGO |S_IWUSR , +DEVICE_CHANNEL (ch2_ce_count,S_IRUGO , channel_ce_count_show,NULL ,2 ); -DEVICE_CHANNEL (ch3_ce_count,S_IRUGO |S_IWUSR , +DEVICE_CHANNEL (ch3_ce_count,S_IRUGO , channel_ce_count_show,NULL ,3 ); -DEVICE_CHANNEL (ch4_ce_count,S_IRUGO |S_IWUSR , +DEVICE_CHANNEL (ch4_ce_count,S_IRUGO , channel_ce_count_show,NULL ,4 ); -DEVICE_CHANNEL (ch5_ce_count,S_IRUGO |S_IWUSR , +DEVICE_CHANNEL (ch5_ce_count,S_IRUGO , channel_ce_count_show,NULL ,5 );/* Total possible dynamic ce_count attribute file table */
Greg Kroah-Hartman
maintainerPATCH 71/73 NFSv4.x: Fix handling of partially delegated locks
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Trond Myklebust <[email protected]>
commit c5a2a15f8146fdfe45078df7873a6dc1006b3869 upstream.
If a NFS client receives a delegation for a file after it has taken a lock on that file, we can currently end up in a situation where we mistakenly skip unlocking that file.
The following patch swaps an erroneous check in nfs4_proc_unlck for whether or not the file has a delegation to one which checks whether or not we hold a lock stateid for that file.
--- fs/nfs/nfs4proc.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-)
fs/nfs/nfs4proc.c +2 -2
@@ -4513,9 +4513,9 @@ static int nfs4_proc_unlck(struct nfs4_sif (status !=0 ) goto out;/* Is this a delegated lock? */ -if (test_bit (NFS_DELEGATED_STATE , &state->flags)) - goto out; lsp = request->fl_u.nfs4_fl.owner; +if (test_bit (NFS_LOCK_INITIALIZED , &lsp->ls_flags) ==0 ) + goto out; seqid =nfs_alloc_seqid (&lsp->ls_seqid,GFP_KERNEL ); status = -ENOMEM ;if (seqid ==NULL )
Greg Kroah-Hartman
maintainerPATCH 72/73 kernel/audit_tree.c: tree will leak memory when failure occurs in audit_trim_trees()
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Chen Gang <[email protected]>
commit 12b2f117f3bf738c1a00a6f64393f1953a740bd4 upstream.
audit_trim_trees() calls get_tree(). If a failure occurs we must call put_tree().
--- kernel/audit_tree.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)
kernel/audit_tree.c +1 -1
@@ -617,9 +617,9 @@ void audit_trim_trees(void) }spin_unlock (&hash_lock);trim_marked (tree); -put_tree (tree);drop_collected_mounts (root_mnt); skip_it: +put_tree (tree);mutex_lock (&audit_filter_mutex); }list_del (&cursor);
Greg Kroah-Hartman
maintainerPATCH 73/73 x86/mm: account for PGDIR_SIZE alignment
In reply to Greg Kroah-Hartman3.8-stable review patch. If anyone has any objections, please let me know.
------------------
From: Jerry Hoemann <[email protected]>
Patch for -stable. Function find_early_table_space removed upstream.
Fixes panic in alloc_low_page due to pgt_buf overflow during init_memory_mapping.
find_early_table_space sizes pgt_buf based upon the size of the memory being mapped, but it does not take into account the alignment of the memory. When the region being mapped spans a 512GB (PGDIR_SIZE) alignment, a panic from alloc_low_pages occurs.
kernel_physical_mapping_init takes into account PGDIR_SIZE alignment. This causes an extra call to alloc_low_page to be made. This extra call isn't accounted for by find_early_table_space and causes a kernel panic.
Change is to take into account PGDIR_SIZE alignment in find_early_table_space.
--- arch/x86/mm/init.c | 5 +++++ 1 file changed, 5 insertions(+)
arch/x86/mm/init.c +5 -0
@@ -45,11 +45,15 @@ static void __init find_early_table_spacint i;unsigned long puds =0 , pmds =0 , ptes =0 , tables;unsigned long start =0 , good_end; +unsigned long pgd_extra =0 ;phys_addr_t base;for (i =0 ; i < nr_range; i++) {unsigned long range, extra; +if ((mr[i].end >>PGDIR_SHIFT ) - (mr[i].start >>PGDIR_SHIFT )) + pgd_extra++; + range = mr[i].end - mr[i].start; puds += (range +PUD_SIZE -1 ) >>PUD_SHIFT ;
@@ -74,6 +78,7 @@ static void __init find_early_table_spac tables =roundup (puds *sizeof (pud_t),PAGE_SIZE ); tables +=roundup (pmds *sizeof (pmd_t),PAGE_SIZE ); tables +=roundup (ptes *sizeof (pte_t),PAGE_SIZE ); + tables += (pgd_extra *PAGE_SIZE );#ifdef CONFIG_X86_32 /* for fixmap */
Quoted 1 line · Greg Kroah-Hartman
This is the start of the stable review cycle for the 3.8.13 release. There
This patchset broke my internet, with all sorts of weird effects like Samba clients having problems to talk to the server and only partially working DNS resolution (CDNs broken, Amazon unreachable).
After two reboots to/from .12/.13 (to rule out temporary internet brokenness) the problem has been identified as:
Quoted 2 lines
Stefan Bader <[email protected]>
r8169: fix 8168evl frame padding.
After reverting only this patch (turning r8169 back to 3.8.12) things again behave as expected with the rest of .13. So far no other regressions detected.
This patch should probably be removed from 3.9.2-rc as well.
-h
Quoted 14 lines · Greg Kroah-Hartman
--------------------
NOTE: This is the LAST 3.8.y kernel release to be done by me. After this one, it is end-of-life. You should have moved on to the 3.9.y kernel series by now.
--------------------This is the start of the stable review cycle for the 3.8.13 release. There are 73 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat May 11 22:26:18 UTC 2013. Anything received after that time might be too late.
Quoted 7 lines
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v3.0/stable-review/patch-3.8.13-rc1.gzand the diffstat can be found below.
thanks,
greg k-h
Patches applied cleanly to 3.0.77, 3.4.44, 3.8.12, and 3.9.1
Compiled and booted on the following systems:
Samsung Series 9 900X4C Intel Corei5:
(3.4.45-rc1, 3.8.13-rc1, and 3.9.2-rc1)
HP ProBook 6475b AMD A10-4600M APU with Radeon(tm) HD Graphics:
(3.0.78-rc1, 3.4.45-rc1, 3.8.13-rc1, and 3.9.2-rc1)dmesgs for all releases look good. No regressions compared to the previous dmesgs for each of these releases.
Cross-compile testing:
HP Compaq dc7700 SFF desktop: x86-64 Intel Core-i2:
(3.0.78-rc1, 3.4.45-rc1, 3.8.13-rc1, and 3.9.2-rc1)
Cross-compile tests results:
alpha: defconfig passed on all
arm: defconfig passed on all
arm64: not applicable to 3.0.y, 3.4.y. defconfig passed on 3.8.y, and 3.9.y
c6x: not applicable to 3.0.y, defconfig passed on 3.4.y, 3.8.y, and 3.9.y
mips: defconfig passed on all
mipsel: defconfig passed on all
powerpc: wii_defconfig passed on all
sh: defconfig passed on all
sparc: defconfig passed on all
tile: tilegx_defconfig passed on all
thanks,
-- Shuah
Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research America (Silicon Valley) [email protected] | (970) 672-0658
At Thu, 9 May 2013 15:31:23 -0700,
Quoted 7 lines · Greg Kroah-Hartman
--------------------
NOTE: This is the LAST 3.8.y kernel release to be done by me. After this one, it is end-of-life. You should have moved on to the 3.9.y kernel series by now.
--------------------
Quoted 7 lines
This is the start of the stable review cycle for the 3.8.13 release. There are 73 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Sat May 11 22:26:18 UTC 2013. Anything received after that time might be too late.
This kernel can be built and boot without any problem. Building a kernel with this kernel also works fine.
- Build Machine: debian wheezy x86_64
CPU: Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz x 4
memory: 8GB
- Test machine: debian wheezy x86_64(KVM guest on the Build Machine)
vCPU: x2
memory: 2GB
I reviewed the following patches and it looks good to me.
Quoted 2 lines
Chen Gang <[email protected]>
kernel/audit_tree.c: tree will leak memory when failure occurs inaudit_trim_trees()
...
Quoted 2 lines
Joerg Roedel <[email protected]>
iommu/amd: Properly initialize irq-table lock
Thanks,
Satoru
r8169 on 3.8.13, 3.9.2, 3.10-rc1, was Re: [ 00/73] 3.8.13-stable review
In reply to Holger HoffstaetteOn Fri, May 10, 2013 at 12:54:27PM +0200, Holger Hoffstaette wrote:
Cc'ing to netdev because I don't think this has had a response, and
I care because I *might* be seeing the same problem on both 3.9.2 and 3.10-rc1, but my take on the problem is slightly different [ details after Holger's posting ]
Quoted 14 lines · Greg Kroah-Hartman
Quoted 2 lines
This is the start of the stable review cycle for the 3.8.13 release. There
This patchset broke my internet, with all sorts of weird effects like Samba clients having problems to talk to the server and only partially working DNS resolution (CDNs broken, Amazon unreachable).
After two reboots to/from .12/.13 (to rule out temporary internet brokenness) the problem has been identified as:
Quoted 2 lines
Stefan Bader <[email protected]>
r8169: fix 8168evl frame padding.
Quoted 8 lines
After reverting only this patch (turning r8169 back to 3.8.12) things again behave as expected with the rest of .13. So far no other regressions detected.
This patch should probably be removed from 3.9.2-rc as well.
-h
For me, I'm seeing what might be a similar problem in about 2/5 of
my boots of 3.9.2 and 3.10-rc1 : in my case, r8169 is a module [ most things are built in ], I use dhclient to get an ip address, and I have separate nfs shares for /sources [ in /etc/mtab ] and my user's ~/notes [ mounted from ~/.bashrc ].
On a good boot, everything mounts. On a bad boot, /sources is NOT
mounted because eth0 is not up, but by the time anyone logs in it _is_ up so mounting ~/notes [and manually mounting /sources as root] works. What seems to be happening is that eth0 is coming up slightly later on some occasions (about 11 seconds from booting, instead of 10.5 seconds) and somehow the dhclient script seems to have ended *before* that.
For me, this isn't bisectable (so far, 10 boots of 3.9.2 and
3.10-rc1 on this box, and 4 were problematic). On this box, 3.9.0 itself was perfect.
Holger : apologies if I've hijacked this thread with what turns out to be a different problem.
ken
Signature · 1 line
das eine Mal als Tragödie, das andere Mal als Farce
Re: r8169 on 3.8.13, 3.9.2, 3.10-rc1, was Re: [ 00/73] 3.8.13-stable review
Ken Moffat <[email protected]> :
[...]
Quoted 1 line
Cc'ing to netdev because I don't think this has had a response, and
A patch has been sent to netdev a few hours ago. It needs more work, especially testing (hint, hint) as I don't have a proven test case yet.
Please note:
- if you don't use a 8168evl (check your dmesg for the XID line emitted by the r8169 driver), you are not the experiencing the same bug.
- if you don't enable Tx checksum offload (distro/vendor dependent though disabled by default in the vanilla driver, see ethtool -k eth0, ethtool -K eth0 tx on sg on)), you are not the experiencing the same bug.
- if you are experiencing the same bug, 3.10-rc1 should work again after reverting e5195c1f31f399289347e043d6abf3ffa80f0005
If someone comes with a failing network capture and a working one, it will save time. A 64 bytes (max) packet is not correctly transmitted.
Signature · 1 line
Ueimor
Re: r8169 on 3.8.13, 3.9.2, 3.10-rc1, was Re: [ 00/73] 3.8.13-stable review
In reply to Ken MoffatQuoted 4 lines · Ken Moffat
Cc'ing to netdev because I don't think this has had a response, and
I care because I *might* be seeing the same problem on both 3.9.2 and 3.10-rc1, but my take on the problem is slightly different [ details after Holger's posting ]
I later isolated the regression to tx offloading, which allows one to reproduce the problem on the fly (enable: b0rken internets, disable: all fine). So unless you have tx offloading enabled then whatever you are seeing has likely nothing to do with *this* problem.
Francois posted a patch to -netdev which I am running as we speak, and the problem seems fixed for me; tx offloading (in adition to rx/gro) works again, with no side effects. Please help test!
-h
Re: r8169 on 3.8.13, 3.9.2, 3.10-rc1, was Re: [ 00/73] 3.8.13-stable review
In reply to Francois RomieuQuoted 10 lines · Francois Romieu
Ken Moffat <[email protected]> :
[...]Quoted 1 line
Cc'ing to netdev because I don't think this has had a response, and
A patch has been sent to netdev a few hours ago. It needs more work, especially testing (hint, hint) as I don't have a proven test case yet.
Please note:
- if you don't use a 8168evl (check your dmesg for the XID line emitted by the r8169 driver), you are not the experiencing the same bug.
[ 3.174180] r8169 0000:02:00.0 eth0: RTL8168evl/8111evl at
0xffffc90000008000, c8:60:00:97:07:35, XID 0c900800 IRQ 41
Quoted 4 lines
- if you don't enable Tx checksum offload (distro/vendor dependent though disabled by default in the vanilla driver, see ethtool -k eth0, ethtool -K eth0 tx on sg on)), you are not the experiencing the same bug.
If it is disabled by default then my problem is different (I don't
have an ethtool program)
Quoted 8 lines
- if you are experiencing the same bug, 3.10-rc1 should work again after reverting
e5195c1f31f399289347e043d6abf3ffa80f0005If someone comes with a failing network capture and a working one, it will save time. A 64 bytes (max) packet is not correctly transmitted.
Signature · 1 line
Ueimor
Thanks for the detailed comments, looks as if my intermittent
problem is something else.
ken
Signature · 1 line
das eine Mal als Tragödie, das andere Mal als Farce
David Miller
maintainerRe: r8169 on 3.8.13, 3.9.2, 3.10-rc1, was Re: [ 00/73] 3.8.13-stable review
In reply to Francois RomieuFrom: Francois Romieu <[email protected]>
Date: Wed, 15 May 2013 08:14:01 +0200
Quoted 17 lines
Ken Moffat <[email protected]> :
[...]Quoted 1 line
Cc'ing to netdev because I don't think this has had a response, and
A patch has been sent to netdev a few hours ago. It needs more work, especially testing (hint, hint) as I don't have a proven test case yet.
Please note:
- if you don't use a 8168evl (check your dmesg for the XID line emitted by the r8169 driver), you are not the experiencing the same bug.
- if you don't enable Tx checksum offload (distro/vendor dependent though disabled by default in the vanilla driver, see ethtool -k eth0, ethtool -K eth0 tx on sg on)), you are not the experiencing the same bug.
- if you are experiencing the same bug, 3.10-rc1 should work again after revertinge5195c1f31f399289347e043d6abf3ffa80f0005
Quoted 2 lines
If someone comes with a failing network capture and a working one, it will save time. A 64 bytes (max) packet is not correctly transmitted.
FWIW, I was about to submit the regression causing commit to -stable but now I'm going to hold off until we get the fix for it to Linus.
David Miller
maintainerRe: r8169 on 3.8.13, 3.9.2, 3.10-rc1, was Re: [ 00/73] 3.8.13-stable review
From: David Miller <[email protected]>
Date: Wed, 15 May 2013 13:39:13 -0700 (PDT)
Quoted 20 lines
From: Francois Romieu <[email protected]>
Date: Wed, 15 May 2013 08:14:01 +0200Quoted 17 lines
Ken Moffat <[email protected]> :
[...]Quoted 1 line
Cc'ing to netdev because I don't think this has had a response, and
A patch has been sent to netdev a few hours ago. It needs more work, especially testing (hint, hint) as I don't have a proven test case yet.
Please note:
- if you don't use a 8168evl (check your dmesg for the XID line emitted by the r8169 driver), you are not the experiencing the same bug.
- if you don't enable Tx checksum offload (distro/vendor dependent though disabled by default in the vanilla driver, see ethtool -k eth0, ethtool -K eth0 tx on sg on)), you are not the experiencing the same bug.
- if you are experiencing the same bug, 3.10-rc1 should work again after revertinge5195c1f31f399289347e043d6abf3ffa80f0005
Quoted 5 lines
Quoted 2 lines
If someone comes with a failing network capture and a working one, it will save time. A 64 bytes (max) packet is not correctly transmitted.
FWIW, I was about to submit the regression causing commit to -stable but now I'm going to hold off until we get the fix for it to Linus.
Oh, I see, someone merged it behind my back.
Well, guys, now do you see why I let patches cook in Linus's tree for a week or two before I submit them to Linus?
It's so that bugs like this are less likely to propagate, and we find them such problems and fix them before a change hits -stable and therefore has an effect on an even larger number of users.
Please, use the networking -stable submission process. If you want a patch merged, tell me, and I'll queue it up in patchwork.