Skip to contentSkip to conversation

NTB bug fixes for v3.10

GIT PULL Jon Mason 2 participants 3 messages May 11, 2013 – May 16, 2013

lore
Share & tools
lore

Jon Mason

author
#0 lore raw

Hi Linus,
Below are a number of NTB bug fixes for v3.10. These correct a few Smatch/Coverity errors, as well as addressing some other issues in the NTB driver.

Thanks,
Jon

The following changes since commit c1be5a5b1b355d40e6cf79cc979eb66dafa24ad1:

Linux 3.9 (2013-04-28 17:36:01 -0700)

are available in the git repository at:

https://github.com/jonmason/ntb.git for-linus

for you to fetch changes up to 877b38d4f052a2927a900eb0733ad7d749bd0d00:

NTB: Multiple NTB client fix (2013-05-10 14:33:45 -0700)

----------------------------------------------------------------
Dan Carpenter (2):
ntb: off by one sanity checks
NTB: fix pointer math issues

Jon Mason (8):
NTB: variable dereferenced before check
NTB: Handle 64bit BAR sizes
NTB: Link toggle memory leak
NTB: reset tx_index on link toggle
NTB: Correctly handle receive buffers of the minimal size
NTB: memcpy lockup workaround
ntb_netdev: remove from list on exit
NTB: Multiple NTB client fix

 drivers/net/ntb_netdev.c    |    2 +
 drivers/ntb/ntb_hw.c        |   10 +--
 drivers/ntb/ntb_transport.c |  175 ++++++++++++++++++++++++++++---------------
 3 files changed, 121 insertions(+), 66 deletions(-)
#1 lore raw
Quoted 2 lines · Jon Mason

https://github.com/jonmason/ntb.git for-linus

This has so much wrong that I don't know where to start.

Don't use the https transport unless you have to. Use the "git" one.

Also, that's an unsigned branch from an open hosting site. No. No. No.

If you use github or similar, you need to send me a signed tag, and your pgp key should in turn be signed by some key I recognize. Not this kind of "please pull this random branch from this random site" crap.

Linus

author
#2 lore raw
Quoted 8 lines · Linus Torvalds
Quoted 2 lines · Jon Mason

https://github.com/jonmason/ntb.git for-linus

This has so much wrong that I don't know where to start.

Don't use the https transport unless you have to. Use the "git" one.

Quoted 8 lines

Also, that's an unsigned branch from an open hosting site. No. No. No.

If you use github or similar, you need to send me a signed tag, and your pgp key should in turn be signed by some key I recognize. Not this kind of "please pull this random branch from this random site" crap.

Linus

My apologies. I have corrected the issues you described, and would appreciate you trying again with the updated information below.

Thanks,
Jon

The following changes since commit f722406faae2d073cc1d01063d1123c35425939e:

Linux 3.10-rc1 (2013-05-11 17:14:08 -0700)

are available in the git repository at:

git://github.com/jonmason/ntb.git tags/ntb-bugfixes-3.10

for you to fetch changes up to 8b19d450ad188d402a183ff4a4d40f31c3916fbf:

NTB: Multiple NTB client fix (2013-05-15 10:58:22 -0700)

----------------------------------------------------------------
NTB bug fixes to address Smatch/Coverity errors, link toggling bugs, and a few corner cases in the driver.

----------------------------------------------------------------
Dan Carpenter (2):
ntb: off by one sanity checks
NTB: fix pointer math issues

Jon Mason (8):
NTB: variable dereferenced before check
NTB: Handle 64bit BAR sizes
NTB: Link toggle memory leak
NTB: reset tx_index on link toggle
NTB: Correctly handle receive buffers of the minimal size
NTB: memcpy lockup workaround
ntb_netdev: remove from list on exit
NTB: Multiple NTB client fix

 drivers/net/ntb_netdev.c    |    2 ++
 drivers/ntb/ntb_hw.c        |   10 +++++-----
 drivers/ntb/ntb_transport.c |  175 ++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++-------------------------------------------------------------
 3 files changed, 121 insertions(+), 66 deletions(-)