Skip to contentSkip to conversation

package: Makefile: unbreak binrpm-pkg target

PATCH In review Luiz Capitulino 2 participants 2 messages May 15, 2013 – May 16, 2013 Kbuild

lore
Share & tools
lore
#0 lore raw

PATCH 1/1 package: Makefile: unbreak binrpm-pkg target

Commit 6501320311664e11ad5489fedb17ea1f817c2617 dropped the rpm spec as a prerequisite for the binrpm-pkg target but forgot to update $< usage, which causes the rule to break.

This commit fixes that by replacing $< with the spec name.

---
 scripts/package/Makefile | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)
scripts/package/Makefile +1 -1
index 84a4060..a4f31c9 100644
@@ -63,7 +63,7 @@ binrpm-pkg: FORCE
 	mv -f $(objtree)/.tmp_version $(objtree)/.version
 
 	$(RPM) $(RPMOPTS) --define "_builddir $(objtree)" --target \
-		$(UTS_MACHINE) -bb $<
+		$(UTS_MACHINE) -bb $(objtree)/binkernel.spec
 	rm binkernel.spec
 
 # Deb target
Signature · 1 line
1.8.1.4
#1 lore raw
Quoted 3 lines · Luiz Capitulino

Commit 6501320311664e11ad5489fedb17ea1f817c2617 dropped the rpm spec as a prerequisite for the binrpm-pkg target but forgot to update $< usage, which causes the rule to break.

Oops :)

Quoted 1 line

This commit fixes that by replacing $< with the spec name.

Thanks for the fix, I added it to kbuild.git#rc-fixes.

Michal