Skip to contentSkip to conversation

virtio-spec: tweak wording for console control vq

PATCH Applied Michael S. Tsirkin 2 participants 2 messages May 20, 2013 – May 21, 2013 virtio core

lore
Share & tools
lore

Michael S. Tsirkin

author maintainer
#0 lore raw

PATCH 1/1 virtio-spec: tweak wording for console control vq

control vq is only used if feature bit is
negotiated - it's not enough that device supports
it. Clarify this in the spec.

---
 virtio-spec.lyx | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
virtio-spec.lyx +7 -2
index 921388b..3ef96a9 100644
@@ -6833,8 +6833,13 @@ VIRTIO_CONSOLE_F_SIZE
 
 \begin_layout Description
 VIRTIO_CONSOLE_F_MULTIPORT(1) Device has support for multiple ports; configurati
-on fields nr_ports and max_nr_ports are valid and control virtqueues will
- be used.
+on fields nr_ports and max_nr_ports are valid
+\change_inserted 1986246365 1347188404
+; if this bit is negotiated,
+\change_deleted 1986246365 1347188406
+ and
+\change_unchanged
+ control virtqueues will be used.
 \change_inserted 1112500848 1368412890
 
 \end_layout
Signature · 1 line
MST
#1 lore raw
Quoted 3 lines · Michael S. Tsirkin

control vq is only used if feature bit is
negotiated - it's not enough that device supports
it. Clarify this in the spec.

Thanks, applied.

Cheers,
Rusty.

Quoted 27 lines
---
 virtio-spec.lyx | 9 +++++++--
 1 file changed, 7 insertions(+), 2 deletions(-)
virtio-spec.lyx +7 -2
index 921388b..3ef96a9 100644
@@ -6833,8 +6833,13 @@ VIRTIO_CONSOLE_F_SIZE
 
 \begin_layout Description
 VIRTIO_CONSOLE_F_MULTIPORT(1) Device has support for multiple ports; configurati
-on fields nr_ports and max_nr_ports are valid and control virtqueues will
- be used.
+on fields nr_ports and max_nr_ports are valid
+\change_inserted 1986246365 1347188404
+; if this bit is negotiated,
+\change_deleted 1986246365 1347188406
+ and
+\change_unchanged
+ control virtqueues will be used.
 \change_inserted 1112500848 1368412890
 
 \end_layout
Signature · 1 line
MST