3.0.80-stable review
Subsystems (5)
Greg Kroah-Hartman
maintainercover 3.0.80-stable review
This is the start of the stable review cycle for the 3.0.80 release. There are 3 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri May 24 22:11:00 UTC 2013. Anything received after that time might be too late.
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v3.0/stable-review/patch-3.0.80-rc1.gz
and the diffstat can be found below.
thanks,
greg k-h
-------------
Pseudo-Shortlog of commits:
Greg Kroah-Hartman <[email protected]>
Linux 3.0.80-rc1
Alan Cox <[email protected]>
media: mantis: fix silly crash case
Wei Yongjun <[email protected]>
hwmon: fix error return code in abituguru_probe()
Gabriel de Perthuis <[email protected]>
btrfs: don't stop searching after encountering the wrong item
-------------
Diffstat:
Makefile | 4 ++-- drivers/hwmon/abituguru.c | 16 ++++++++++------ drivers/media/dvb/mantis/mantis_dvb.c | 6 ++++-- fs/btrfs/ioctl.c | 10 +++++----- 4 files changed, 21 insertions(+), 15 deletions(-)
Greg Kroah-Hartman
maintainerPATCH 1/3 btrfs: dont stop searching after encountering the wrong item
3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Gabriel de Perthuis <[email protected]>
commit 03b71c6ca6286625d8f1ed44aabab9b5bf5dac10 upstream.
The search ioctl skips items that are too large for a result buffer, but inline items of a certain size occuring before any search result is found would trigger an overflow and stop the search entirely.
--- fs/btrfs/ioctl.c | 10 +++++----- 1 file changed, 5 insertions(+), 5 deletions(-)
fs/btrfs/ioctl.c +5 -5
@@ -1539,7 +1539,11 @@ static noinline int copy_to_sk(struct bt item_off =btrfs_item_ptr_offset (leaf, i); item_len =btrfs_item_size_nr (leaf, i); -if (item_len >BTRFS_SEARCH_ARGS_BUFSIZE ) +btrfs_item_key_to_cpu (leaf, key, i); +if (!key_in_sk (key, sk)) +continue ; + +if (sizeof (sh) + item_len >BTRFS_SEARCH_ARGS_BUFSIZE ) item_len =0 ; if (sizeof(sh) + item_len + *sk_offset >
@@ -1548,10 +1552,6 @@ static noinline int copy_to_sk(struct bt goto overflow; } -btrfs_item_key_to_cpu (leaf, key, i); -if (!key_in_sk (key, sk)) -continue ; - sh.objectid = key->objectid; sh.offset = key->offset; sh.type = key->type;
Greg Kroah-Hartman
maintainerPATCH 2/3 hwmon: fix error return code in abituguru_probe()
In reply to Greg Kroah-Hartman3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Wei Yongjun <[email protected]>
commit ecacb0b17c08fae89f65468727f0e4b8e91da4e1 upstream.
Fix to return a negative error code from the error handling case instead of 0, as done elsewhere in this function.
--- drivers/hwmon/abituguru.c | 16 ++++++++++------ 1 file changed, 10 insertions(+), 6 deletions(-)
drivers/hwmon/abituguru.c +10 -6
@@ -1280,14 +1280,18 @@ static int __devinit abituguru_probe(strpr_info ("found Abit uGuru\n" );/* Register sysfs hooks */ -for (i =0 ; i < sysfs_attr_i; i++) -if (device_create_file (&pdev->dev, - &data->sysfs_attr[i].dev_attr)) +for (i =0 ; i < sysfs_attr_i; i++) { + res =device_create_file (&pdev->dev, + &data->sysfs_attr[i].dev_attr); +if (res) goto abituguru_probe_error; -for (i =0 ; i <ARRAY_SIZE (abituguru_sysfs_attr); i++) -if (device_create_file (&pdev->dev, - &abituguru_sysfs_attr[i].dev_attr)) + } +for (i =0 ; i <ARRAY_SIZE (abituguru_sysfs_attr); i++) { + res =device_create_file (&pdev->dev, + &abituguru_sysfs_attr[i].dev_attr); +if (res) goto abituguru_probe_error; + } data->hwmon_dev =hwmon_device_register (&pdev->dev);if (!IS_ERR (data->hwmon_dev))
Greg Kroah-Hartman
maintainerPATCH 3/3 media: mantis: fix silly crash case
In reply to Greg Kroah-Hartman3.0-stable review patch. If anyone has any objections, please let me know.
------------------
From: Alan Cox <[email protected]>
commit e1d45ae10aea8e8a403e5d96bf5902ee670007ff upstream.
If we set mantis->fe to NULL on an error its not a good idea to then try passing NULL to the unregister paths and oopsing really.
Resolves-bug: https://bugzilla.kernel.org/show_bug.cgi?id=16473
--- drivers/media/dvb/mantis/mantis_dvb.c | 6 ++++-- 1 file changed, 4 insertions(+), 2 deletions(-)
drivers/media/dvb/mantis/mantis_dvb.c +4 -2
@@ -248,8 +248,10 @@ int __devinit mantis_dvb_init(struct man err5:tasklet_kill (&mantis->tasklet);dvb_net_release (&mantis->dvbnet); -dvb_unregister_frontend (mantis->fe); -dvb_frontend_detach (mantis->fe); +if (mantis->fe) { +dvb_unregister_frontend (mantis->fe); +dvb_frontend_detach (mantis->fe); + } err4: mantis->demux.dmx.remove_frontend (&mantis->demux.dmx, &mantis->fe_mem);
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 3.0.80 release. There are 3 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri May 24 22:11:00 UTC 2013. Anything received after that time might be too late.
Quoted 8 lines
The whole patch series can be found in one patch at:
kernel.org/pub/linux/kernel/v3.0/stable-review/patch-3.0.80-rc1.gzand the diffstat can be found below.
thanks,
greg k-h
Patches applied cleanly to 3.0.79, 3.4.46, and 3.9.3
Compiled and booted on the following systems:
Samsung Series 9 900X4C Intel Corei5:
(3.4.47-rc1, and 3.9.4-rc1)
HP ProBook 6475b AMD A10-4600M APU with Radeon(tm) HD Graphics:
(3.0.80-rc1, 3.4.47-rc1, and 3.9.4-rc1)dmesgs for all releases look good. No regressions compared to the previous dmesgs for each of these releases.
Reviewed patches.
Cross-compile testing:
HP Compaq dc7700 SFF desktop: x86-64 Intel Core-i2:
(3.0.80-rc1, 3.4.47-rc1, and 3.9.4-rc1)
Cross-compile tests results:
alpha: defconfig passed on all
arm: defconfig passed on all
arm64: not applicable to 3.0.y, 3.4.y. defconfig passed on 3.9.y
c6x: not applicable to 3.0.y, defconfig passed on 3.4.y and 3.9.y
mips: defconfig passed on all
mipsel: defconfig passed on all
powerpc: wii_defconfig passed on all
sh: defconfig passed on all
sparc: defconfig passed on all
tile: tilegx_defconfig passed on all
-- Shuah
Shuah Khan, Linux Kernel Developer - Open Source Group Samsung Research America (Silicon Valley) [email protected] | (970) 672-0658
At Wed, 22 May 2013 15:19:42 -0700,
Quoted 8 lines · Greg Kroah-Hartman
This is the start of the stable review cycle for the 3.0.80 release. There are 3 patches in this series, all will be posted as a response to this one. If anyone has any issues with these being applied, please let me know.
Responses should be made by Fri May 24 22:11:00 UTC 2013. Anything received after that time might be too late.
This kernel can be built and boot without any problem. Building a kernel with this kernel also works fine.
- Build Machine: debian wheezy x86_64
CPU: Intel(R) Core(TM) i5-2400 CPU @ 3.10GHz x 4
memory: 8GB
- Test machine: debian wheezy x86_64(KVM guest on the Build Machine)
vCPU: x2
memory: 2GB
Thanks,
Satoru