ceph: remove unneeded truncation

PATCH New Dan Carpenter 1 participant 1 message May 23, 2013

Subsystems (2)

Kernel janitors Ceph client

lore

Share & tools

lore

Dan Carpenter

author

2013-05-23 18:36 UTC #0 lore raw

PATCH 1/1 ceph: remove unneeded truncation

My static checker complains l->stripe_unit could still be zero after we truncate it to 32 bits. I don't see a reason to do the truncation so I have removed it. Both sides are u64 type.

Signed-off-by Dan Carpenter <[email protected]>

fs/ceph/ioctl.c +1 -1

index e0b4ef3..98fe5e7 100644
@@ -43,7 +43,7 @@ static long __validate_layout(struct ceph_mds_client *mdsc,
 	if ((l->object_size & ~PAGE_MASK) ||
 	    (l->stripe_unit & ~PAGE_MASK) ||
 	    (l->stripe_unit != 0 &&
-	     ((unsigned)l->object_size % (unsigned)l->stripe_unit)))
+	     (l->object_size % l->stripe_unit)))
 		return -EINVAL;
 
 	/* make sure it's a valid data pool */