doc: avoid strncpy in accounting tool
PATCH v2 1/1 doc: avoid strncpy in accounting tool
Avoid strncpy anti-pattern. Since optarg is stable, it can be used directly. This avoids a needless strdup() for the "logfile" variable as well.
Signed-off-by Kees Cook <[email protected]>
---
Fix for -mm clean-up-scary-strncpydst-src-strlensrc-uses-fix.patch
--- Documentation/accounting/getdelays.c | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-)
Documentation/accounting/getdelays.c +3 -3
@@ -272,7 +272,7 @@ int main(int argc, char *argv[])char *logfile =NULL ;int loop =0 ;int containerset =0 ; -char containerpath[1024 ]; +char *containerpath =NULL ;int cfd =0 ;int forking =0 ;sigset_t sigset;
@@ -299,10 +299,10 @@ int main(int argc, char *argv[])break ;case 'C' : containerset =1 ; -strncpy (containerpath, optarg,strlen (optarg) +1 ); + containerpath = optarg;break ;case 'w' : - logfile =strdup (optarg); + logfile = optarg;printf ("write to file %s\n" , logfile); write_file =1 ;break ;
Signature · 6 lines
1.7.9.5 -- Kees Cook Chrome OS Security