Skip to contentSkip to conversation

u-boot-pxa/master

GIT PULL Marek Vasut 4 participants 9 messages Jun 22, 2013 – Jun 28, 2013

lore
Share & tools
lore
#0 lore raw

The following changes since commit fbf87b1823dd5ebc2a384711ea2c677543019ece:

arm: optimize relocate_code routine (2013-06-21 23:05:50 +0200)

are available in the git repository at:

git://git.denx.de/u-boot-pxa.git master

for you to fetch changes up to 9dc8fef2583f23ca6a99c6f5e709a8b80018364f:

pxa: fix memory coherency problem after relocation (2013-06-22 15:25:28 +0200)

----------------------------------------------------------------
Mike Dunn (5):
pxa: add support for palmtreo680 board
pxa: palmtreo680 flash programming utility
pxa: turn icache off in cpu_init_crit()
pxa: use -mcpu=xscale compiler option
pxa: fix memory coherency problem after relocation

 CREDITS                          |    4 +
 MAINTAINERS                      |    3 +
 arch/arm/cpu/pxa/config.mk       |    2 +-
 arch/arm/cpu/pxa/start.S         |    3 +-
 arch/arm/lib/relocate.S          |    9 +++
 board/palmtreo680/Makefile       |   34 +++++++++
 board/palmtreo680/README         |  581 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 board/palmtreo680/palmtreo680.c  |  148 +++++++++++++++++++++++++++++++++++
 boards.cfg                       |    1 +
 include/configs/palmtreo680.h    |  286 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 tools/palmtreo680/flash_u-boot.c |  177 
++++++++++++++++++++++++++++++++++++++++++
 11 files changed, 1245 insertions(+), 3 deletions(-)
 create mode 100644 board/palmtreo680/Makefile
 create mode 100644 board/palmtreo680/README
 create mode 100644 board/palmtreo680/palmtreo680.c
 create mode 100644 include/configs/palmtreo680.h
 create mode 100644 tools/palmtreo680/flash_u-boot.c
#1 lore raw

Hi Marek,

Quoted 32 lines · Marek Vasut

The following changes since commit fbf87b1823dd5ebc2a384711ea2c677543019ece:

arm: optimize relocate_code routine (2013-06-21 23:05:50 +0200)

are available in the git repository at:

git://git.denx.de/u-boot-pxa.git master

for you to fetch changes up to 9dc8fef2583f23ca6a99c6f5e709a8b80018364f:

pxa: fix memory coherency problem after relocation (2013-06-22 15:25:28 +0200)

----------------------------------------------------------------
Mike Dunn (5):
pxa: add support for palmtreo680 board
pxa: palmtreo680 flash programming utility
pxa: turn icache off in cpu_init_crit()
pxa: use -mcpu=xscale compiler option
pxa: fix memory coherency problem after relocation

 CREDITS                          |    4 +
 MAINTAINERS                      |    3 +
 arch/arm/cpu/pxa/config.mk       |    2 +-
 arch/arm/cpu/pxa/start.S         |    3 +-
 arch/arm/lib/relocate.S          |    9 +++
 board/palmtreo680/Makefile       |   34 +++++++++
 board/palmtreo680/README         |  581 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 board/palmtreo680/palmtreo680.c  |  148 +++++++++++++++++++++++++++++++++++
 boards.cfg                       |    1 +
 include/configs/palmtreo680.h    |  286 

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Quoted 8 lines
 tools/palmtreo680/flash_u-boot.c |  177 
++++++++++++++++++++++++++++++++++++++++++
 11 files changed, 1245 insertions(+), 3 deletions(-)
 create mode 100644 board/palmtreo680/Makefile
 create mode 100644 board/palmtreo680/README
 create mode 100644 board/palmtreo680/palmtreo680.c
 create mode 100644 include/configs/palmtreo680.h
 create mode 100644 tools/palmtreo680/flash_u-boot.c

gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1)

fails with warnings for palmtreo680:

pxa27x_udc.c: In function 'udc_read_urb':
pxa27x_udc.c:154:21: warning: variable 'is_short' set but not used [-Wunused-but-set-variable] pxa27x_udc.c: In function 'udc_state_changed': pxa27x_udc.c:405:25: warning: variable 'alternate' set but not used [-Wunused-but-set-variable] pxa27x_udc.c:405:14:
warning: variable 'interface' set but not used [-Wunused-but-set-variable] pxa27x_udc.c:405:6: warning: variable 'config' set but not used [-Wunused-but-set-variable] docg4_spl.c: In function 'docg4_load_block_reliable': docg4_spl.c:116:32: warning:
variable 'magic_low' set but not used [-Wunused-but-set-variable] docg4_spl.c:116:20: warning: variable 'magic_high' set but not used [-Wunused-but-set-variable] docg4_spl.c:116:11: warning: variable 'discard' set but not used [-Wunused-but-set-variable]

Mike, please fix the warnings; Marek, please update u-boot-pxa/master and submit a new PR.

Amicalement,

Signature · 1 line
Albert.
#2 lore raw
Quoted 45 lines · Albert ARIBAUD

Hi Marek,

Quoted 32 lines · Marek Vasut

The following changes since commit fbf87b1823dd5ebc2a384711ea2c677543019ece:

arm: optimize relocate_code routine (2013-06-21 23:05:50 +0200)

are available in the git repository at:

git://git.denx.de/u-boot-pxa.git master

for you to fetch changes up to 9dc8fef2583f23ca6a99c6f5e709a8b80018364f:

pxa: fix memory coherency problem after relocation (2013-06-22 15:25:28 +0200)

----------------------------------------------------------------
Mike Dunn (5):
pxa: add support for palmtreo680 board
pxa: palmtreo680 flash programming utility
pxa: turn icache off in cpu_init_crit()
pxa: use -mcpu=xscale compiler option
pxa: fix memory coherency problem after relocation

 CREDITS                          |    4 +
 MAINTAINERS                      |    3 +
 arch/arm/cpu/pxa/config.mk       |    2 +-
 arch/arm/cpu/pxa/start.S         |    3 +-
 arch/arm/lib/relocate.S          |    9 +++
 board/palmtreo680/Makefile       |   34 +++++++++
 board/palmtreo680/README         |  581 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 board/palmtreo680/palmtreo680.c  |  148 +++++++++++++++++++++++++++++++++++
 boards.cfg                       |    1 +
 include/configs/palmtreo680.h    |  286 

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Quoted 8 lines
 tools/palmtreo680/flash_u-boot.c |  177 
++++++++++++++++++++++++++++++++++++++++++
 11 files changed, 1245 insertions(+), 3 deletions(-)
 create mode 100644 board/palmtreo680/Makefile
 create mode 100644 board/palmtreo680/README
 create mode 100644 board/palmtreo680/palmtreo680.c
 create mode 100644 include/configs/palmtreo680.h
 create mode 100644 tools/palmtreo680/flash_u-boot.c
Quoted 3 lines

gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1)

fails with warnings for palmtreo680:

I don't get these warnings, despite the u-boot makefiles passing -Wall to gcc. I'm using gcc version 4.5.4... I guess maybe I need to update gcc because later versions are stricter? I'll go ahead and do that, and if this produces the warnings, I'll submit patches that eliminates them. Sorry.

Thanks,
Mike

#3 lore raw

Hi Mike,

Quoted 48 lines · Mike Dunn
Quoted 47 lines · Albert ARIBAUD

Hi Marek,

Quoted 32 lines · Marek Vasut

The following changes since commit fbf87b1823dd5ebc2a384711ea2c677543019ece:

arm: optimize relocate_code routine (2013-06-21 23:05:50 +0200)

are available in the git repository at:

git://git.denx.de/u-boot-pxa.git master

for you to fetch changes up to 9dc8fef2583f23ca6a99c6f5e709a8b80018364f:

pxa: fix memory coherency problem after relocation (2013-06-22 15:25:28 +0200)

----------------------------------------------------------------
Mike Dunn (5):
pxa: add support for palmtreo680 board
pxa: palmtreo680 flash programming utility
pxa: turn icache off in cpu_init_crit()
pxa: use -mcpu=xscale compiler option
pxa: fix memory coherency problem after relocation

 CREDITS                          |    4 +
 MAINTAINERS                      |    3 +
 arch/arm/cpu/pxa/config.mk       |    2 +-
 arch/arm/cpu/pxa/start.S         |    3 +-
 arch/arm/lib/relocate.S          |    9 +++
 board/palmtreo680/Makefile       |   34 +++++++++
 board/palmtreo680/README         |  581 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 board/palmtreo680/palmtreo680.c  |  148 +++++++++++++++++++++++++++++++++++
 boards.cfg                       |    1 +
 include/configs/palmtreo680.h    |  286 

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Quoted 8 lines
 tools/palmtreo680/flash_u-boot.c |  177 
++++++++++++++++++++++++++++++++++++++++++
 11 files changed, 1245 insertions(+), 3 deletions(-)
 create mode 100644 board/palmtreo680/Makefile
 create mode 100644 board/palmtreo680/README
 create mode 100644 board/palmtreo680/palmtreo680.c
 create mode 100644 include/configs/palmtreo680.h
 create mode 100644 tools/palmtreo680/flash_u-boot.c

gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1)

Quoted 7 lines
Quoted 1 line

fails with warnings for palmtreo680:

I don't get these warnings, despite the u-boot makefiles passing -Wall to gcc. I'm using gcc version 4.5.4... I guess maybe I need to update gcc because later versions are stricter? I'll go ahead and do that, and if this produces the warnings, I'll submit patches that eliminates them. Sorry.

No need to be sorry -- you were using a toolchain that does not emit these warnings, so you could not be expected to see them.

FYI, I am using the ARM cross-toolchain available in my Ubuntu 13.04.

Quoted 2 lines

Thanks,
Mike

Amicalement,

Signature · 1 line
Albert.
#4 lore raw

Dear Albert ARIBAUD,

Quoted 10 lines

Hi Mike,

On Sat, 22 Jun 2013 10:42:27 -0700, Mike Dunn <[email protected]>

Quoted 5 lines · wrote:
Quoted 4 lines · Albert ARIBAUD

Hi Marek,

Quoted 1 line · Marek Vasut

The following changes since commit

fbf87b1823dd5ebc2a384711ea2c677543019ece:

Quoted 56 lines
Quoted 47 lines
Quoted 47 lines
Quoted 46 lines

arm: optimize relocate_code routine (2013-06-21 23:05:50 +0200)

are available in the git repository at:
git://git.denx.de/u-boot-pxa.git master

for you to fetch changes up to 9dc8fef2583f23ca6a99c6f5e709a8b80018364f:
pxa: fix memory coherency problem after relocation (2013-06-22 15:25:28 +0200)

----------------------------------------------------------------

Mike Dunn (5):
pxa: add support for palmtreo680 board
pxa: palmtreo680 flash programming utility
pxa: turn icache off in cpu_init_crit()
pxa: use -mcpu=xscale compiler option
pxa: fix memory coherency problem after relocation

 CREDITS                          |    4 +
 MAINTAINERS                      |    3 +
 arch/arm/cpu/pxa/config.mk       |    2 +-
 arch/arm/cpu/pxa/start.S         |    3 +-
 arch/arm/lib/relocate.S          |    9 +++
 board/palmtreo680/Makefile       |   34 +++++++++
 board/palmtreo680/README         |  581

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

 board/palmtreo680/palmtreo680.c  |  148
 +++++++++++++++++++++++++++++++++++ boards.cfg                      
 |    1 +
 include/configs/palmtreo680.h    |  286

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

 tools/palmtreo680/flash_u-boot.c |  177

++++++++++++++++++++++++++++++++++++++++++

 11 files changed, 1245 insertions(+), 3 deletions(-)
 create mode 100644 board/palmtreo680/Makefile
 create mode 100644 board/palmtreo680/README
 create mode 100644 board/palmtreo680/palmtreo680.c
 create mode 100644 include/configs/palmtreo680.h
 create mode 100644 tools/palmtreo680/flash_u-boot.c
Quoted 8 lines
Quoted 3 lines

gcc version 4.7.3 (Ubuntu/Linaro 4.7.3-1ubuntu1)

fails with warnings for palmtreo680:

I don't get these warnings, despite the u-boot makefiles passing -Wall to gcc. I'm using gcc version 4.5.4... I guess maybe I need to update gcc because later versions are stricter? I'll go ahead and do that, and if this produces the warnings, I'll submit patches that eliminates them. Sorry.

Quoted 4 lines

No need to be sorry -- you were using a toolchain that does not emit these warnings, so you could not be expected to see them.

FYI, I am using the ARM cross-toolchain available in my Ubuntu 13.04.

For some reason, I feel the linaro ones were always stuffed with experimental and semi-broken stuff :-(

Best regards,
Marek Vasut

#5 lore raw

Hi Marek,

Quoted 4 lines
Quoted 1 line

FYI, I am using the ARM cross-toolchain available in my Ubuntu 13.04.

For some reason, I feel the linaro ones were always stuffed with experimental and semi-broken stuff :-(

Maybe they were; all I can say is, the Ubuntu/Linaro toolchain never failed me in any way.

Quoted 2 lines

Best regards,
Marek Vasut

Amicalement,

Signature · 1 line
Albert.
#6 lore raw
Quoted 9 lines · Albert ARIBAUD

Hi Marek,

Quoted 4 lines
Quoted 1 line

FYI, I am using the ARM cross-toolchain available in my Ubuntu 13.04.

For some reason, I feel the linaro ones were always stuffed with experimental and semi-broken stuff :-(

Maybe they were; all I can say is, the Ubuntu/Linaro toolchain never failed me in any way.

I build my toolchain using the crossdev script, which is a gentoo package. I've been doing this for years without any problems, except that occasionally building requires some trial-and-error because of incompatibilities between gcc/binutils/glibc. But other than that, I am able to choose the version of each tool.

Mike

#7 lore raw

Dear Mike Dunn,

Quoted 8 lines · Albert ARIBAUD
Quoted 7 lines

Hi Marek,

Quoted 4 lines
Quoted 1 line

FYI, I am using the ARM cross-toolchain available in my Ubuntu 13.04.

For some reason, I feel the linaro ones were always stuffed with experimental and semi-broken stuff :-(

Quoted 8 lines
Quoted 2 lines

Maybe they were; all I can say is, the Ubuntu/Linaro toolchain never failed me in any way.

I build my toolchain using the crossdev script, which is a gentoo package. I've been doing this for years without any problems, except that occasionally building requires some trial-and-error because of incompatibilities between gcc/binutils/glibc. But other than that, I am able to choose the version of each tool.

I'll just add my bit into this toolchain onanism ... I build my toolchains with buildcross (it's a debian thing) ... fap fap.

Best regards,
Marek Vasut

#8 lore raw
In reply to Marek Vasut

Hi Marek,

Quoted 32 lines · Marek Vasut

The following changes since commit fbf87b1823dd5ebc2a384711ea2c677543019ece:

arm: optimize relocate_code routine (2013-06-21 23:05:50 +0200)

are available in the git repository at:

git://git.denx.de/u-boot-pxa.git master

for you to fetch changes up to 9dc8fef2583f23ca6a99c6f5e709a8b80018364f:

pxa: fix memory coherency problem after relocation (2013-06-22 15:25:28 +0200)

----------------------------------------------------------------
Mike Dunn (5):
pxa: add support for palmtreo680 board
pxa: palmtreo680 flash programming utility
pxa: turn icache off in cpu_init_crit()
pxa: use -mcpu=xscale compiler option
pxa: fix memory coherency problem after relocation

 CREDITS                          |    4 +
 MAINTAINERS                      |    3 +
 arch/arm/cpu/pxa/config.mk       |    2 +-
 arch/arm/cpu/pxa/start.S         |    3 +-
 arch/arm/lib/relocate.S          |    9 +++
 board/palmtreo680/Makefile       |   34 +++++++++
 board/palmtreo680/README         |  581 
++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++
 board/palmtreo680/palmtreo680.c  |  148 +++++++++++++++++++++++++++++++++++
 boards.cfg                       |    1 +
 include/configs/palmtreo680.h    |  286 

++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++++

Quoted 8 lines
 tools/palmtreo680/flash_u-boot.c |  177 
++++++++++++++++++++++++++++++++++++++++++
 11 files changed, 1245 insertions(+), 3 deletions(-)
 create mode 100644 board/palmtreo680/Makefile
 create mode 100644 board/palmtreo680/README
 create mode 100644 board/palmtreo680/palmtreo680.c
 create mode 100644 include/configs/palmtreo680.h
 create mode 100644 tools/palmtreo680/flash_u-boot.c

Applied to u-boot-arm/master despite palmtreo680 build warnings as fixes are going to come from other repos.

Amicalement,

Signature · 1 line
Albert.