pstore: Fail to unlink if a driver has not defined pstore_erase
PATCH v2 1/1 pstore: Fail to unlink if a driver has not defined pstore_erase
pstore_erase is used to erase the record from the persistent store. So if a driver has not defined pstore_erase callback return -EPERM instead of unlinking a file as deleting the file without erasing its record in persistent store will give a wrong impression to customers.
---
Changes from v1:
Fix error return value
fs/pstore/inode.c | 2 ++ 1 file changed, 2 insertions(+)
fs/pstore/inode.c +2 -0
@@ -178,6 +178,8 @@ static int pstore_unlink(struct inode *dir, struct dentry *dentry)if (p->psi->erase) p->psi->erase (p->type, p->id, p->count, dentry->d_inode->i_ctime, p->psi); +else +return -EPERM ;return simple_unlink (dir, dentry); }
Quoted 7 lines · Aruna Balakrishnaiah
pstore_eraseis used to erase the record from the persistent store. So if a driver has not definedpstore_erasecallback return-EPERMinstead of unlinking a file as deleting the file without erasing its record in persistent store will give a wrong impression to customers.Signed-off-by Aruna Balakrishnaiah <[email protected]>
Thanks!
-Kees
--
Kees Cook
Chrome OS Security
Quoted 4 lines · Kees Cook
Quoted 2 lines · Aruna Balakrishnaiah
pstore_eraseis used to erase the record from the persistent store. So if a driver has not definedpstore_erasecallback return
How do people manage devices like this? With no erase function they just keep getting more and more pstore entries. Eventually they fill up.
Quoted 3 lines
Quoted 1 line
Signed-off-by Aruna Balakrishnaiah <[email protected]>Acked-by Kees Cook <[email protected]>
Applied - thanks.
-Tony
Quoted 8 lines · Tony Luck
Quoted 4 lines · Kees Cook
Quoted 2 lines · Aruna Balakrishnaiah
pstore_eraseis used to erase the record from the persistent store. So if a driver has not definedpstore_erasecallback returnHow do people manage devices like this? With no erase function they just keep getting more and more pstore entries. Eventually they fill up.
We dont keep old records in the device. We have logs only of the recent / last crash. The device has a predefined space for each type of messages. For example: Every time a crash occurs the data gets overwritten in the device allocated to store crash log.
Quoted 7 lines
Quoted 3 lines
Quoted 2 lines
Signed-off-by Aruna Balakrishnaiah <[email protected]>Acked-by Kees Cook <[email protected]>Applied - thanks.
-Tony