libdrm: Add GLSDK specific staging tree for omap-a15
PATCH 1/1 libdrm: Add GLSDK specific staging tree for omap-a15
* Override SRC_URI to use TI's tree at https://git.ti.com/glsdk/libdrm
This tree includes patches on top of the upstream libdrm for omap5 and dra7xx class of devices.
--- recipes-graphics/drm/libdrm_2.4.41.bb | 15 +++++++++++++++ 1 files changed, 15 insertions(+), 0 deletions(-) create mode 100644 recipes-graphics/drm/libdrm_2.4.41.bb
recipes-graphics/drm/libdrm_2.4.41.bb new file +15 -0
@@ -0,0 +1,15 @@ +require recipes-graphics/drm/libdrm.inc + +COMPATIBLE_MACHINE = "omap-a15" + +DEFAULT_PREFERENCE = "-1" + +EXTRA_OECONF += "--enable-omap-experimental-api" + +SRC_URI = "git://git.ti.com/glsdk/libdrm.git;protocol=git" +SRCREV = "3cb5405084111193cedb8796d259b56560b088f0" + +# Append to the PR so that a new SRCREV will cause a rebuild +PR_append = "a+gitr${SRCPV}" + +S = "${WORKDIR}/git"
Signature · 1 line
1.7.0.4
recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 26 lines
-----Original Message-----
From: [email protected] [mailto:meta-ti- [email protected]] On Behalf Of Heroor, Siddharth
Sent: Thursday, June 27, 2013 12:17 PM
To: [email protected]
Subject: [meta-ti] [PATCH] libdrm: Add GLSDK specific staging tree for omap-a15* Override
SRC_URIto use TI's tree at
https://git.ti.com/glsdk/libdrm
This tree includes patches on top of the upstream libdrm for omap5 and dra7xx class of devices.Signed-off-by Mrinmayee Hingolikar <[email protected]>Signed-off-by Siddharth Heroor <[email protected]>---
recipes-graphics/drm/libdrm_2.4.41.bb | 15 +++++++++++++++1 files changed, 15 insertions(+), 0 deletions(-)create mode 100644 recipes-graphics/drm/libdrm_2.4.41.bb
recipes- renamed from recipes-graphics/drm/libdrm_2.4.41.bb +0
-0graphics/drm/libdrm_2.4.41.bb
new file mode 100644
index 0000000..31f7ceerecipes-graphics/drm/libdrm_2.4.41.bb new file +0
-0
I thought you were going to bbappend this instead of overlaying the whole recipe.
Quoted 4 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +3
-0@@ -0,0 +1,15 @@ +require recipes-graphics/drm/libdrm.inc + +COMPATIBLE_MACHINE = "omap-a15"
recipes-graphics/drm/libdrm_2.4.41.bb line 13
Quoted 10 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +10
-0+ +DEFAULT_PREFERENCE = "-1" + +EXTRA_OECONF += "--enable-omap-experimental-api" + +SRC_URI = "git://git.ti.com/glsdk/libdrm.git;protocol=git" +SRCREV = "3cb5405084111193cedb8796d259b56560b088f0" + +# Append to the PR so that a new SRCREV will cause a rebuild +PR_append = "a+gitr${SRCPV}"
I always had issue with this. I'm not sure that this statement holds true because whether a new SRCREV will cause a rebuild would depend on whether that SRCREV sorts higher than the old one. Unless something else has changed. This is useful though if you want to know what SRCREV was used for a build.
That being said if you were going to overlay this recipe the PR should be something like
PR = "${INC_PR}.0"
Right now you are appending to the default since PR is not defined. With a bbappend you should append a -arago flag.
So this comes back to why no bbappend? Is it because the base version in oe-core is 2.4.39 and not 2.4.41? Can you not append the _git version of the recipe and update the PV appropriately?
Quoted 9 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +2
-1+ +S = "${WORKDIR}/git" --1.7.0.4
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
Quoted 20 lines · Chase
Quoted 20 lines
-----Original Message-----
From: [email protected] [mailto:meta-ti- [email protected]] On Behalf Of Heroor, Siddharth
Sent: Thursday, June 27, 2013 12:17 PM
To: [email protected]
Subject: [meta-ti] [PATCH] libdrm: Add GLSDK specific staging tree for omap-a15* Override
SRC_URIto use TI's tree at
https://git.ti.com/glsdk/libdrm
This tree includes patches on top of the upstream libdrm for omap5 and dra7xx class of devices.Signed-off-by Mrinmayee Hingolikar <[email protected]>Signed-off-by Siddharth Heroor <[email protected]>---
recipes-graphics/drm/libdrm_2.4.41.bb | 15 +++++++++++++++1 files changed, 15 insertions(+), 0 deletions(-)create mode 100644 recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 9 lines
recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 6 lines
recipes- renamed from recipes-graphics/drm/libdrm_2.4.41.bb +0
-0graphics/drm/libdrm_2.4.41.bb
new file mode 100644
index 0000000..31f7ceerecipes-graphics/drm/libdrm_2.4.41.bb new file +0
-0I thought you were going to bbappend this instead of overlaying the whole recipe.
I was confused at first as well, but I guess it should be fine, considering there's no 2.4.41 version to bbapend anyway.
Quoted 12 lines
Quoted 12 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +11
-0@@ -0,0 +1,15 @@ +require recipes-graphics/drm/libdrm.inc + +COMPATIBLE_MACHINE = "omap-a15" + +DEFAULT_PREFERENCE = "-1" + +EXTRA_OECONF += "--enable-omap-experimental-api" + +SRC_URI = "git://git.ti.com/glsdk/libdrm.git;protocol=git" +SRCREV = "3cb5405084111193cedb8796d259b56560b088f0" +
Quoted 8 lines
recipes-graphics/drm/libdrm_2.4.41.bb line 13
Quoted 2 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +2
-0+# Append to the PR so that a new SRCREV will cause a rebuild +PR_append = "a+gitr${SRCPV}"I always had issue with this. I'm not sure that this statement holds true because whether a new SRCREV will cause a rebuild would depend on whether that SRCREV sorts higher than the old one. Unless something else has changed. This is useful though if you want to know what SRCREV was used for a build.
Well, if every time you update SRCREV you also increment the first letter, it will work as expected - so the comment is kind of correct... :)
Quoted 25 lines
That being said if you were going to overlay this recipe the PR should be something like
PR = "${INC_PR}.0"
Right now you are appending to the default since PR is not defined. With a bbappend you should append a -arago flag.
So this comes back to why no bbappend? Is it because the base version in oe-core is 2.4.39 and not 2.4.41? Can you not append the
_gitversion of the recipe and update the PV appropriately?Quoted 9 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +2
-1+ +S = "${WORKDIR}/git" --1.7.0.4
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
Quoted 31 lines · Denys Dmytriyenko
Quoted 20 lines · Chase
Quoted 20 lines
-----Original Message-----
From: [email protected] [mailto:meta-ti- [email protected]] On Behalf Of Heroor, Siddharth
Sent: Thursday, June 27, 2013 12:17 PM
To: [email protected]
Subject: [meta-ti] [PATCH] libdrm: Add GLSDK specific staging tree for omap-a15* Override
SRC_URIto use TI's tree at
https://git.ti.com/glsdk/libdrm
This tree includes patches on top of the upstream libdrm for omap5 and dra7xx class of devices.Signed-off-by Mrinmayee Hingolikar <[email protected]>Signed-off-by Siddharth Heroor <[email protected]>---
recipes-graphics/drm/libdrm_2.4.41.bb | 15 +++++++++++++++1 files changed, 15 insertions(+), 0 deletions(-)create mode 100644 recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 9 lines
recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 6 lines
recipes- renamed from recipes-graphics/drm/libdrm_2.4.41.bb +0
-0graphics/drm/libdrm_2.4.41.bb
new file mode 100644
index 0000000..31f7ceerecipes-graphics/drm/libdrm_2.4.41.bb new file +0
-0I thought you were going to bbappend this instead of overlaying the whole recipe.
Quoted 2 lines
I was confused at first as well, but I guess it should be fine, considering there's no 2.4.41 version to bbapend anyway.
Sorry about that. The original code we were working on was a .bbappend to override recipes-graphics/drm/libdrm_git. However, the latest version in oe-core on danny is 2.4.39 and master is 2.4.45. I chose to use libdrm_2.4.41.bb because that's easier to read for me :-)
Quoted 23 lines
Quoted 14 lines
Quoted 14 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +11
-0@@ -0,0 +1,15 @@ +require recipes-graphics/drm/libdrm.inc + +COMPATIBLE_MACHINE = "omap-a15" + +DEFAULT_PREFERENCE = "-1" + +EXTRA_OECONF += "--enable-omap-experimental-api" + +SRC_URI = "git://git.ti.com/glsdk/libdrm.git;protocol=git" +SRCREV = "3cb5405084111193cedb8796d259b56560b088f0" +Quoted 8 lines
recipes-graphics/drm/libdrm_2.4.41.bb line 13
Quoted 2 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +2
-0+# Append to the PR so that a new SRCREV will cause a rebuild +PR_append = "a+gitr${SRCPV}"I always had issue with this. I'm not sure that this statement holds true because whether a new SRCREV will cause a rebuild would depend on whether that SRCREV sorts higher than the old one. Unless something else has changed. This is useful though if you want to know what SRCREV was used for a build.
Quoted 3 lines
Well, if every time you update SRCREV you also increment the first letter, it will work as expected - so the comment is kind of correct... :)
Right, I just followed the existing kernel recipes for convention. Would the convention change between a kernel recipe (like recipes-kernel/linux/linux-ti-staging_3.8.bb) where we have both SRCPV and the first letter, compared to userspace recipes which point to git trees for versions?
Quoted 6 lines
Quoted 6 lines
That being said if you were going to overlay this recipe the PR should be something like
PR = "${INC_PR}.0"
Quoted 7 lines
Quoted 7 lines
Right now you are appending to the default since PR is not defined. With a bbappend you should append a -arago flag.
So this comes back to why no bbappend? Is it because the base version in oe-core is 2.4.39 and not 2.4.41? Can you not append the
_gitversion of the recipe and update the PV appropriately?
That's also possible but the question I have is what's the preferred convention?
All the GLSDK trees are on git. The choice really is between having a since .bbappend for each of the trees with an explicit PV and bump the PV everytime we update to latest on upstream *OR* have a recipe for the version and submit a new recipe when we update to latest.
I can submit a v2 once I understand the expected convention to be followed.
Quoted 13 lines
Quoted 13 lines
Quoted 9 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +2
-1+ +S = "${WORKDIR}/git" --1.7.0.4
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
Quoted 88 lines · Siddharth Heroor
Quoted 31 lines · Denys Dmytriyenko
Quoted 20 lines · Chase
Quoted 20 lines
-----Original Message-----
From: [email protected] [mailto:meta-ti- [email protected]] On Behalf Of Heroor, Siddharth
Sent: Thursday, June 27, 2013 12:17 PM
To: [email protected]
Subject: [meta-ti] [PATCH] libdrm: Add GLSDK specific staging tree for omap-a15* Override
SRC_URIto use TI's tree at
https://git.ti.com/glsdk/libdrm
This tree includes patches on top of the upstream libdrm for omap5 and dra7xx class of devices.Signed-off-by Mrinmayee Hingolikar <[email protected]>Signed-off-by Siddharth Heroor <[email protected]>---
recipes-graphics/drm/libdrm_2.4.41.bb | 15 +++++++++++++++1 files changed, 15 insertions(+), 0 deletions(-)create mode 100644 recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 9 lines
recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 6 lines
recipes- renamed from recipes-graphics/drm/libdrm_2.4.41.bb +0
-0graphics/drm/libdrm_2.4.41.bb
new file mode 100644
index 0000000..31f7ceerecipes-graphics/drm/libdrm_2.4.41.bb new file +0
-0I thought you were going to bbappend this instead of overlaying the whole recipe.
Quoted 2 lines
I was confused at first as well, but I guess it should be fine, considering there's no 2.4.41 version to bbapend anyway.
Sorry about that. The original code we were working on was a .bbappend to override recipes-graphics/drm/libdrm_git. However, the latest version in oe-core on danny is 2.4.39 and master is 2.4.45. I chose to use libdrm_2.4.41.bb because that's easier to read for me :-)
Quoted 23 lines
Quoted 14 lines
Quoted 14 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +11
-0@@ -0,0 +1,15 @@ +require recipes-graphics/drm/libdrm.inc + +COMPATIBLE_MACHINE = "omap-a15" + +DEFAULT_PREFERENCE = "-1" + +EXTRA_OECONF += "--enable-omap-experimental-api" + +SRC_URI = "git://git.ti.com/glsdk/libdrm.git;protocol=git" +SRCREV = "3cb5405084111193cedb8796d259b56560b088f0" +Quoted 8 lines
recipes-graphics/drm/libdrm_2.4.41.bb line 13
Quoted 2 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +2
-0+# Append to the PR so that a new SRCREV will cause a rebuild +PR_append = "a+gitr${SRCPV}"I always had issue with this. I'm not sure that this statement holds true because whether a new SRCREV will cause a rebuild would depend on whether that SRCREV sorts higher than the old one. Unless something else has changed. This is useful though if you want to know what SRCREV was used for a build.
Quoted 3 lines
Well, if every time you update SRCREV you also increment the first letter, it will work as expected - so the comment is kind of correct... :)
Right, I just followed the existing kernel recipes for convention. Would the convention change between a kernel recipe (like recipes-kernel/linux/linux-ti-staging_3.8.bb) where we have both SRCPV and the first letter, compared to userspace recipes which point to git trees for versions?
Quoted 6 lines
Quoted 6 lines
That being said if you were going to overlay this recipe the PR should be something like
PR = "${INC_PR}.0"
Quoted 7 lines
Quoted 7 lines
Right now you are appending to the default since PR is not defined. With a bbappend you should append a -arago flag.
So this comes back to why no bbappend? Is it because the base version in oe-core is 2.4.39 and not 2.4.41? Can you not append the
_gitversion of the recipe and update the PV appropriately?
Quoted 7 lines
That's also possible but the question I have is what's the preferred convention?
All the GLSDK trees are on git. The choice really is between having a since .bbappend for each of the trees with an explicit PV and bump the PV everytime we update to latest on upstream *OR* have a recipe for the version and submit a new recipe when we update to latest.
Sorry. My typing went haywire...
What I mean is I can resubmit _git.bbappend. Its really whatever convention you would suggest we follow. All the recipes that we have are on git (except for a couple of binary blobs).
Do you think we should use _git.bbappend (or _git.bb as the case maybe)? In that case, we only 1 recipe to maintain per software package and we fix the PV in it.
Quoted 3 lines
I can submit a v2 once I understand the expected convention to be followed.
Let me know the approach to take, I'll submit new patches if required.
Quoted 14 lines
Quoted 13 lines
Quoted 13 lines
Quoted 9 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +2
-1+ +S = "${WORKDIR}/git" --1.7.0.4
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
Quoted 86 lines
-----Original Message-----
From: Heroor, Siddharth
Sent: Friday, June 28, 2013 4:17 AM
To: Dmytriyenko, Denys
Cc: Maupin, Chase; [email protected]
Subject: Re: [meta-ti] [PATCH] libdrm: Add GLSDK specific staging tree for omap-a15Quoted 7 lines · Denys Dmytriyenko
Quoted 6 lines · Chase
Quoted 6 lines
-----Original Message-----
From: [email protected] [mailto:meta-ti- [email protected]] On Behalf Of Heroor, Siddharth
Sent: Thursday, June 27, 2013 12:17 PM
To: [email protected]
Subject: [meta-ti] [PATCH] libdrm: Add GLSDK specific stagingtree
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
for omap-a15
* Override
SRC_URIto use TI's tree at
https://git.ti.com/glsdk/libdrm
This tree includes patches on top of the upstream libdrm for omap5 and dra7xx class of devices.Signed-off-by Mrinmayee Hingolikar <[email protected]>Signed-off-by Siddharth Heroor <[email protected]>---
recipes-graphics/drm/libdrm_2.4.41.bb | 15 +++++++++++++++1 files changed, 15 insertions(+), 0 deletions(-)create mode 100644 recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 8 lines
Quoted 8 lines
recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 6 lines
recipes- renamed from recipes-graphics/drm/libdrm_2.4.41.bb +0
-0graphics/drm/libdrm_2.4.41.bb
new file mode 100644
index 0000000..31f7ceerecipes-graphics/drm/libdrm_2.4.41.bb new file +0
-0I thought you were going to bbappend this instead of overlaying
the whole
Quoted 3 lines
Quoted 1 line
recipe.
I was confused at first as well, but I guess it should be fine,
considering
Quoted 1 line
there's no 2.4.41 version to bbapend anyway.
Sorry about that. The original code we were working on was a .bbappend
to override recipes-graphics/drm/libdrm_git. However, the latest version
in oe-core on danny is 2.4.39 and master is 2.4.45. I chose to use libdrm_2.4.41.bb because that's easier to read for me :-)Quoted 18 lines
Quoted 18 lines
Quoted 6 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +3
-0@@ -0,0 +1,15 @@ +require recipes-graphics/drm/libdrm.inc + +COMPATIBLE_MACHINE = "omap-a15"recipes-graphics/drm/libdrm_2.4.41.bb line 13
Quoted 10 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +10
-0+ +DEFAULT_PREFERENCE = "-1" + +EXTRA_OECONF += "--enable-omap-experimental-api" + +SRC_URI = "git://git.ti.com/glsdk/libdrm.git;protocol=git" +SRCREV = "3cb5405084111193cedb8796d259b56560b088f0" + +# Append to the PR so that a new SRCREV will cause a rebuild +PR_append = "a+gitr${SRCPV}"I always had issue with this. I'm not sure that this statement
holds true
Quoted 1 line
Quoted 1 line
because whether a new SRCREV will cause a rebuild would depend
on whether
Quoted 1 line
Quoted 1 line
that SRCREV sorts higher than the old one. Unless something
else has
Quoted 1 line
Quoted 1 line
changed. This is useful though if you want to know what SRCREV
was used for
Quoted 3 lines
Quoted 1 line
a build.
Well, if every time you update SRCREV you also increment the
first letter, it
Quoted 2 lines
will work as expected - so the comment is kind of correct... :)
Quoted 8 lines
Right, I just followed the existing kernel recipes for convention. Would
the convention change between a kernel recipe (like recipes-kernel/linux/linux-ti-staging_3.8.bb) where we have both SRCPV
and the first letter, compared to userspace recipes which point to git
trees for versions?
The kernel ones were to append the MACHINE_KERNEL_PR that was set with the letter. The SRCPV use was also nice to make it easier to know which commitid was being used during the kernel build.
Quoted 32 lines
Quoted 4 lines
Quoted 4 lines
That being said if you were going to overlay this recipe the PR
should be
Quoted 5 lines
Quoted 5 lines
something like
PR = "${INC_PR}.0"
Right now you are appending to the default since PR is not
defined. With a
Quoted 3 lines
Quoted 3 lines
bbappend you should append a -arago flag.
So this comes back to why no bbappend? Is it because the base
version in
Quoted 1 line
Quoted 1 line
oe-core is 2.4.39 and not 2.4.41? Can you not append the
_gitversion of
Quoted 2 lines
Quoted 2 lines
the recipe and update the PV appropriately?
That's also possible but the question I have is what's the preferred
convention?All the GLSDK trees are on git. The choice really is between having a
since .bbappend for each of the trees with an explicit PV and bump the
PV everytime we update to latest on upstream *OR* have a recipe for the
version and submit a new recipe when we update to latest.
Quoted 2 lines
I can submit a v2 once I understand the expected convention to be followed.
I get your point on clarity so I'm OK with a version specific addition. You may have answered this before but what is the difference between your libdrm and the libdrm upstream? Are your patches going upstream to the main libdrm so that going forward you can drop this recipe for a new version?
Denys, refresh my memory if we are doing a version but we are also changing things in our trees don't we normally do this as something like ti-libdrm and set the PROVIDES, etc for libdrm? This was to distinguish between libdrv 2.4.41 for example and what TI is calling 2.4.41 right? Or do you just want to do 2.4.41+? What is your preferrence?
Sidd, going the non _git route see my other input then about PR, etc.
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
Quoted 10 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +2
-1+ +S = "${WORKDIR}/git" --1.7.0.4
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
Quoted 129 lines · Chase
Quoted 86 lines
-----Original Message-----
From: Heroor, Siddharth
Sent: Friday, June 28, 2013 4:17 AM
To: Dmytriyenko, Denys
Cc: Maupin, Chase; [email protected]
Subject: Re: [meta-ti] [PATCH] libdrm: Add GLSDK specific staging tree for omap-a15Quoted 7 lines · Denys Dmytriyenko
Quoted 6 lines · Chase
Quoted 6 lines
-----Original Message-----
From: [email protected] [mailto:meta-ti- [email protected]] On Behalf Of Heroor, Siddharth
Sent: Thursday, June 27, 2013 12:17 PM
To: [email protected]
Subject: [meta-ti] [PATCH] libdrm: Add GLSDK specific stagingtree
Quoted 14 lines
Quoted 14 lines
Quoted 14 lines
for omap-a15
* Override
SRC_URIto use TI's tree at
https://git.ti.com/glsdk/libdrm
This tree includes patches on top of the upstream libdrm for omap5 and dra7xx class of devices.Signed-off-by Mrinmayee Hingolikar <[email protected]>Signed-off-by Siddharth Heroor <[email protected]>---
recipes-graphics/drm/libdrm_2.4.41.bb | 15 +++++++++++++++1 files changed, 15 insertions(+), 0 deletions(-)create mode 100644 recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 8 lines
Quoted 8 lines
recipes-graphics/drm/libdrm_2.4.41.bb
Quoted 6 lines
recipes- renamed from recipes-graphics/drm/libdrm_2.4.41.bb +0
-0graphics/drm/libdrm_2.4.41.bb
new file mode 100644
index 0000000..31f7ceerecipes-graphics/drm/libdrm_2.4.41.bb new file +0
-0I thought you were going to bbappend this instead of overlaying
the whole
Quoted 3 lines
Quoted 1 line
recipe.
I was confused at first as well, but I guess it should be fine,
considering
Quoted 1 line
there's no 2.4.41 version to bbapend anyway.
Sorry about that. The original code we were working on was a .bbappend
to override recipes-graphics/drm/libdrm_git. However, the latest version
in oe-core on danny is 2.4.39 and master is 2.4.45. I chose to use libdrm_2.4.41.bb because that's easier to read for me :-)Quoted 18 lines
Quoted 18 lines
Quoted 6 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +3
-0@@ -0,0 +1,15 @@ +require recipes-graphics/drm/libdrm.inc + +COMPATIBLE_MACHINE = "omap-a15"recipes-graphics/drm/libdrm_2.4.41.bb line 13
Quoted 10 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +10
-0+ +DEFAULT_PREFERENCE = "-1" + +EXTRA_OECONF += "--enable-omap-experimental-api" + +SRC_URI = "git://git.ti.com/glsdk/libdrm.git;protocol=git" +SRCREV = "3cb5405084111193cedb8796d259b56560b088f0" + +# Append to the PR so that a new SRCREV will cause a rebuild +PR_append = "a+gitr${SRCPV}"I always had issue with this. I'm not sure that this statement
holds true
Quoted 1 line
Quoted 1 line
because whether a new SRCREV will cause a rebuild would depend
on whether
Quoted 1 line
Quoted 1 line
that SRCREV sorts higher than the old one. Unless something
else has
Quoted 1 line
Quoted 1 line
changed. This is useful though if you want to know what SRCREV
was used for
Quoted 3 lines
Quoted 1 line
a build.
Well, if every time you update SRCREV you also increment the
first letter, it
Quoted 2 lines
will work as expected - so the comment is kind of correct... :)
Quoted 8 lines
Right, I just followed the existing kernel recipes for convention. Would
the convention change between a kernel recipe (like recipes-kernel/linux/linux-ti-staging_3.8.bb) where we have both SRCPV
and the first letter, compared to userspace recipes which point to git
trees for versions?The kernel ones were to append the
MACHINE_KERNEL_PRthat was set with the letter. The SRCPV use was also nice to make it easier to know which commitid was being used during the kernel build.Quoted 32 lines
Quoted 4 lines
Quoted 4 lines
That being said if you were going to overlay this recipe the PR
should be
Quoted 5 lines
Quoted 5 lines
something like
PR = "${INC_PR}.0"
Right now you are appending to the default since PR is not
defined. With a
Quoted 3 lines
Quoted 3 lines
bbappend you should append a -arago flag.
So this comes back to why no bbappend? Is it because the base
version in
Quoted 1 line
Quoted 1 line
oe-core is 2.4.39 and not 2.4.41? Can you not append the
_gitversion of
Quoted 2 lines
Quoted 2 lines
the recipe and update the PV appropriately?
That's also possible but the question I have is what's the preferred
convention?All the GLSDK trees are on git. The choice really is between having a
since .bbappend for each of the trees with an explicit PV and bump the
PV everytime we update to latest on upstream *OR* have a recipe for the
version and submit a new recipe when we update to latest.
Quoted 4 lines
Quoted 2 lines
I can submit a v2 once I understand the expected convention to be followed.
I get your point on clarity so I'm OK with a version specific addition. You may have answered this before but what is the difference between your libdrm and the libdrm upstream? Are your patches going upstream to the main libdrm so that going forward you can drop this recipe for a new version?
We should. It's on the backlog ;-)
Right now the focus is to have our software on meta-ti.
Quoted 4 lines
Denys, refresh my memory if we are doing a version but we are also changing things in our trees don't we normally do this as something like ti-libdrm and set the PROVIDES, etc for libdrm? This was to distinguish between libdrv 2.4.41 for example and what TI is calling 2.4.41 right? Or do you just want to do 2.4.41+? What is your preferrence?
Sidd, going the non
_gitroute see my other input then about PR, etc.
Agreed. I'll send v2 with PR = "${INC_PR}.0".
Quoted 16 lines
Quoted 15 lines
Quoted 15 lines
Quoted 15 lines
Quoted 11 lines
recipes-graphics/drm/libdrm_2.4.41.bb new file +2
-1+ +S = "${WORKDIR}/git" --1.7.0.4
_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti_______________________________________________
meta-ti mailing list
[email protected]
https://lists.yoctoproject.org/listinfo/meta-ti
Quoted 56 lines · Chase
Quoted 6 lines
Quoted 2 lines
Well, if every time you update SRCREV you also increment the
first letter, it
Quoted 2 lines
will work as expected - so the comment is kind of correct... :)
Quoted 8 lines
Right, I just followed the existing kernel recipes for convention. Would
the convention change between a kernel recipe (like recipes-kernel/linux/linux-ti-staging_3.8.bb) where we have both SRCPV
and the first letter, compared to userspace recipes which point to git
trees for versions?The kernel ones were to append the
MACHINE_KERNEL_PRthat was set with the letter. The SRCPV use was also nice to make it easier to know which commitid was being used during the kernel build.Quoted 29 lines
Quoted 1 line
Quoted 1 line
That being said if you were going to overlay this recipe the PR
should be
Quoted 5 lines
Quoted 5 lines
something like
PR = "${INC_PR}.0"
Right now you are appending to the default since PR is not
defined. With a
Quoted 3 lines
Quoted 3 lines
bbappend you should append a -arago flag.
So this comes back to why no bbappend? Is it because the base
version in
Quoted 1 line
Quoted 1 line
oe-core is 2.4.39 and not 2.4.41? Can you not append the
_gitversion of
Quoted 2 lines
Quoted 2 lines
the recipe and update the PV appropriately?
That's also possible but the question I have is what's the preferred
convention?All the GLSDK trees are on git. The choice really is between having a
since .bbappend for each of the trees with an explicit PV and bump the
PV everytime we update to latest on upstream *OR* have a recipe for the
version and submit a new recipe when we update to latest.Quoted 2 lines
I can submit a v2 once I understand the expected convention to be followed.
I get your point on clarity so I'm OK with a version specific addition. You may have answered this before but what is the difference between your libdrm and the libdrm upstream? Are your patches going upstream to the main libdrm so that going forward you can drop this recipe for a new version?
Quoted 5 lines
Denys, refresh my memory if we are doing a version but we are also changing things in our trees don't we normally do this as something like ti-libdrm and set the PROVIDES, etc for libdrm? This was to distinguish between libdrv 2.4.41 for example and what TI is calling 2.4.41 right? Or do you just want to do 2.4.41+? What is your preferrence?
From my past discussions with Nicolas, TI's libdrm is quite close to the upstream and the patches are meant to be upstreamed eventually. So, technically it's not a complete fork and having a full replacement like ti-libdrm is not really necessary here. I'm fine with providing own libdrm-2.4.41 recipe for now.
Signature · 1 line
Denys