Skip to contentSkip to conversation

usb: ohci-ep93xx: do a bit of house cleaning

PATCH Superseded H Hartley Sweeten 2 participants 2 messages Jun 29, 2013 – Jul 1, 2013

v1 of 2 Superseded Latest is v2 →

lore
Share & tools
lore
#0 lore raw

cover usb: ohci-ep93xx: do a bit of house cleaning

Tidy up this driver a bit.

H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get()
usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe()

 drivers/usb/host/ohci-ep93xx.c | 60 ++++++++++++++++--------------------------
 1 file changed, 23 insertions(+), 37 deletions(-)
Signature · 1 line
1.8.1.4
#1 lore raw
Quoted 7 lines · H Hartley Sweeten

Tidy up this driver a bit.

H Hartley Sweeten (4):
usb: ohci-ep93xx: use devm_ioremap_resource()
usb: ohci-ep93xx: use platform_get_irq()
usb: ohci-ep93xx: use devm_clk_get()
usb: ohci-ep93xx: tidy up ohci_hcd_ep93xx_drv_probe()

Patches 1 - 3 look fine; you can add my Acked-by: to them.

For patch 4, we really should have a little more tidying up. The ohci_hcd_ep93xx_drv_probe() routine should be merged with usb_hcd_ep93xx_probe(); there's no reason for them to be separate. Likewise for ohci_hcd_ep93xx_drv_remove() and usb_hcd_ep93xx_remove().

Also, if you feel up to it, I think it would make sense to eliminate the ep93xx_start_hc() and ep93xx_stop_hc() routines and simply call clk_enable() and clk_disable() directly. The extra level of redirection does not add any clarity.

Alan Stern