drm/radeon: forever loop on error in radeon_do_test_moves()
Subsystems (3)
PATCH 1/1 drm/radeon: forever loop on error in radeon_do_test_moves()
The error path does this:
for (--i; i >= 0; --i) {which is a forever loop because "i" is unsigned.
Signed-off-by Dan Carpenter <[email protected]>
drivers/gpu/drm/radeon/radeon_test.c +2 -2
@@ -36,8 +36,8 @@ static void radeon_do_test_moves(struct radeon_device *rdev, int flag)struct radeon_bo *vram_obj =NULL ;struct radeon_bo **gtt_obj =NULL ;uint64_t gtt_addr, vram_addr; -unsigned i, n, size; -int r, ring; +unsigned n, size; +int i, r, ring;switch (flag) {case RADEON_TEST_COPY_DMA :
Quoted 7 lines · Dan Carpenter
The error path does this:
for (--i; i >= 0; --i) {which is a forever loop because "i" is unsigned.
Signed-off-by Dan Carpenter <[email protected]>
Sorry I missed this one. Applied.
Thanks!
Alex
Quoted 20 lines
drivers/gpu/drm/radeon/radeon_test.c +2
-2@@ -36,8 +36,8 @@ static void radeon_do_test_moves(struct radeon_device *rdev, int flag)struct radeon_bo *vram_obj =NULL ;struct radeon_bo **gtt_obj =NULL ;uint64_t gtt_addr, vram_addr; -unsigned i, n, size; -int r, ring; +unsigned n, size; +int i, r, ring;switch (flag) {case RADEON_TEST_COPY_DMA :_______________________________________________
dri-devel mailing list
[email protected]
http://lists.freedesktop.org/mailman/listinfo/dri-devel