fs/ext4/inode.c::mpage_map_and_submit_extent - unused variable warning

DISCUSSION Stefan Richter 2 participants 2 messages Jul 7, 2013

Share & tools

Stefan Richter

author

2013-07-07 09:55 UTC #0 lore raw

Hi,

gcc 4.6.3 says:
fs/ext4/inode.c: In function ‘ext4_writepages’:
fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wuninitialized] fs/ext4/inode.c:2161:6: note: ‘err’ was declared here

It would be an actual bug if mpage_map_and_submit_extent(handle, mpd, ...) can be called with mpd->map.m_len == 0. Can it?

Signature · 7 lines

Stefan Richter
-=====-===-= -=== --===
http://arcgraph.de/sr/
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in
the body of a message to [email protected]
More majordomo info at  http://vger.kernel.org/majordomo-info.html

Theodore Ts'o

2013-07-07 10:51 UTC #1 lore raw

Quoted 9 lines · Stefan Richter

Hi,
gcc 4.6.3 says:
fs/ext4/inode.c: In function ‘ext4_writepages’:
fs/ext4/inode.c:2219:6: warning: ‘err’ may be used uninitialized in this function [-Wuninitialized] fs/ext4/inode.c:2161:6: note: ‘err’ was declared here
It would be an actual bug if mpage_map_and_submit_extent(handle, mpd, ...) can be called with mpd->map.m_len == 0. Can it?

It can't and we have a patch queued up to remove the warning.

Cheers,

- Ted
--
To unsubscribe from this list: send the line "unsubscribe linux-ext4" in the body of a message to [email protected]
More majordomo info at http://vger.kernel.org/majordomo-info.html