drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user

PATCH Or Gerlitz 2 participants 3 messages Jul 8, 2013 2 messages not in the archive InfiniBand

lore

Share & tools

lore

Or Gerlitz

author

2013-07-08 09:58 UTC #1 lore raw

In reply to a message not in the archive

Quoted 16 lines · Fengguang Wu

Hi Eli,
FYI, there are coccinelle warnings in
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-next
head:   1af1abad19f6a40d8822cb7a35736e9e102fade6
commit: 809d3a921f9047bf575488f410ed12b365fe5cd7 [769/772] mlx5: Add driver for Mellanox Connect-IB adapters
Quoted 1 line
Quoted 1 line
drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user
--
Quoted 2 lines
Quoted 2 lines
drivers/infiniband/hw/mlx5/mr.c:445:2-3: Unneeded semicolon drivers/infiniband/hw/mlx5/mr.c:167:2-3: Unneeded semicolon
--
Quoted 3 lines
Quoted 3 lines
drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 938 drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 718 drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 1006

Quoted 7 lines

--
Quoted 2 lines
Quoted 2 lines
drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:145:11-19: WARNING opportunity for simple_open, see also structure on line 470 drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:145:11-19: WARNING opportunity for simple_open, see also structure on line 203
--
Quoted 2 lines
Quoted 2 lines
drivers/infiniband/hw/mlx5/mr.c:52:11-20: WARNING opportunity for simple_open, see also structure on line 289 drivers/infiniband/hw/mlx5/mr.c:52:11-20: WARNING opportunity for simple_open, see also structure on line 227
Please consider folding the attached diff with suitable fixups :-)

Hi Roland,

Eli is still OOO, I have reviewed the four patches and they are OK, please roll into the initial version

Or.
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Fengguang Wu

2013-07-08 10:58 UTC #3 lore raw

In reply to a message not in the archive

Quoted 21 lines · Or Gerlitz

Quoted 20 lines · Fengguang Wu
Hi Eli,
FYI, there are coccinelle warnings in
tree:   git://git.kernel.org/pub/scm/linux/kernel/git/roland/infiniband.git for-next
head:   1af1abad19f6a40d8822cb7a35736e9e102fade6
commit: 809d3a921f9047bf575488f410ed12b365fe5cd7 [769/772] mlx5: Add driver for Mellanox Connect-IB adapters
Quoted 1 line
Quoted 1 line
drivers/net/ethernet/mellanox/mlx5/core/cmd.c:894:7-14: WARNING opportunity for memdup_user
--
Quoted 2 lines
Quoted 2 lines
drivers/infiniband/hw/mlx5/mr.c:445:2-3: Unneeded semicolon drivers/infiniband/hw/mlx5/mr.c:167:2-3: Unneeded semicolon
--
Quoted 3 lines
Quoted 3 lines
drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 938 drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 718 drivers/net/ethernet/mellanox/mlx5/core/cmd.c:98:11-19: WARNING opportunity for simple_open, see also structure on line 1006
--
Quoted 2 lines
Quoted 2 lines
drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:145:11-19: WARNING opportunity for simple_open, see also structure on line 470 drivers/net/ethernet/mellanox/mlx5/core/debugfs.c:145:11-19: WARNING opportunity for simple_open, see also structure on line 203
--

Quoted 8 lines

Quoted 3 lines
Quoted 2 lines
Quoted 2 lines
drivers/infiniband/hw/mlx5/mr.c:52:11-20: WARNING opportunity for simple_open, see also structure on line 289 drivers/infiniband/hw/mlx5/mr.c:52:11-20: WARNING opportunity for simple_open, see also structure on line 227
Please consider folding the attached diff with suitable fixups :-)
Hi Roland,
Eli is still OOO, I have reviewed the four patches and they are OK, please roll into the initial version

Roland, you may need to replace some " " with "\t" in the patches.

Thanks,
Fengguang
--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html

Or Gerlitz

author

2013-07-08 12:06 UTC #4 lore raw

Quoted 1 line · Fengguang Wu

Roland, you may need to replace some " " with "\t" in the patches. Thanks, Fengguang

Roland, I have prepared these patches properly and will send them to you, they can be just squashed into the initial commit or come as add on patches.

Or.

--
To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to [email protected] More majordomo info at http://vger.kernel.org/majordomo-info.html